[ML] Add tooltips for actual and typical in anomalies table#97549
Merged
lcawl merged 2 commits intoelastic:masterfrom Apr 20, 2021
Merged
[ML] Add tooltips for actual and typical in anomalies table#97549lcawl merged 2 commits intoelastic:masterfrom
lcawl merged 2 commits intoelastic:masterfrom
Conversation
lcawl
commented
Apr 20, 2021
| name: ( | ||
| <EuiToolTip | ||
| content={i18n.translate('xpack.ml.overview.anomalyDetection.tableActualTooltip', { | ||
| defaultMessage: 'The actual values in the record results.', |
Contributor
Author
There was a problem hiding this comment.
defaultMessage: 'The actual values in the record results.',
The API documentation says "The actual value for the bucket", but I found this confusing since I thought there could be multiple record results per bucket.
Contributor
There was a problem hiding this comment.
You're right, there can be multiple record results for each bucket. actual and typical refer to the values seen for the record.
Contributor
There was a problem hiding this comment.
Is it worth adding anomaly in here - The actual values for the anomaly record results. ?
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/generating_signals·ts.detection engine api security and spaces enabled Generating signals from source indexes Signals from audit beat are of the expected structure Threshold Rules generates signals from Threshold rules when bucketing by multiple fieldsStandard OutStack TraceMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
lcawl
added a commit
to lcawl/kibana
that referenced
this pull request
Apr 20, 2021
lcawl
added a commit
that referenced
this pull request
Apr 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #97350
This PR adds tooltips for the "Typical" and "Actual" columns in the machine learning anomaly detection results table.