Skip to content

[Form lib] Add documentation#97309

Merged
sebelga merged 8 commits intoelastic:masterfrom
sebelga:docs/form-lib
Apr 23, 2021
Merged

[Form lib] Add documentation#97309
sebelga merged 8 commits intoelastic:masterfrom
sebelga:docs/form-lib

Conversation

@sebelga
Copy link
Copy Markdown
Contributor

@sebelga sebelga commented Apr 15, 2021 •
edited
Loading

This PR adds the documentation of the form lib in the new doc system.

This is a follow up of #78654. I have made all the code review suggestion/changes from that PR so hopefully reviewing this PR should be faster.

How to review

You need to have a fork of the new doc system repo on your machine.
As this repo is private, ping me and I will help to set it up. 😊

Screenshot 2021-04-20 at 14 38 03

@sebelga sebelga added documentation release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.13.0 v8.0.0 labels Apr 15, 2021
@sebelga sebelga marked this pull request as ready for review April 20, 2021 13:45
@sebelga sebelga requested a review from a team as a code owner April 20, 2021 13:45
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 20, 2021

Pinging @elastic/es-ui (Team:Elasticsearch UI)

jloleysens
jloleysens approved these changes Apr 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, what a joy to read 😄 ! I was really amazed at how powerful the form lib has become 💪🏻 . Thanks for all the hard work on this documentation @sebelga !

I tested the docs out locally and visited every page and skim read it 👀 and overall looks good to me!

Comment thread src/plugins/es_ui_shared/static/forms/docs/examples/serializers_deserializers.mdx Outdated
Comment thread src/plugins/es_ui_shared/static/forms/docs/core/form_hook.mdx Outdated
@sebelga @jloleysens
Apply suggestions from code review
2fcf57e 
Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
@sebelga
Copy link
Copy Markdown
Contributor Author

sebelga commented Apr 21, 2021

Thanks for the review @jloleysens !

I'll wait a few days to see if @elastic/docs-engineering has any comment for this PR 👍

@sebelga sebelga added v7.14.0 and removed v7.13.0 labels Apr 21, 2021
goodroot
goodroot reviewed Apr 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@goodroot goodroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my @elastic/docs-engineering perspective.

... Although I am not very familiar, and still ramping.

Excited to see the result, in any event. 🕺

@sebelga
Copy link
Copy Markdown
Contributor Author

sebelga commented Apr 23, 2021

@elasticmachine merge upstream

@sebelga
Copy link
Copy Markdown
Contributor Author

sebelga commented Apr 23, 2021

Thanks for the review @goodroot ! Could you also have a look at the corresponding PR (313) in the docs system? Cheers!

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 23, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sebelga sebelga merged commit be5f8a2 into elastic:master Apr 23, 2021
@sebelga sebelga mentioned this pull request Apr 23, 2021
Merged
@sebelga sebelga deleted the docs/form-lib branch April 23, 2021 15:41
sebelga added a commit that referenced this pull request Apr 23, 2021
@sebelga
[Form lib] Add documentation (#97309) (#98159)
cd6b161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jloleysens jloleysens jloleysens approved these changes

+1 more reviewer

@goodroot goodroot goodroot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.14.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sebelga @elasticmachine @kibanamachine @jloleysens @goodroot