[Dashboard] Fix Title BWC#95355
Merged
ThomThomson merged 2 commits intoelastic:masterfrom Mar 25, 2021
Merged
Conversation
ThomThomson
added
Feature:Dashboard
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Contributor
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
cqliu1
approved these changes
Mar 25, 2021
Contributor
cqliu1
left a comment
cqliu1
left a comment
There was a problem hiding this comment.
LGTM 👍 The title is properly hidden on the panel in view mode when the title is an empty string.
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Mar 25, 2021
* allow saving blank string to panel title
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Mar 25, 2021
* allow saving blank string to panel title
ThomThomson
added a commit
that referenced
this pull request
Mar 25, 2021
ThomThomson
added a commit
that referenced
this pull request
Mar 25, 2021
1 task
This was referenced Apr 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #95135
This is a very small PR that fixes backwards compatibility for hidden panel titles. Before 7.10.0, hidden titles were saved as a blank string, and this partially recreates that behaviour. Now setting a panel's title to a blank string, or loading a hidden panel from pre 7.10 will make it hidden in view mode.
How to test?
a) You can test by simply giving any panel on a dashboard a custom title of an empty string. Previously this would revert to the saved object title, but now it will count as a valid title, and will be hidden if you switch to view mode.
b) A more drastic test would be to create a dashboard in any version before 7.10, hide some panel titles using the switch, then export that dashboard and import it in this branch. All the panels that were configured to have a hidden title should still be hidden in view mode. Switching to edit mode, you should see
[No Title]