[Time To Visualize] Edit Panel Title On Click

[ThomThomson]

Summary

Closes #81047

Adds an EuiLink to the title on panel headers which opens the title customization menu.

Known Issue
For some reason, when text is inside the EuiLink, the font-weight: 700 style on the title is lost

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-canvas (Team:Canvas)

[streamich]

Code LGTM.

What do you think about creating a new TITLE_CLICK_TRIGGER trigger, so that anyone would be able to attach actions to it?

[ThomThomson]

The main idea with this one is to lower the number of clicks required - if we created a trigger, potentially there could be multiple actions registered correct? Then we'd have to render a popover to show them - which would kind of defeat the purpose.

That said, I do like how clean it would make the code - this PR has a wee bit of a code smell to be honest. Additionally, we could do something like if 1 action is registered, run it, if multiple actions are registered show a popover and try to ensure that people only use the TITLE_CLICK_TRIGGER if absolutely necessary.

[ryankeairns]

@ThomThomson To resolve the bold font issue, just add a custom className to your EuiLink (e.g. embPanel__titleLink) and set this style in
src/plugins/embeddable/public/lib/panel/_embeddable_panel.scss:

.embPanel__titleLink {
   font-weight: $euiFontWeightBold;
}

[ryankeairns]

@ThomThomson I opened a small design PR that slightly simplifies the class logic / uses the existing class nams vs introducing another one. If it looks good to you, then feel free to merge it in here and I'll stamp this PR.

[ThomThomson]

@ryankeairns this is way more readable, thanks!

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: f1d619a

Metrics [docs]

page load bundle size

id	before	after	diff
embeddable	301.5KB	301.8KB	+363.0B

History

• 💚 Build #83384 succeeded f8906e0
• 💚 Build #82943 succeeded 5b81d87
• 💚 Build #82903 succeeded 8bc46e3
• 💔 Build #82629 failed 6e4071e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[AlonaNadler]

wow that was fast!!

[th0ger]

After upgrading to Kibana 7.11, I experienced that all panel titles that was disabled, had now been enabled.
I think that this feature may have been the cause.

[ThomThomson]

@th0ger, this regression should be fixed in 7.12.1 by #95355