Skip to content

[FTR][CI] Use default distribution for all tests#94968

Merged
tylersmalley merged 6 commits intoelastic:masterfrom
tylersmalley:rm-oss-build
May 12, 2021
Merged

[FTR][CI] Use default distribution for all tests#94968
tylersmalley merged 6 commits intoelastic:masterfrom
tylersmalley:rm-oss-build

Conversation

@tylersmalley
Copy link
Member

@tylersmalley tylersmalley commented Mar 18, 2021

No longer builds oss distribution and runs tests against it. All tests run against the default distribution.

Fixes #87711
Fixes #76168
Fixes #91242
Fixes #92302

@tylersmalley
Copy link
Member Author

@elasticmachine merge upstream

@tylersmalley tylersmalley force-pushed the rm-oss-build branch 2 times, most recently from 840654a to 5b584c1 Compare March 23, 2021 14:47
@tylersmalley
Copy link
Member Author

tylersmalley commented Mar 25, 2021

@legrego @jportner, thanks for your help. The failures I am currently looking into are in test/api_integration/apis/saved_objects/find.ts. A reproduction outside the functional test runner:

  • node scripts/functional_tests_server.js --config test/api_integration/config.js
  • node scripts/es_archiver.js load saved_objects/basic --config test/api_integration/config.js
  • curl "http://elastic:changeme@localhost:5620/api/saved_objects/_find?type=visualization&namespaces=foo"

Error:

   │ proc [kibana] {
   │ proc [kibana]   "name": "ResponseError",
   │ proc [kibana]   "meta": {
   │ proc [kibana]     "body": {
   │ proc [kibana]       "error": {
   │ proc [kibana]         "root_cause": [
   │ proc [kibana]           {
   │ proc [kibana]             "type": "illegal_argument_exception",
   │ proc [kibana]             "reason": "application privileges must refer to at least one resource"
   │ proc [kibana]           }
   │ proc [kibana]         ],
   │ proc [kibana]         "type": "illegal_argument_exception",
   │ proc [kibana]         "reason": "application privileges must refer to at least one resource"
   │ proc [kibana]       },
   │ proc [kibana]       "status": 400
   │ proc [kibana]     },
   │ proc [kibana]     "statusCode": 400,
   │ proc [kibana]     "headers": {
   │ proc [kibana]       "x-opaque-id": "079017f4-5814-474a-93b3-4fe868f941a6",
   │ proc [kibana]       "content-type": "application/json;charset=utf-8",
   │ proc [kibana]       "content-length": "253"
   │ proc [kibana]     },
   │ proc [kibana]     "meta": {
   │ proc [kibana]       "context": null,
   │ proc [kibana]       "request": {
   │ proc [kibana]         "params": {
   │ proc [kibana]           "method": "POST",
   │ proc [kibana]           "path": "/_security/user/_has_privileges",
   │ proc [kibana]           "body": "{\"index\":[],\"applications\":[{\"application\":\"kibana-.kibana\",\"resources\":[],\"privileges\":[\"version:8.0.0\",\"login:\",\"saved_object:8.0.0:config/find\"]}]}",
   │ proc [kibana]           "querystring": "",
   │ proc [kibana]           "headers": {
   │ proc [kibana]             "user-agent": "elasticsearch-js/8.0.0-canary.3 (linux 5.8.0-45-generic-x64; Node.js v14.16.0)",
   │ proc [kibana]             "x-elastic-product-origin": "kibana",
   │ proc [kibana]             "x-opaque-id": "079017f4-5814-474a-93b3-4fe868f941a6",
   │ proc [kibana]             "authorization": "Basic ZWxhc3RpYzpjaGFuZ2VtZQ==",
   │ proc [kibana]             "x-elastic-client-meta": "es=8.0.0p,js=14.16.0,t=8.0.0p,hc=14.16.0",
   │ proc [kibana]             "content-type": "application/json",
   │ proc [kibana]             "content-length": "150"
   │ proc [kibana]           },
   │ proc [kibana]           "timeout": 30000
   │ proc [kibana]         },
   │ proc [kibana]         "options": {},
   │ proc [kibana]         "id": 1
   │ proc [kibana]       },
   │ proc [kibana]       "name": "elasticsearch-js",
   │ proc [kibana]       "connection": {
   │ proc [kibana]         "url": "http://localhost:9220/",
   │ proc [kibana]         "id": "http://localhost:9220/",
   │ proc [kibana]         "headers": {},
   │ proc [kibana]         "deadCount": 0,
   │ proc [kibana]         "resurrectTimeout": 0,
   │ proc [kibana]         "_openRequests": 0,
   │ proc [kibana]         "status": "alive",
   │ proc [kibana]         "roles": {
   │ proc [kibana]           "master": true,
   │ proc [kibana]           "data": true,
   │ proc [kibana]           "ingest": true,
   │ proc [kibana]           "ml": false
   │ proc [kibana]         }
   │ proc [kibana]       },
   │ proc [kibana]       "attempts": 0,
   │ proc [kibana]       "aborted": false
   │ proc [kibana]     }
   │ proc [kibana]   }
   │ proc [kibana] }

@tylersmalley tylersmalley force-pushed the rm-oss-build branch 12 times, most recently from 8838b92 to 05af712 Compare March 31, 2021 22:14
@tylersmalley tylersmalley force-pushed the rm-oss-build branch 8 times, most recently from 544b9b1 to d423f30 Compare April 19, 2021 22:54
@tylersmalley tylersmalley force-pushed the rm-oss-build branch 4 times, most recently from f400b6e to 896b1fe Compare April 27, 2021 15:54
@tylersmalley
Copy link
Member Author

@elastic/kibana-alerting-services

I am running into an issue where I could use your assistance with.

This pull request removes the oss build from the functional tests, meaning that all functional tests will be running against our single, default distribution.

The status page functional tests are currently failing due to the alerting plugin being red with Alerting framework is unavailable. When syncing with @mikecote, we determined this is most likely due to the health task being removed when the esArchive is either loaded or unloaded. When the task is unable to be found, it results in the status being updated.

A way I have been able to reproduce this is by running the functional test server with:

node scripts/functional_tests_server.js --config test/functional/config.js

Then, run node scripts/functional_test_runner --config test/functional/config.js --grep "context app" followed by node scripts/functional_test_runner --config test/functional/config.js --grep "status page".

Looking for help in how to proceed. Thanks :elasticheart:

@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 94968

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 14, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

2 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@tylersmalley
Copy link
Member Author

I am working on another PR to master to resolve the issues with the backport.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@tylersmalley tylersmalley added the backport:skip This PR does not require backporting label May 20, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 20, 2021
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request May 28, 2021
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley added a commit that referenced this pull request May 28, 2021
* [FTR][CI] Use default distribution for all tests (#94968)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* Use default output

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* [FTR] Use importExport for saved_object/basic archive

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* Update suggestions tests

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* Fix build

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* More migrations to kbnArchiver

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley added a commit that referenced this pull request May 29, 2021
tylersmalley added a commit that referenced this pull request May 29, 2021
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Jun 3, 2021
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Jun 8, 2021
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Copy link
Member Author

backport: #101118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.14.0 v8.0.0

Projects

None yet

9 participants