-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] Add cache control to mvt endpoints #94861
Merged
thomasneirynck
merged 15 commits into
elastic:master
from
thomasneirynck:maps/mvt_cachecontrol
Apr 15, 2021
Merged
[Maps] Add cache control to mvt endpoints #94861
thomasneirynck
merged 15 commits into
elastic:master
from
thomasneirynck:maps/mvt_cachecontrol
Apr 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/kibana-gis (Team:Geo) |
@elasticmachine merge upstream |
nreese
reviewed
Apr 14, 2021
x-pack/plugins/maps/public/classes/layers/tiled_vector_layer/tiled_vector_layer.tsx
Outdated
Show resolved
Hide resolved
nreese
approved these changes
Apr 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
code review, tested in chrome
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Apr 15, 2021
thomasneirynck
added a commit
that referenced
this pull request
Apr 15, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo
Former Team Label for Geo Team. Now use Team:Presentation
release_note:enhancement
v7.13.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because of #93531, mvt-tile-url refreshes are no longer reliant on the shape of the URL. This allows Maps to more aggressively add caching-instructions to the tile-response.
The practical result is that the browser should return tiles from disc-cache during a user-session (up to an hour). Filtering (time, queries, ...) should trigger new request if there's a change, but not if the user moves back&forth between configurations. Pressing the refresh-button/auto-refresh will still trigger a new tile request, because Maps will update the URL by adding a token.
Checklist
For maintainers