Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Compare SearchFilters to determine whether mvt layers can skip update #93531

Merged
merged 9 commits into from
Mar 11, 2021
Merged

[Maps] Compare SearchFilters to determine whether mvt layers can skip update #93531

merged 9 commits into from
Mar 11, 2021

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Mar 3, 2021 •
edited
Loading

Closes #79690

@thomasneirynck thomasneirynck added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.13.0 v8.0.0 release_note:fix WIP Work in progress labels Mar 3, 2021
@thomasneirynck thomasneirynck marked this pull request as ready for review March 5, 2021 20:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck thomasneirynck requested review from nreese and kindsun March 5, 2021 20:40
@thomasneirynck thomasneirynck requested a review from nreese March 10, 2021 15:55
@thomasneirynck thomasneirynck requested a review from nreese March 11, 2021 16:16
nreese
nreese approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review, tested in chrome

@thomasneirynck thomasneirynck changed the title [Maps] Compare SearchFilters to determine whether layer can skip update [Maps] Compare SearchFilters to determine whether mvt layers can skip update Mar 11, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.7MB 2.7MB +359.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck thomasneirynck merged commit 9d365a4 into elastic:master Mar 11, 2021
@thomasneirynck thomasneirynck mentioned this pull request Mar 11, 2021
Merged
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Mar 11, 2021
@thomasneirynck
[Maps] Compare SearchFilters to determine whether mvt layers can skip…
89af108 
… update (elastic#93531)
thomasneirynck added a commit that referenced this pull request Mar 11, 2021
@thomasneirynck
[Maps] Compare SearchFilters to determine whether mvt layers can skip…
ef4dc35 
… update (#93531) (#94479)
@thomasneirynck thomasneirynck mentioned this pull request Mar 17, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@kindsun kindsun Awaiting requested review from kindsun

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:fix v7.13.0 v8.0.0 WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps] time-based mvt data is refreshed frequently for .mvt scaling-type
4 participants
@thomasneirynck @elasticmachine @kibanamachine @nreese