[tribe] Removes factory objects and adds addClientPlugin to Cluster#9467
Merged
tylersmalley merged 1 commit intoelastic:tribe-node-supportfrom Dec 14, 2016
Merged
Conversation
tylersmalley
changed the title
jbudz
reviewed
Dec 14, 2016
Contributor
jbudz
left a comment
jbudz
left a comment
There was a problem hiding this comment.
One comment, otherwise LGTM
Contributor
There was a problem hiding this comment.
thoughts on using createClients.call(this), or passing the config in instead?
Member
Author
There was a problem hiding this comment.
Pushed a fix. I played around previously with passing config to createClients and having it return an array or object containing the clients but it was messier than I would have liked.
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
force-pushed
the
tribe-removefactory
branch
from
085d431 to
e961ba8
Compare
jbudz
approved these changes
Dec 14, 2016
jbudz
pushed a commit
that referenced
this pull request
Dec 30, 2016
* Adds support for Tribe nodes Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * @spalger review feedback * Close create{Admin,Data}Cluster handles closing the connection * Remove callAsKibanaUser argument from tests * ClientLogger uses ES6 properties for tags and logQueries * Ensure were destructuring cluster to access callAsKibanaUser Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * [tribe] Use class syntax on new data sources * [tribe] Use includes instead of indexOf in call_client * [tribe] DocRequest --> AbstractDocRequest * [tribe] Fix AbstractDoc test rename * Removes factory objects and adds addClientPlugin to Cluster (#9467) Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Resolves eslint error Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Use properties on the instance instead of class properties Class properties are still in the very eary stages and not widely supported. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * [tribe] Remove disabled dev tools app, do not bundle console when tribe is enabled * [tribe] Use destructuring, don't reassign args * [tribe] Use class syntax for client request wrapper * [tribe] callAsKibanaUser -> callWithInternalUser * [tribe] Remove clients from module context, service is a singleton * [tribe] Use instance property shorthand for admin and data DocRequests * Removes questions Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Fixes typo in tests Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Correctly names test case Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Revert "Use properties on the instance instead of class properties" This reverts commit ebd06ae. * Adds tests for create_{admin,data}_cluster Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Persists clusters to server Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * [tribe] Move cluster config requests to distinct getters * Adds getClient and removes addClientPlugin Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Expose createClient, consolidate config parsing Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Removes createClients from Cluster Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Prevent status change from red to red Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Updates esvm:tribe ports to be consistant with dev 9200 is admin 9201:9202 are both data clusters 9203 is a tribe node connecting to both data clusters Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * [tribe] Get ssl.ca from serverConfig * [tribe/esvm] Remove plugin configuration * Removes unused variable Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * [tribe] Named exports for creating clusters * [tribe] Named exports for client logger, cluster * [tribe] Named exports for health check * Remove invalid comment Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * [tribe] Comment explaining difference between admin and data browser clients * Rename ES checks to be consistant with functionality Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Organize NOOP functions Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Removing function comments Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Explicitly check for presence of url in tribe Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
jbudz
pushed a commit
to jbudz/kibana
that referenced
this pull request
Dec 30, 2016
* Adds support for Tribe nodes Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * @spalger review feedback * Close create{Admin,Data}Cluster handles closing the connection * Remove callAsKibanaUser argument from tests * ClientLogger uses ES6 properties for tags and logQueries * Ensure were destructuring cluster to access callAsKibanaUser Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * [tribe] Use class syntax on new data sources * [tribe] Use includes instead of indexOf in call_client * [tribe] DocRequest --> AbstractDocRequest * [tribe] Fix AbstractDoc test rename * Removes factory objects and adds addClientPlugin to Cluster (elastic#9467) Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Resolves eslint error Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Use properties on the instance instead of class properties Class properties are still in the very eary stages and not widely supported. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * [tribe] Remove disabled dev tools app, do not bundle console when tribe is enabled * [tribe] Use destructuring, don't reassign args * [tribe] Use class syntax for client request wrapper * [tribe] callAsKibanaUser -> callWithInternalUser * [tribe] Remove clients from module context, service is a singleton * [tribe] Use instance property shorthand for admin and data DocRequests * Removes questions Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Fixes typo in tests Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Correctly names test case Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Revert "Use properties on the instance instead of class properties" This reverts commit ebd06ae. * Adds tests for create_{admin,data}_cluster Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Persists clusters to server Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * [tribe] Move cluster config requests to distinct getters * Adds getClient and removes addClientPlugin Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Expose createClient, consolidate config parsing Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Removes createClients from Cluster Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Prevent status change from red to red Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Updates esvm:tribe ports to be consistant with dev 9200 is admin 9201:9202 are both data clusters 9203 is a tribe node connecting to both data clusters Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * [tribe] Get ssl.ca from serverConfig * [tribe/esvm] Remove plugin configuration * Removes unused variable Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * [tribe] Named exports for creating clusters * [tribe] Named exports for client logger, cluster * [tribe] Named exports for health check * Remove invalid comment Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * [tribe] Comment explaining difference between admin and data browser clients * Rename ES checks to be consistant with functionality Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Organize NOOP functions Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Removing function comments Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Explicitly check for presence of url in tribe Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
pushed a commit
that referenced
this pull request
Jan 3, 2017
* Adds support for Tribe nodes Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * @spalger review feedback * Close create{Admin,Data}Cluster handles closing the connection * Remove callAsKibanaUser argument from tests * ClientLogger uses ES6 properties for tags and logQueries * Ensure were destructuring cluster to access callAsKibanaUser Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * [tribe] Use class syntax on new data sources * [tribe] Use includes instead of indexOf in call_client * [tribe] DocRequest --> AbstractDocRequest * [tribe] Fix AbstractDoc test rename * Removes factory objects and adds addClientPlugin to Cluster (#9467) Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Resolves eslint error Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Use properties on the instance instead of class properties Class properties are still in the very eary stages and not widely supported. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * [tribe] Remove disabled dev tools app, do not bundle console when tribe is enabled * [tribe] Use destructuring, don't reassign args * [tribe] Use class syntax for client request wrapper * [tribe] callAsKibanaUser -> callWithInternalUser * [tribe] Remove clients from module context, service is a singleton * [tribe] Use instance property shorthand for admin and data DocRequests * Removes questions Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Fixes typo in tests Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Correctly names test case Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Revert "Use properties on the instance instead of class properties" This reverts commit ebd06ae. * Adds tests for create_{admin,data}_cluster Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Persists clusters to server Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * [tribe] Move cluster config requests to distinct getters * Adds getClient and removes addClientPlugin Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Expose createClient, consolidate config parsing Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Removes createClients from Cluster Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Prevent status change from red to red Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Updates esvm:tribe ports to be consistant with dev 9200 is admin 9201:9202 are both data clusters 9203 is a tribe node connecting to both data clusters Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * [tribe] Get ssl.ca from serverConfig * [tribe/esvm] Remove plugin configuration * Removes unused variable Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * [tribe] Named exports for creating clusters * [tribe] Named exports for client logger, cluster * [tribe] Named exports for health check * Remove invalid comment Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * [tribe] Comment explaining difference between admin and data browser clients * Rename ES checks to be consistant with functionality Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Organize NOOP functions Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Removing function comments Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Explicitly check for presence of url in tribe Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes factory objects and adds addClientPlugin to Cluster