[tribe] Disable dev tools on the client when tribe is enabled#9375
Merged
tylersmalley merged 3 commits intoelastic:tribe-node-supportfrom Dec 6, 2016
Merged
[tribe] Disable dev tools on the client when tribe is enabled#9375tylersmalley merged 3 commits intoelastic:tribe-node-supportfrom
tylersmalley merged 3 commits intoelastic:tribe-node-supportfrom
Conversation
tylersmalley
reviewed
Dec 6, 2016
| modules.get('kibana').run(Notifier.pullMessageFromUrl); | ||
|
|
||
| modules.get('kibana').run(function ($rootScope, $location) { | ||
| if (!chrome.getInjected('tribeEnabled')) return; |
Member
There was a problem hiding this comment.
According to the styleguide, we should use braces around the conditional
tylersmalley
reviewed
Dec 6, 2016
| navLink.disabled = true; | ||
| navLink.tooltip = 'Dev Tools are disabled when using tribe nodes'; | ||
| $rootScope.$on('$locationChangeStart', function (event, newUrl) { | ||
| if (~newUrl.indexOf(navLink.url)) $location.path('/').replace(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This disables dev tools on the client when connecting to a tribe node. Part of #9132