[Bug] missing timepicker:quickRanges migration

[lizozom]

Summary

Resolves #92267

While the format of timepicker:quickRanges changed in 6.x, upgrades continued working as the format was backwards compatible.
But since 7.9 added uiSettings validation, old formats would cause errors if trying to edit them:

{"type":"log","@timestamp":"2021-02-22T12:17:17-05:00","tags":["warning","ui-settings-service"],"pid":73756,"message":"Ignore invalid UiSettings value. Error: [validation [timepicker:quickRanges].0.section]: definition for this key is missing."}
{"type":"log","@timestamp":"2021-02-22T12:17:27-05:00","tags":["warning","ui-settings-service"],"pid":73756,"message":"Ignore invalid UiSettings value. Error: [validation [timepicker:quickRanges].0.section]: definition for this key is missing."}
{"type":"log","@timestamp":"2021-02-22T12:17:37-05:00","tags":["warning","ui-settings-service"],"pid":73756,"message":"Ignore invalid UiSettings value. Error: [validation [timepicker:quickRanges].0.section]: definition for this key is missing."}

This PR adds a migration removing the section parameter from timepicker:quickRanges, when upgrading beyond 7.12.

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app-services (Team:AppServices)

[joshdover]

Should we also add a new migration for 7.12 that does this change too? That way if someone already upgraded to 7.9-7.11, they'll also get the fix.

[rudolf]

yeah for the reason Josh mentioned we should rather release this as a 7.12 migration since we can't backport the migration itself to 7.9.

From
https://www.elastic.co/guide/en/kibana/7.12/kibana-platform-api.html#_writing_migrations

The version number of a migration must always be the earliest Kibana version in which this migration was released. So if you are creating a migration which will be part of the v7.10.0 release, but will also be backported and released as v7.9.3, the migration version should be: 7.9.3.

[lizozom]

@rudolf @joshdover I've turned this into a 7.12 migration

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: d3ec0f5
• Storybooks Preview

Metrics [docs]

✅ unchanged

History

• 💚 Build #110710 succeeded b8fa33b
• 💔 Build #110692 failed ddd9222

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lizozom

[lukeelmers]

@lizozom Would you be willing to add a unit test for this in a follow-up PR? New migrations always make me a bit nervous 🙂