[Discover] Restore context documentation#90784
Merged
kertal merged 17 commits intoelastic:masterfrom Mar 4, 2021
Merged
Conversation
kertal
changed the title
kertal
commented
Feb 9, 2021
gchaps
reviewed
Feb 10, 2021
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
kertal
added
v7.12.0
v8.0.0
Team:Visualizations
gchaps
reviewed
Feb 25, 2021
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
wylieconlon
approved these changes
Mar 2, 2021
gchaps
approved these changes
Mar 2, 2021
Contributor
gchaps
left a comment
gchaps
left a comment
There was a problem hiding this comment.
A few suggestions for images, but otherwise LGTM
| and displayed using the same set of columns as the *Discover* view from which | ||
| the context was opened. The anchor document is highlighted in blue. | ||
| + | ||
| [role="screenshot"] |
Contributor
There was a problem hiding this comment.
I think we should change the context view to show the anchor doc in the middle, so the reader sees docs both above and below the anchor.
Member
Author
There was a problem hiding this comment.
👍 I've changed it new file is also smaller in size but better in resolution, so it's a win
Member
Author
true dear @gchaps , should we back port it to the versions before 7.12? |
Member
Author
as discussed offline I'll back port to 7.10 |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Mar 4, 2021
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> # Conflicts: # docs/images/Discover-ContextView.png
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Mar 4, 2021
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> # Conflicts: # docs/images/Discover-ContextView.png
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Mar 4, 2021
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> # Conflicts: # docs/images/Discover-ContextView.png # docs/user/discover.asciidoc
kertal
added a commit
that referenced
this pull request
Mar 4, 2021
kertal
added a commit
that referenced
this pull request
Mar 4, 2021
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Mar 4, 2021
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> # Conflicts: # docs/images/Discover-ContextView.png # docs/user/discover.asciidoc
kertal
added a commit
that referenced
this pull request
Mar 4, 2021
kertal
added a commit
that referenced
this pull request
Mar 4, 2021
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 4, 2021
* master: (107 commits) [Logs UI] Fix log stream data fetching (elastic#93201) [App Search] Added relevance tuning search preview (elastic#93054) [Canvas] Fix reports embeddables (elastic#93482) [ILM] Added new functional test in ILM for creating a new policy (elastic#92936) Remove direct dependency on statehood package (elastic#93592) [Maps] Track tile loading status (elastic#91585) [Discover][Doc] Improve main documentation (elastic#91854) [Upgrade Assistant] Disable UA and add prompt (elastic#92834) [Snapshot Restore] Remove cloud validation for slm policy (elastic#93609) [Maps] Support GeometryCollections in GeoJson upload (elastic#93507) [XY Charts] fix partial histogram endzones annotations (elastic#93091) [Core] Simplify context typings (elastic#93579) [Alerting] Improving health status check (elastic#93282) [Discover] Restore context documentation (elastic#90784) [core-docs] Edits core-intro section for the new docs system (elastic#93540) add missed codeowners (elastic#89714) fetch node labels via script execution (elastic#93225) [Security Solution] Adds getMockTheme function (elastic#92840) Sort dependencies in package.json correctly (elastic#93590) [Bug] missing timepicker:quickRanges migration (elastic#93409) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores and adapts Discover's Context view documentation.
Checklist