Skip to content

[jenkins] convert baseline capture job to use tasks#93288

Merged
spalger merged 6 commits intoelastic:masterfrom
spalger:fix/baseline-metric-inconsistency
Mar 2, 2021
Merged

[jenkins] convert baseline capture job to use tasks#93288
spalger merged 6 commits intoelastic:masterfrom
spalger:fix/baseline-metric-inconsistency

Conversation

@spalger
Copy link
Contributor

@spalger spalger commented Mar 2, 2021

We're seeing inconsistent metrics reported for the triggerActionsUi bundle right now, seemingly caused by Webpack producing additional chunks in certain scenarios. It's not 100% clear why Webpack is doing this, but what we do know is that:

  • all master builds on the tracked branch and PR jobs are producing triggerActionsUi page load entry size of 106624 bytes
  • all master baseline builds are producing a triggerActionsUi page load entry size of 106542 bytes
  • baseline builds use a basic checkout to build from, while tracked branch/pr builds use a weird symlink filled node_modules directory to aid in parallelism that could definitely be the cause of this.

I'm hoping that running the baseline job using the Jenkins tasks structure will at least produce consistent results for these jobs so that we don't have false metric changes reported on PRs anymore.

brianseeders
brianseeders reviewed Mar 2, 2021
View reviewed changes
@spalger
Copy link
Contributor Author

spalger commented Mar 2, 2021

Confirmed this leads to the baseline build reporting a page load entry size of 106624 bytes

image

@spalger spalger added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.12.0 v7.13.0 v8.0.0 labels Mar 2, 2021
@spalger spalger marked this pull request as ready for review March 2, 2021 21:04
@spalger spalger requested a review from a team as a code owner March 2, 2021 21:04
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 2, 2021

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger requested a review from brianseeders March 2, 2021 21:04
tylersmalley
tylersmalley approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - curious what caused Webpack to change the chunks around, but glad to see this solved the underlying problem.

@spalger spalger enabled auto-merge (squash) March 2, 2021 21:10
@spalger spalger added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 2, 2021
@spalger spalger mentioned this pull request Mar 2, 2021
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 2, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.5MB -23.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 104.1KB 104.2KB +82.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 41 42 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 3b66431 into elastic:master Mar 2, 2021
@kibanamachine kibanamachine mentioned this pull request Mar 2, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 2, 2021
@spalger @kibanamachine
[jenkins] convert baseline capture job to use tasks (elastic#93288)
92cd274 
Co-authored-by: spalger <spalger@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 2, 2021

💔 Backport failed

❌ 7.12: Commit could not be cherrypicked due to conflicts
✅ 7.x / #93343

Successful backport PRs will be merged automatically after passing CI.

To backport manually, check out the target branch and run:
node scripts/backport --pr 93288

@spalger spalger mentioned this pull request Mar 2, 2021
Merged
spalger added a commit to spalger/kibana that referenced this pull request Mar 2, 2021
@spalger
[jenkins] convert baseline capture job to use tasks (elastic#93288)
8249822 
Co-authored-by: spalger <spalger@users.noreply.github.com>
# Conflicts:
#	src/dev/ci_setup/setup.sh
@spalger spalger deleted the fix/baseline-metric-inconsistency branch March 2, 2021 23:17
kibanamachine added a commit that referenced this pull request Mar 3, 2021
@kibanamachine @spalger
[jenkins] convert baseline capture job to use tasks (#93288) (#93343)
abd1422 
Co-authored-by: spalger <spalger@users.noreply.github.com>

Co-authored-by: Spencer <email@spalger.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger added a commit that referenced this pull request Mar 3, 2021
@spalger
[jenkins] convert baseline capture job to use tasks (#93288) (#93345)
3338b75 
Co-authored-by: spalger <spalger@users.noreply.github.com>
# Conflicts:
#	src/dev/ci_setup/setup.sh
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 3, 2021
@gmmorris
Merge branch 'master' into task-manager/docs-monitoring
b0c15d5 
* master: (45 commits)
  Add outcome of node scripts/build_api_docs (elastic#93399)
  [Lens] fix long field name on field stats panel doesn't wrap (elastic#93279)
  [Bug] Fix filter creation for numeric scripted fields in Discover (elastic#93224)
  [uptime] Fix anomaly alert edit (elastic#93025)
  Consolidate @babel/* packages and use latest compatible version (elastic#93264)
  [Search Embeddable] Add highlighting when searching (elastic#93178)
  [APM] Add missing bottom border to header (elastic#93179)
  [CI] No longer collect APM span stack traces (elastic#93263)
  [XY Chart] Fix "No data to display" error when using IP range aggregation to split series (elastic#93024)
  update generated public api docs
  API DOCS Step 3/3 (elastic#92929)
  chore(NA): look for bazel packages on npm_module folder during distributable build (elastic#93262)
  rename advanced setting ml:fileDataVisualizerMaxFileSize to fileUpload:maxFileSize and increase max geojson upload size to 1GB (elastic#92620)
  [kbn/optimizer] allow customizing the limits path from the script (elastic#93153)
  [Alerting][Docs] Adding template for documenting alert and action types (elastic#92830)
  [jenkins] convert baseline capture job to use tasks (elastic#93288)
  removing the linked issue in comments from PR (elastic#93303)
  chore(NA): do not include fs within a storybook build (elastic#93294)
  [Maps] Update Map extent queries to use bounding box logic for both point and shape queries (elastic#93156)
  Add searchDuration to EQL and Threshold rules (elastic#93149)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@brianseeders brianseeders brianseeders approved these changes

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.12.0 v7.13.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@spalger @elasticmachine @kibanamachine @tylersmalley @brianseeders