Skip to content

chore(NA): look for bazel packages on npm_module folder during distributable build#93262

Merged
mistic merged 2 commits intoelastic:masterfrom
mistic:look-for-bazel-packages-builds-on-a-give-folder
Mar 3, 2021
Merged

chore(NA): look for bazel packages on npm_module folder during distributable build#93262
mistic merged 2 commits intoelastic:masterfrom
mistic:look-for-bazel-packages-builds-on-a-give-folder

Conversation

@mistic
Copy link
Contributor

@mistic mistic commented Mar 2, 2021

One step forward on #69706

That PR instructs the distributable build to look for packages inside bazel/bin/packages/{package_name}/npm_module instead of the base folder for the package so we can have a better control of the files inside that folder.

@mistic mistic added chore Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Mar 2, 2021
@mistic mistic requested a review from tylersmalley March 2, 2021 16:52
@mistic mistic requested a review from a team as a code owner March 2, 2021 16:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.5MB -23.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 104.0KB 104.1KB +82.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 41 42 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 2, 2021
@mistic mistic merged commit a36b64e into elastic:master Mar 3, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 3, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.x / #93359

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 3, 2021
…butable build (#93262) (#93359)

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 3, 2021
* master: (45 commits)
  Add outcome of node scripts/build_api_docs (elastic#93399)
  [Lens] fix long field name on field stats panel doesn't wrap (elastic#93279)
  [Bug] Fix filter creation for numeric scripted fields in Discover (elastic#93224)
  [uptime] Fix anomaly alert edit (elastic#93025)
  Consolidate @babel/* packages and use latest compatible version (elastic#93264)
  [Search Embeddable] Add highlighting when searching (elastic#93178)
  [APM] Add missing bottom border to header (elastic#93179)
  [CI] No longer collect APM span stack traces (elastic#93263)
  [XY Chart] Fix "No data to display" error when using IP range aggregation to split series (elastic#93024)
  update generated public api docs
  API DOCS Step 3/3 (elastic#92929)
  chore(NA): look for bazel packages on npm_module folder during distributable build (elastic#93262)
  rename advanced setting ml:fileDataVisualizerMaxFileSize to fileUpload:maxFileSize and increase max geojson upload size to 1GB (elastic#92620)
  [kbn/optimizer] allow customizing the limits path from the script (elastic#93153)
  [Alerting][Docs] Adding template for documenting alert and action types (elastic#92830)
  [jenkins] convert baseline capture job to use tasks (elastic#93288)
  removing the linked issue in comments from PR (elastic#93303)
  chore(NA): do not include fs within a storybook build (elastic#93294)
  [Maps] Update Map extent queries to use bounding box logic for both point and shape queries (elastic#93156)
  Add searchDuration to EQL and Threshold rules (elastic#93149)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.13.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants