Skip to content

[Rollup] Fix use of undefined value in JS import #92791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2021
Merged

[Rollup] Fix use of undefined value in JS import #92791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc9831c
Remove use of undefined import
jloleysens Feb 25, 2021
10767b2
added component integration test for default value in frequency
jloleysens Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions x-pack/plugins/rollup/public/crud_app/sections/job_create/steps_config/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@

import { cloneDeep, get, pick } from 'lodash';

import { WEEK } from '../../../../../../../../src/plugins/es_ui_shared/public';

import { validateId } from './validate_id';
import { validateIndexPattern } from './validate_index_pattern';
import { validateRollupIndex } from './validate_rollup_index';
Expand Down Expand Up @@ -66,7 +64,7 @@ export const stepIdToStepConfigMap = {
// a few hours as they're being restarted. A delay of 1d would allow them that period to reboot
// and the "expense" is pretty negligible in most cases: 1 day of extra non-rolled-up data.
rollupDelay: '1d',
cronFrequency: WEEK,
cronFrequency: 'WEEK',
fieldToPreferredValueMap: {},
};

Expand Down
5 changes: 5 additions & 0 deletions x-pack/plugins/rollup/public/test/client_integration/job_create_logistics.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,11 @@ describe('Create Rollup Job, step 1: Logistics', () => {
expect(options).toEqual(['minute', 'hour', 'day', 'week', 'month', 'year']);
});

it('should default to "WEEK"', () => {
const frequencySelect = find('cronFrequencySelect');
expect(frequencySelect.props().value).toBe('WEEK');
});

describe('every minute', () => {
it('should not have any additional configuration', () => {
changeFrequency('MINUTE');
Expand Down