[Rollup] Fix use of undefined value in JS import #92791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
added
release_note:fix
Feature:ILM
v8.0.0
Team:Kibana Management
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
jloleysens
requested review from
alisonelizabeth
and removed request for
cjcenizal
alisonelizabeth
approved these changes
Feb 25, 2021
Contributor
alisonelizabeth
left a comment
alisonelizabeth
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this!
Do you think it would be beneficial to add a test to job_create_logistics.test.js?
Contributor
Author
|
Thanks for the review @alisonelizabeth !
Great idea! 👍🏻 |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 25, 2021
* Remove use of undefined import * added component integration test for default value in frequency
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 25, 2021
* Remove use of undefined import * added component integration test for default value in frequency
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 25, 2021
…tiple-searchable-snapshot-actions * 'master' of github.com:elastic/kibana: [Rollup] Fix use of undefined value in JS import (elastic#92791) [ILM] Fix replicas not showing (elastic#92782) [Event Log] Extended README.md with the documentation for a REST API and Start plugin contract. (elastic#92562) [XY] Enables page reload toast for the legacyChartsLibrary setting (elastic#92811) [Security Solution][Case] Improve hooks (elastic#89580) [Security Solution] Update wordings and breadcrumb for timelines page (elastic#90809) [Security Solution] Replace EUI theme with mocks in jest suites (elastic#92462) docs: ✏️ use correct heading level (elastic#92806) [ILM ] Fix logic for showing/hiding recommended allocation on Cloud (elastic#90592) [Security Solution][Detections] Pull gap detection logic out in preparation for sharing between rule types (elastic#91966) [core.savedObjects] Remove _shard_doc tiebreaker since ES now adds it automatically. (elastic#92295) docs: ✏️ fix links in embeddable plugin readme (elastic#92778) # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/searchable_snapshot_field/searchable_snapshot_field.tsx
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 25, 2021
* Remove use of undefined import * added component integration test for default value in frequency
jloleysens
added a commit
that referenced
this pull request
Mar 1, 2021
* Remove use of undefined import * added component integration test for default value in frequency Co-authored-by: Kibana Machine <[email protected]>
jloleysens
added a commit
that referenced
this pull request
Mar 1, 2021
* Remove use of undefined import * added component integration test for default value in frequency Co-authored-by: Kibana Machine <[email protected]>
jloleysens
added a commit
that referenced
this pull request
Mar 1, 2021
* Remove use of undefined import * added component integration test for default value in frequency Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #90427
Remove use of
undefinedvalue. This regression was introduced in this commit 43a1ae5#diff-dfffd5cb23e11b5e014719dbeb9327ba5088abd82efaa04371e0327aefbed74cR33Release note
We fixed a bug where the initial value of rollup job frequency would default to "minute" but would actually generate a cron for weekly rollups.
CC @cjcenizal