Skip to content

Mouse out over legend should not cause errors on the console #9263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
epixa merged 1 commit into from
Nov 30, 2016
Merged

Mouse out over legend should not cause errors on the console #9263

epixa merged 1 commit into from
Nov 30, 2016

Conversation

@thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Nov 29, 2016 •
edited
Loading

closes #9241.

This is the same spot fix as for the corresponding #8877.

@epixa
Copy link
Contributor

epixa commented Nov 29, 2016

Is this happening in 5.1 or 5.0?

@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Nov 29, 2016

I can reproduce this on 5.1 and 5.x.

@epixa
Copy link
Contributor

epixa commented Nov 29, 2016

I'd say this is a blocker then

@ppisljar
Copy link
Contributor

ppisljar commented Nov 30, 2016 •
edited
Loading

shouldn't this be fixed by #8877 ?

@epixa
Copy link
Contributor

epixa commented Nov 30, 2016

@ppisljar #8877 failed to address the issue in the "unhighlight" function, which this PR addresses.

@ppisljar
Copy link
Contributor

ppisljar commented Nov 30, 2016

LGTM

@epixa epixa merged commit 1aaa381 into elastic:master Nov 30, 2016
elastic-jasper added a commit that referenced this pull request Nov 30, 2016
@elastic-jasper
Mouse out over legend should not cause errors on the console
980b884 
Backports PR #9263

**Commit 1:**
Mouse out over legend should not cause errors to the console

* Original sha: e688065
* Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-29T21:44:03Z
elastic-jasper added a commit that referenced this pull request Nov 30, 2016
@elastic-jasper
Mouse out over legend should not cause errors on the console
dbcfe49 
Backports PR #9263

**Commit 1:**
Mouse out over legend should not cause errors to the console

* Original sha: e688065
* Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-29T21:44:03Z
This was referenced Nov 30, 2016
Merged
Merged
epixa pushed a commit that referenced this pull request Nov 30, 2016
@elastic-jasper @epixa
Mouse out over legend should not cause errors on the console (#9274)
59b31e5 
Backports PR #9263

**Commit 1:**
Mouse out over legend should not cause errors to the console

* Original sha: e688065
* Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-29T21:44:03Z
epixa pushed a commit that referenced this pull request Nov 30, 2016
@elastic-jasper @epixa
Mouse out over legend should not cause errors on the console (#9275)
e1456a8 
Backports PR #9263

**Commit 1:**
Mouse out over legend should not cause errors to the console

* Original sha: e688065
* Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-29T21:44:03Z
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
@elastic-jasper @epixa
Mouse out over legend should not cause errors on the console (elastic…
00794d7 
…#9274)

Backports PR elastic#9263

**Commit 1:**
Mouse out over legend should not cause errors to the console

* Original sha: e688065
* Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-29T21:44:03Z

Former-commit-id: 59b31e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ppisljar ppisljar

Labels

backported blocker v5.1.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Area chart error

3 participants

@thomasneirynck @epixa @ppisljar