Skip to content

Toggling spy panel no longer throws an error #8877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thomasneirynck merged 2 commits into from
Oct 31, 2016
Merged

Toggling spy panel no longer throws an error #8877

thomasneirynck merged 2 commits into from
Oct 31, 2016

Conversation

@thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Oct 28, 2016 •
edited by epixa
Loading

Closes #8869.

Also tidied up some linter warnings.

ppisljar
ppisljar requested changes Oct 29, 2016
View reviewed changes
Copy link
Contributor

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i might be wrong but this seems wrong :) so in dispatch you now always overwrite handler.highlight function with dispatch.highlight .... you defined default noop functions on handler, but those will always get overwriten by dispatch.highligh

src/ui/public/vislib/lib/dispatch.js Outdated
if (!this.handler.highlight) {
this.handler.highlight = self.highlight;
}
this.handler.highlight = self.highlight;
Copy link
Contributor

@ppisljar ppisljar Oct 29, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you are always overwriting handler.highlight, even if its already defined. when area chart defines highlight function on handler it will be ignored .... (overwriten by dispatch.highlight)

Copy link
Contributor Author

@thomasneirynck thomasneirynck Oct 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks for flagging this. you're right, this is not going to work since we're also overriding in other places.

@ppisljar
Copy link
Contributor

ppisljar commented Oct 31, 2016

LGTM, as discussed this is temporary till the vislib rewrite is merged.

@thomasneirynck thomasneirynck merged commit 5a8aaa2 into elastic:master Oct 31, 2016
elastic-jasper added a commit that referenced this pull request Oct 31, 2016
@elastic-jasper
Toggling spy panel no longer throws an error
ae3ab61 
Backports PR #8877

**Commit 1:**
Toggling spy panel no longer throws an error

* Original sha: 0de553d
* Authored by Thomas Neirynck <thomas@elastic.co> on 2016-10-28T18:06:05Z

**Commit 2:**
Complete existence check before using handler

* Original sha: 6fad2be
* Authored by Thomas Neirynck <thomas@elastic.co> on 2016-10-31T14:11:40Z
This was referenced Oct 31, 2016
Merged
Closed
elastic-jasper added a commit that referenced this pull request Oct 31, 2016
@elastic-jasper
Toggling spy panel no longer throws an error
9e2efb4 
Backports PR #8877

**Commit 1:**
Toggling spy panel no longer throws an error

* Original sha: 0de553d
* Authored by Thomas Neirynck <thomas@elastic.co> on 2016-10-28T18:06:05Z

**Commit 2:**
Complete existence check before using handler

* Original sha: 6fad2be
* Authored by Thomas Neirynck <thomas@elastic.co> on 2016-10-31T14:11:40Z
thomasneirynck pushed a commit that referenced this pull request Nov 1, 2016
@elastic-jasper @thomasneirynck
Toggling spy panel no longer throws an error (#8906)
c834ee7 
Backports PR #8877

**Commit 1:**
Toggling spy panel no longer throws an error

* Original sha: 0de553d
* Authored by Thomas Neirynck <thomas@elastic.co> on 2016-10-28T18:06:05Z

**Commit 2:**
Complete existence check before using handler

* Original sha: 6fad2be
* Authored by Thomas Neirynck <thomas@elastic.co> on 2016-10-31T14:11:40Z
nreese pushed a commit to nreese/kibana that referenced this pull request Nov 10, 2016
@thomasneirynck @nreese
Toggling spy panel no longer throws an error (elastic#8877)
2bbaa70 
Complete existence check of highlight-handler, before using it
@thomasneirynck thomasneirynck mentioned this pull request Nov 29, 2016
Merged
@epixa epixa added v5.1.1 and removed v5.1.0 labels Dec 8, 2016
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
@elastic-jasper @thomasneirynck
Toggling spy panel no longer throws an error (elastic#8906)
ee2db69 
Backports PR elastic#8877

**Commit 1:**
Toggling spy panel no longer throws an error

* Original sha: 0de553d
* Authored by Thomas Neirynck <thomas@elastic.co> on 2016-10-28T18:06:05Z

**Commit 2:**
Complete existence check before using handler

* Original sha: 6fad2be
* Authored by Thomas Neirynck <thomas@elastic.co> on 2016-10-31T14:11:40Z

Former-commit-id: c834ee7
weronikaolejniczak added a commit that referenced this pull request Jul 23, 2025
@weronikaolejniczak
Upgrade EUI to v106.1.0 and ESLint plugin to v2.2.1 (#228828)
d7aca7b 
`@elastic/eui`: `106.0.0` ⏩ `106.1.0`
`@elastic/eslint-plugin-eui`: `2.1.0` ⏩ `2.2.1`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

New props and defaults have been added to `EuiFlyout`, including
`includeSelectorInFocusTrap`, plus new global CSS variables for push
mode offset control. Additionally, we introduced a small spacing fix for
invalid `EuiDualRange` append component and added support for custom
styles on `EuiTreeView` nodes via the css key.

:warning: **React 16 is now deprecated:** EUI no longer tests against it
or fixes issues specific to it.

## Changes

- I removed forced click in:
`x-pack/test/security_solution_cypress/cypress/tasks/rule_details.ts`
- I removed `{enter}` in:
`x-pack/test/security_solution_cypress/cypress/tasks/common/rule_actions.ts`
(see #228517)

## Package updates

### `@elastic/eui`

#### [`v106.1.0`](https://github.com/elastic/eui/releases/v106.1.0)

- Added `--euiPushFlyoutOffsetInlineStart` and
`--euiPushFlyoutOffsetInlineEnd` global CSS variables set by the
`EuiFlyout` in `push` mode.
([#8872](elastic/eui#8872))
- Reduced the `min-width` for inputs in `EuiRange` and `EuiDualRange`
([#8866](elastic/eui#8866))
- Added `includeSelectorInFocusTrap` prop for `EuiFlyout`
([#8849](elastic/eui#8849))
- Added component defaults for `EuiFlyout` that include
`includeSelectorInFocusTrap` and `includeFixedHeadersInFocusTrap`
([#8849](elastic/eui#8849))

**Bug fixes**

- Fixed flaky manual return focus behavior on `EuiFlyout` by relying on
`FocusTrap` returning focus instead
([#8878](elastic/eui#8878))
- Fixed `EuiFlyoutChild` closing its parent `EuiFlyout` on `Escape`
keypress ([#8878](elastic/eui#8878))
- Fixed support for `css` key in items object passed to `EuiTreeView`
([#8864](elastic/eui#8864))

**Deprecations**

- Deprecated support for React 16. Please update to a modern version of
React or stay on EUI version 106.0.0 if you can't switch right now.
([#8868](elastic/eui#8868))
  
### `@elastic/eslint-plugin-eui`

####
[`v2.2.1`](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.2.1)

**Bug fixes**

- Removed `no-css_color` entry which mapped to a duplicate
`no-css-color` rule ([#8888](elastic/eui#8888))

####
[`v2.2.0`](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.2.0)

- Added new `prefer-eui-icon-tip` rule.
([#8877](elastic/eui#8877))
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
@weronikaolejniczak @kertal
Upgrade EUI to v106.1.0 and ESLint plugin to v2.2.1 (elastic#228828)
382fc86 
`@elastic/eui`: `106.0.0` ⏩ `106.1.0`
`@elastic/eslint-plugin-eui`: `2.1.0` ⏩ `2.2.1`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

New props and defaults have been added to `EuiFlyout`, including
`includeSelectorInFocusTrap`, plus new global CSS variables for push
mode offset control. Additionally, we introduced a small spacing fix for
invalid `EuiDualRange` append component and added support for custom
styles on `EuiTreeView` nodes via the css key.

:warning: **React 16 is now deprecated:** EUI no longer tests against it
or fixes issues specific to it.

## Changes

- I removed forced click in:
`x-pack/test/security_solution_cypress/cypress/tasks/rule_details.ts`
- I removed `{enter}` in:
`x-pack/test/security_solution_cypress/cypress/tasks/common/rule_actions.ts`
(see elastic#228517)

## Package updates

### `@elastic/eui`

#### [`v106.1.0`](https://github.com/elastic/eui/releases/v106.1.0)

- Added `--euiPushFlyoutOffsetInlineStart` and
`--euiPushFlyoutOffsetInlineEnd` global CSS variables set by the
`EuiFlyout` in `push` mode.
([elastic#8872](elastic/eui#8872))
- Reduced the `min-width` for inputs in `EuiRange` and `EuiDualRange`
([elastic#8866](elastic/eui#8866))
- Added `includeSelectorInFocusTrap` prop for `EuiFlyout`
([elastic#8849](elastic/eui#8849))
- Added component defaults for `EuiFlyout` that include
`includeSelectorInFocusTrap` and `includeFixedHeadersInFocusTrap`
([elastic#8849](elastic/eui#8849))

**Bug fixes**

- Fixed flaky manual return focus behavior on `EuiFlyout` by relying on
`FocusTrap` returning focus instead
([elastic#8878](elastic/eui#8878))
- Fixed `EuiFlyoutChild` closing its parent `EuiFlyout` on `Escape`
keypress ([elastic#8878](elastic/eui#8878))
- Fixed support for `css` key in items object passed to `EuiTreeView`
([elastic#8864](elastic/eui#8864))

**Deprecations**

- Deprecated support for React 16. Please update to a modern version of
React or stay on EUI version 106.0.0 if you can't switch right now.
([elastic#8868](elastic/eui#8868))
  
### `@elastic/eslint-plugin-eui`

####
[`v2.2.1`](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.2.1)

**Bug fixes**

- Removed `no-css_color` entry which mapped to a duplicate
`no-css-color` rule ([elastic#8888](elastic/eui#8888))

####
[`v2.2.0`](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.2.0)

- Added new `prefer-eui-icon-tip` rule.
([elastic#8877](elastic/eui#8877))
eokoneyo pushed a commit to eokoneyo/kibana that referenced this pull request Jul 31, 2025
@weronikaolejniczak @eokoneyo
Upgrade EUI to v106.1.0 and ESLint plugin to v2.2.1 (elastic#228828)
a78c2fb 
`@elastic/eui`: `106.0.0` ⏩ `106.1.0`
`@elastic/eslint-plugin-eui`: `2.1.0` ⏩ `2.2.1`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

New props and defaults have been added to `EuiFlyout`, including
`includeSelectorInFocusTrap`, plus new global CSS variables for push
mode offset control. Additionally, we introduced a small spacing fix for
invalid `EuiDualRange` append component and added support for custom
styles on `EuiTreeView` nodes via the css key.

:warning: **React 16 is now deprecated:** EUI no longer tests against it
or fixes issues specific to it.

## Changes

- I removed forced click in:
`x-pack/test/security_solution_cypress/cypress/tasks/rule_details.ts`
- I removed `{enter}` in:
`x-pack/test/security_solution_cypress/cypress/tasks/common/rule_actions.ts`
(see elastic#228517)

## Package updates

### `@elastic/eui`

#### [`v106.1.0`](https://github.com/elastic/eui/releases/v106.1.0)

- Added `--euiPushFlyoutOffsetInlineStart` and
`--euiPushFlyoutOffsetInlineEnd` global CSS variables set by the
`EuiFlyout` in `push` mode.
([elastic#8872](elastic/eui#8872))
- Reduced the `min-width` for inputs in `EuiRange` and `EuiDualRange`
([elastic#8866](elastic/eui#8866))
- Added `includeSelectorInFocusTrap` prop for `EuiFlyout`
([elastic#8849](elastic/eui#8849))
- Added component defaults for `EuiFlyout` that include
`includeSelectorInFocusTrap` and `includeFixedHeadersInFocusTrap`
([elastic#8849](elastic/eui#8849))

**Bug fixes**

- Fixed flaky manual return focus behavior on `EuiFlyout` by relying on
`FocusTrap` returning focus instead
([elastic#8878](elastic/eui#8878))
- Fixed `EuiFlyoutChild` closing its parent `EuiFlyout` on `Escape`
keypress ([elastic#8878](elastic/eui#8878))
- Fixed support for `css` key in items object passed to `EuiTreeView`
([elastic#8864](elastic/eui#8864))

**Deprecations**

- Deprecated support for React 16. Please update to a modern version of
React or stay on EUI version 106.0.0 if you can't switch right now.
([elastic#8868](elastic/eui#8868))
  
### `@elastic/eslint-plugin-eui`

####
[`v2.2.1`](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.2.1)

**Bug fixes**

- Removed `no-css_color` entry which mapped to a duplicate
`no-css-color` rule ([elastic#8888](elastic/eui#8888))

####
[`v2.2.0`](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.2.0)

- Added new `prefer-eui-icon-tip` rule.
([elastic#8877](elastic/eui#8877))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbudz jbudz jbudz approved these changes

@ppisljar ppisljar ppisljar approved these changes

Assignees

@jbudz jbudz

@ppisljar ppisljar

Labels

backported review v5.1.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thomasneirynck @ppisljar @jbudz @epixa