Skip to content

Handle test failure better (5.1) #9254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thomasneirynck wants to merge 1 commit into from
Closed

Handle test failure better (5.1) #9254

thomasneirynck wants to merge 1 commit into from

Conversation

@thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Nov 29, 2016

DO NOT MERGE!

This is the same change as #9251, but targeting 5.1.

There have been intermittent failures in CI. This should give us a more meaningful error should they occur again.

@thomasneirynck thomasneirynck changed the title handle test failure better Handle test failure better (5.1) Nov 29, 2016
@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Nov 29, 2016

jenkins, test this

3 similar comments
@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Nov 29, 2016

jenkins, test this

@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Nov 29, 2016

jenkins, test this

@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Nov 29, 2016

jenkins, test this

@thomasneirynck thomasneirynck mentioned this pull request Nov 29, 2016
Closed
@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Nov 29, 2016

jenkins, test this

3 similar comments
@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Nov 30, 2016

jenkins, test this

@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Nov 30, 2016

jenkins, test this

@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Nov 30, 2016

jenkins, test this

@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Nov 30, 2016

failure: https://kibana-ci.elastic.co/job/elastic+kibana+pull-request+multijob-intake/2266/console

error is identical to failures in 5.x (#9255 (comment))

Chrome 54.0.2840 (Linux 0.0.0) tag cloud should position elements correctly: 0 FAILED
	Error: top boundary of tag should have been inside | bbox-of-tag: [1161.5,1300,1170.5,1313] vs
	     bbox-of-container: 512,512
	    at verifyBbox (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=4:350333:14)
	    at isInsideContainer (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=4:350325:6)
	    at http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=4:350319:8
	    at Array.forEach (native)
	    at verifyTagProperties (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=4:350308:21)
	    at TagCloud.onRender (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=4:350073:12)
	    at TagCloud.EventEmitter.emit (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=4:242809:18)
	    at TagCloud._processQueue (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=4:241962:15)
	    at resolveWhenDone (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=4:242050:18)
	    at SVGTextElement.<anonymous> (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=4:242065:10)
	    at SVGTextElement.event (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=4:181696:43)
	    at Object.tick [as c] (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=4:190110:55)
	    at d3_timer_mark (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=4:183352:74)
	    at d3_timer_step (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=4:183332:16)

@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Nov 30, 2016

jenkins, test this

1 similar comment
@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Nov 30, 2016

jenkins, test this

@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Nov 30, 2016

failure: https://kibana-ci.elastic.co/job/elastic+kibana+pull-request+multijob-intake/2277/console

@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Nov 30, 2016

jenkins, test this

@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Nov 30, 2016

closing, was able to reproduce error in CI. errors are identical between all branches (5.1, 5.1, master)

@thomasneirynck thomasneirynck mentioned this pull request Nov 30, 2016
Merged
weronikaolejniczak added a commit that referenced this pull request Jan 14, 2026
@weronikaolejniczak
Update EUI to 111.1.0 (#247843)
d377f8f 
## Dependency updates

- `@elastic/eui`: `v111.0.0` ⏩ `v111.1.0`
- `@elastic/eui-theme-borealis`: `v5.2.0` ⏩ `v5.3.0`

---

## Changes

- Removed `euiBasicTable.tableCaptionWithPagination`,
`euiBasicTable.tableAutoCaptionWithPagination`,
`euiBasicTable.tableSimpleAutoCaptionWithPagination`,
`euiBasicTable.tableAutoCaptionWithoutPagination` i18n tokens
- Added `euiBasicTable.caption.itemCountPart.withTotalItemCount`,
`euiBasicTable.caption.paginationPart.withPageCount`,
`euiBasicTable.caption.tableName`, `euiBasicTable.caption.emptyState`
i18n tokens
- Updated snapshot tests
- Updated a couple of Jest assertions due to [this EUI
change](https://github.com/elastic/eui/pull/9254/changes)), see
127ab80

## Package updates

### `@elastic/eui`
[v111.1.0](https://github.com/elastic/eui/releases/tag/v111.1.0)

- Added `dashedCircle` icon
([#9278](elastic/eui#9278))
- Added `crossProjectSearch` icon
([#9275](elastic/eui#9275))
- Added component token `components.tourStepIndicatorInactiveColor` and
`components.tourStepIndicatorActiveColor`
([#9271](elastic/eui#9271))
- Remapped `EuiBeacon` component `success` variant to use `success`
color token instead of `accentSecondary`
([#9271](elastic/eui#9271))
- Added `EuiSplitButton` and its respective sub-components
`EuiSplitButton.ActionPrimary` and `EuiSplitButton.ActionSecondary`
([#9269](elastic/eui#9269))
- Added `productRobot` icon
([#9259](elastic/eui#9259))
- Added beta `euiContainer()`, `euiContainerCSS()`, and
`euiContainerQuery()` Emotion utilities to help work with CSS Container
Queries ([#9264](elastic/eui#9264))
- Added `useEuiContainerQuery` hook to observe container query changes
in JavaScript ([#9251](elastic/eui#9251))
- Updated EuiFlexGroup's `gutterSize` from `l` to `m`
([#9132](elastic/eui#9132))
- Updated EuiSpacer's `size` from `l` to `m`
([#9132](elastic/eui#9132))
- Updated EuiHorizontalRule's `margin` from `l` to `m`
([#9132](elastic/eui#9132))
- Updated EuiPageHeader's tab `size` from `l` to `m`
([#9132](elastic/eui#9132))
- Updated EuiEmptyPrompt's spacer `size` between title and text from `m`
to `s` ([#9132](elastic/eui#9132))
- Updated EuiSearchBar's `gutterSize` from `m` to `s`
([#9132](elastic/eui#9132))

<img width="2158" height="392" alt="image"
src="https://github.com/user-attachments/assets/e217f5a5-5b4f-48df-830d-a60861939945"
/>
<img width="1692" height="608" alt="image"
src="https://github.com/user-attachments/assets/d1f49e86-ad8c-4d80-9d02-54c73baae616"
/>
<img width="2182" height="302" alt="image"
src="https://github.com/user-attachments/assets/295c768c-a2df-48f5-80cb-1a1ce5b19e00"
/>
<img width="1904" height="1066" alt="image"
src="https://github.com/user-attachments/assets/f96cbde6-0529-4f5b-be5b-b56f28c5d2b7"
/>
<img width="1566" height="128" alt="image"
src="https://github.com/user-attachments/assets/be4df105-9e32-4a9d-89f0-fe973f441495"
/>

**Bug fixes**

- Fixed flyout overlay masks not being visible for `EuiDataGrid`'s
fullscreen mode by reducing the `z-index` of the fullscreen mode overlay
([#9267](elastic/eui#9267))

**Accessibility**

- Added information about the empty state of `EuiBasicTable` in the
table caption ([#9265](elastic/eui#9265))
- Improved `EuiBasicTable` accessibility by ensuring a fallback
`tableCaption` is applied if none is provided
([#9254](elastic/eui#9254))

### `@elastic/eui-theme-borealis` v5.3.0

- Added component token `components.tourStepIndicatorInactiveColor` and
`components.tourStepIndicatorActiveColor`
([#9271](elastic/eui#9271))
smith pushed a commit to smith/kibana that referenced this pull request Jan 16, 2026
@weronikaolejniczak @smith
Update EUI to 111.1.0 (elastic#247843)
67087ff 
## Dependency updates

- `@elastic/eui`: `v111.0.0` ⏩ `v111.1.0`
- `@elastic/eui-theme-borealis`: `v5.2.0` ⏩ `v5.3.0`

---

## Changes

- Removed `euiBasicTable.tableCaptionWithPagination`,
`euiBasicTable.tableAutoCaptionWithPagination`,
`euiBasicTable.tableSimpleAutoCaptionWithPagination`,
`euiBasicTable.tableAutoCaptionWithoutPagination` i18n tokens
- Added `euiBasicTable.caption.itemCountPart.withTotalItemCount`,
`euiBasicTable.caption.paginationPart.withPageCount`,
`euiBasicTable.caption.tableName`, `euiBasicTable.caption.emptyState`
i18n tokens
- Updated snapshot tests
- Updated a couple of Jest assertions due to [this EUI
change](https://github.com/elastic/eui/pull/9254/changes)), see
elastic@127ab80

## Package updates

### `@elastic/eui`
[v111.1.0](https://github.com/elastic/eui/releases/tag/v111.1.0)

- Added `dashedCircle` icon
([elastic#9278](elastic/eui#9278))
- Added `crossProjectSearch` icon
([elastic#9275](elastic/eui#9275))
- Added component token `components.tourStepIndicatorInactiveColor` and
`components.tourStepIndicatorActiveColor`
([elastic#9271](elastic/eui#9271))
- Remapped `EuiBeacon` component `success` variant to use `success`
color token instead of `accentSecondary`
([elastic#9271](elastic/eui#9271))
- Added `EuiSplitButton` and its respective sub-components
`EuiSplitButton.ActionPrimary` and `EuiSplitButton.ActionSecondary`
([elastic#9269](elastic/eui#9269))
- Added `productRobot` icon
([elastic#9259](elastic/eui#9259))
- Added beta `euiContainer()`, `euiContainerCSS()`, and
`euiContainerQuery()` Emotion utilities to help work with CSS Container
Queries ([elastic#9264](elastic/eui#9264))
- Added `useEuiContainerQuery` hook to observe container query changes
in JavaScript ([elastic#9251](elastic/eui#9251))
- Updated EuiFlexGroup's `gutterSize` from `l` to `m`
([elastic#9132](elastic/eui#9132))
- Updated EuiSpacer's `size` from `l` to `m`
([elastic#9132](elastic/eui#9132))
- Updated EuiHorizontalRule's `margin` from `l` to `m`
([elastic#9132](elastic/eui#9132))
- Updated EuiPageHeader's tab `size` from `l` to `m`
([elastic#9132](elastic/eui#9132))
- Updated EuiEmptyPrompt's spacer `size` between title and text from `m`
to `s` ([elastic#9132](elastic/eui#9132))
- Updated EuiSearchBar's `gutterSize` from `m` to `s`
([elastic#9132](elastic/eui#9132))

<img width="2158" height="392" alt="image"
src="https://github.com/user-attachments/assets/e217f5a5-5b4f-48df-830d-a60861939945"
/>
<img width="1692" height="608" alt="image"
src="https://github.com/user-attachments/assets/d1f49e86-ad8c-4d80-9d02-54c73baae616"
/>
<img width="2182" height="302" alt="image"
src="https://github.com/user-attachments/assets/295c768c-a2df-48f5-80cb-1a1ce5b19e00"
/>
<img width="1904" height="1066" alt="image"
src="https://github.com/user-attachments/assets/f96cbde6-0529-4f5b-be5b-b56f28c5d2b7"
/>
<img width="1566" height="128" alt="image"
src="https://github.com/user-attachments/assets/be4df105-9e32-4a9d-89f0-fe973f441495"
/>

**Bug fixes**

- Fixed flyout overlay masks not being visible for `EuiDataGrid`'s
fullscreen mode by reducing the `z-index` of the fullscreen mode overlay
([elastic#9267](elastic/eui#9267))

**Accessibility**

- Added information about the empty state of `EuiBasicTable` in the
table caption ([elastic#9265](elastic/eui#9265))
- Improved `EuiBasicTable` accessibility by ensuring a fallback
`tableCaption` is applied if none is provided
([elastic#9254](elastic/eui#9254))

### `@elastic/eui-theme-borealis` v5.3.0

- Added component token `components.tourStepIndicatorInactiveColor` and
`components.tourStepIndicatorActiveColor`
([elastic#9271](elastic/eui#9271))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@thomasneirynck