-
Notifications
You must be signed in to change notification settings - Fork 861
New useEuiContainerQuery hook
#9251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packages/eui/src/services/container_query/container_query_hook.ts
Outdated
Show resolved
Hide resolved
weronikaolejniczak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed some nits while checking out of curiosity. This is not a full review, I'd wait for @tkajtoch because he has more context. Otherwise code looks good to me but I haven't tested. IMHO good decision on using that polyfill 💪🏻
|
I refactored the polyfill code into a plain function, added some clean up logic, and it's working nicely… (also left a couple of comments above) @tkajtoch how would you measure any possible performance impact? (there's a single call to if this is aligned with what you had in mind originally, I'm glad to wrap it up (add tests, JSDoc, etc.) — let me know what you think 🙂 |
Co-authored-by: Weronika Olejniczak <[email protected]>
Co-authored with Claude Code
cy because we need a real browser for container queries
f2c03f9 to
e8fe837
Compare
Co-authored-by: Tomasz Kajtoch <[email protected]>
tkajtoch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and work as expected. I tested the performance of the added hook and didn't find any bottlenecks. Considering this is a beta hook and it isn't used anywhere, we can optimize when necessary.
Don't forget to revert 8efe389 :D
This reverts commit 8efe389.
💚 Build SucceededHistory
cc @acstll |
💚 Build Succeeded
History
cc @acstll |
## Dependency updates - `@elastic/eui`: `v111.0.0` ⏩ `v111.1.0` - `@elastic/eui-theme-borealis`: `v5.2.0` ⏩ `v5.3.0` --- ## Changes - Removed `euiBasicTable.tableCaptionWithPagination`, `euiBasicTable.tableAutoCaptionWithPagination`, `euiBasicTable.tableSimpleAutoCaptionWithPagination`, `euiBasicTable.tableAutoCaptionWithoutPagination` i18n tokens - Added `euiBasicTable.caption.itemCountPart.withTotalItemCount`, `euiBasicTable.caption.paginationPart.withPageCount`, `euiBasicTable.caption.tableName`, `euiBasicTable.caption.emptyState` i18n tokens - Updated snapshot tests - Updated a couple of Jest assertions due to [this EUI change](https://github.com/elastic/eui/pull/9254/changes)), see 127ab80 ## Package updates ### `@elastic/eui` [v111.1.0](https://github.com/elastic/eui/releases/tag/v111.1.0) - Added `dashedCircle` icon ([#9278](elastic/eui#9278)) - Added `crossProjectSearch` icon ([#9275](elastic/eui#9275)) - Added component token `components.tourStepIndicatorInactiveColor` and `components.tourStepIndicatorActiveColor` ([#9271](elastic/eui#9271)) - Remapped `EuiBeacon` component `success` variant to use `success` color token instead of `accentSecondary` ([#9271](elastic/eui#9271)) - Added `EuiSplitButton` and its respective sub-components `EuiSplitButton.ActionPrimary` and `EuiSplitButton.ActionSecondary` ([#9269](elastic/eui#9269)) - Added `productRobot` icon ([#9259](elastic/eui#9259)) - Added beta `euiContainer()`, `euiContainerCSS()`, and `euiContainerQuery()` Emotion utilities to help work with CSS Container Queries ([#9264](elastic/eui#9264)) - Added `useEuiContainerQuery` hook to observe container query changes in JavaScript ([#9251](elastic/eui#9251)) - Updated EuiFlexGroup's `gutterSize` from `l` to `m` ([#9132](elastic/eui#9132)) - Updated EuiSpacer's `size` from `l` to `m` ([#9132](elastic/eui#9132)) - Updated EuiHorizontalRule's `margin` from `l` to `m` ([#9132](elastic/eui#9132)) - Updated EuiPageHeader's tab `size` from `l` to `m` ([#9132](elastic/eui#9132)) - Updated EuiEmptyPrompt's spacer `size` between title and text from `m` to `s` ([#9132](elastic/eui#9132)) - Updated EuiSearchBar's `gutterSize` from `m` to `s` ([#9132](elastic/eui#9132)) <img width="2158" height="392" alt="image" src="https://github.com/user-attachments/assets/e217f5a5-5b4f-48df-830d-a60861939945" /> <img width="1692" height="608" alt="image" src="https://github.com/user-attachments/assets/d1f49e86-ad8c-4d80-9d02-54c73baae616" /> <img width="2182" height="302" alt="image" src="https://github.com/user-attachments/assets/295c768c-a2df-48f5-80cb-1a1ce5b19e00" /> <img width="1904" height="1066" alt="image" src="https://github.com/user-attachments/assets/f96cbde6-0529-4f5b-be5b-b56f28c5d2b7" /> <img width="1566" height="128" alt="image" src="https://github.com/user-attachments/assets/be4df105-9e32-4a9d-89f0-fe973f441495" /> **Bug fixes** - Fixed flyout overlay masks not being visible for `EuiDataGrid`'s fullscreen mode by reducing the `z-index` of the fullscreen mode overlay ([#9267](elastic/eui#9267)) **Accessibility** - Added information about the empty state of `EuiBasicTable` in the table caption ([#9265](elastic/eui#9265)) - Improved `EuiBasicTable` accessibility by ensuring a fallback `tableCaption` is applied if none is provided ([#9254](elastic/eui#9254)) ### `@elastic/eui-theme-borealis` v5.3.0 - Added component token `components.tourStepIndicatorInactiveColor` and `components.tourStepIndicatorActiveColor` ([#9271](elastic/eui#9271))
## Dependency updates - `@elastic/eui`: `v111.0.0` ⏩ `v111.1.0` - `@elastic/eui-theme-borealis`: `v5.2.0` ⏩ `v5.3.0` --- ## Changes - Removed `euiBasicTable.tableCaptionWithPagination`, `euiBasicTable.tableAutoCaptionWithPagination`, `euiBasicTable.tableSimpleAutoCaptionWithPagination`, `euiBasicTable.tableAutoCaptionWithoutPagination` i18n tokens - Added `euiBasicTable.caption.itemCountPart.withTotalItemCount`, `euiBasicTable.caption.paginationPart.withPageCount`, `euiBasicTable.caption.tableName`, `euiBasicTable.caption.emptyState` i18n tokens - Updated snapshot tests - Updated a couple of Jest assertions due to [this EUI change](https://github.com/elastic/eui/pull/9254/changes)), see elastic@127ab80 ## Package updates ### `@elastic/eui` [v111.1.0](https://github.com/elastic/eui/releases/tag/v111.1.0) - Added `dashedCircle` icon ([elastic#9278](elastic/eui#9278)) - Added `crossProjectSearch` icon ([elastic#9275](elastic/eui#9275)) - Added component token `components.tourStepIndicatorInactiveColor` and `components.tourStepIndicatorActiveColor` ([elastic#9271](elastic/eui#9271)) - Remapped `EuiBeacon` component `success` variant to use `success` color token instead of `accentSecondary` ([elastic#9271](elastic/eui#9271)) - Added `EuiSplitButton` and its respective sub-components `EuiSplitButton.ActionPrimary` and `EuiSplitButton.ActionSecondary` ([elastic#9269](elastic/eui#9269)) - Added `productRobot` icon ([elastic#9259](elastic/eui#9259)) - Added beta `euiContainer()`, `euiContainerCSS()`, and `euiContainerQuery()` Emotion utilities to help work with CSS Container Queries ([elastic#9264](elastic/eui#9264)) - Added `useEuiContainerQuery` hook to observe container query changes in JavaScript ([elastic#9251](elastic/eui#9251)) - Updated EuiFlexGroup's `gutterSize` from `l` to `m` ([elastic#9132](elastic/eui#9132)) - Updated EuiSpacer's `size` from `l` to `m` ([elastic#9132](elastic/eui#9132)) - Updated EuiHorizontalRule's `margin` from `l` to `m` ([elastic#9132](elastic/eui#9132)) - Updated EuiPageHeader's tab `size` from `l` to `m` ([elastic#9132](elastic/eui#9132)) - Updated EuiEmptyPrompt's spacer `size` between title and text from `m` to `s` ([elastic#9132](elastic/eui#9132)) - Updated EuiSearchBar's `gutterSize` from `m` to `s` ([elastic#9132](elastic/eui#9132)) <img width="2158" height="392" alt="image" src="https://github.com/user-attachments/assets/e217f5a5-5b4f-48df-830d-a60861939945" /> <img width="1692" height="608" alt="image" src="https://github.com/user-attachments/assets/d1f49e86-ad8c-4d80-9d02-54c73baae616" /> <img width="2182" height="302" alt="image" src="https://github.com/user-attachments/assets/295c768c-a2df-48f5-80cb-1a1ce5b19e00" /> <img width="1904" height="1066" alt="image" src="https://github.com/user-attachments/assets/f96cbde6-0529-4f5b-be5b-b56f28c5d2b7" /> <img width="1566" height="128" alt="image" src="https://github.com/user-attachments/assets/be4df105-9e32-4a9d-89f0-fe973f441495" /> **Bug fixes** - Fixed flyout overlay masks not being visible for `EuiDataGrid`'s fullscreen mode by reducing the `z-index` of the fullscreen mode overlay ([elastic#9267](elastic/eui#9267)) **Accessibility** - Added information about the empty state of `EuiBasicTable` in the table caption ([elastic#9265](elastic/eui#9265)) - Improved `EuiBasicTable` accessibility by ensuring a fallback `tableCaption` is applied if none is provided ([elastic#9254](elastic/eui#9254)) ### `@elastic/eui-theme-borealis` v5.3.0 - Added component token `components.tourStepIndicatorInactiveColor` and `components.tourStepIndicatorActiveColor` ([elastic#9271](elastic/eui#9271))
Co-authored-by: Weronika Olejniczak <[email protected]> Co-authored-by: Tomasz Kajtoch <[email protected]> Authored in concert with Claude Opus 4.5 (Preview)
Summary
Closes #8963
Introduces the
useEuiContainerQueryhook that makes it possible to observe container query changes on a ref.API
useEuiContainerQuerycontainerConditionstringundefined<container-condition>string, e.g.(width > 400px)namestringundefinedsidebarWhy are we making this change?
As part of an epic to get initial container queries support in the eui library.
Impact to users
🟢 None, this is a new feature.
QA
EuiResizableContainerstory in Storybook (link) — ideally also run it locally and modify itRemarks
General checklist
@defaultif default values are missing) and playground toggles