[Uptime] Add Custom Fleet Integration UI#91584
[Uptime] Add Custom Fleet Integration UI#91584dominiqueclarke merged 127 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/uptime (Team:uptime) |
| @@ -0,0 +1,70 @@ | |||
| /* | |||
There was a problem hiding this comment.
PR is in draft state, all text will need translating.
| @@ -0,0 +1,20 @@ | |||
| /* | |||
There was a problem hiding this comment.
Create and Edit Lazy Components may need to be wrapped in some type of permissions logic.
|
@elasticmachine merge upstream |
…dominiqueclarke/kibana into feature/91062-fleet-integration
| validate: Validation; | ||
| } | ||
|
|
||
| export const CustomFields = memo<Props>( |
There was a problem hiding this comment.
This is a huge component, would have made sense to separate it into multiple for better maintenance and readability
We are validating that the header does not contain a space, but we are not doing extra validation beyond that. If the user enters a header without a key, it will omit the header in the policy. If they add a header with a value, it'll add it. |
This is resolved. |
I agree that typically the Elastic pattern is to only show validation after the field is dirty. Unfortunately, with the programatic change of the name field, the fleet field is now considered "dirty". For this reason, I wanted to match the styling with the other fields for consistency. I brought this up with Paul and Drew and I believe they were both okay with this. |
This is one of the feedback items I received, but was running out of time to address. It's certainly doable, but a bit tricky and would take just bit of time. You can find the explanation here under the Andrew section #91062 |
|
@elasticmachine merge upstream |
|
@dominiqueclarke will you be able to check why sudden increase in async bundle size? almost 400kb, some very expensive dependency got added |
shahzad31
left a comment
There was a problem hiding this comment.
LGTM, Great work again, i see nothing as blocker !!
…dominiqueclarke/kibana into feature/91062-fleet-integration
…eck.receive to input field
|
@elasticmachine merge upstream |
Register Synthetics integration package override to provide custom integration ui
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |




Summary
Fixes #91062
Running this PR
This PR can be run through "Run my Kibana PR" in the edge environment, or locally.
As of 4/12, the edge environment is down preventing running through Run my Kibana PR
Step 1: Run Kibana Locally
kibana.dev.yamlto include the following fields:yarn es snapshot -E xpack.security.authc.api_key.enabled=true --license trialyarn kbn bootstrap && yarn start --no-base-pathlocalhost:8220Step 2: add an agent locally
Step 3: Create integration
SyntheticsTesting criteria
Video: https://drive.google.com/file/d/1FTExU0AFyHeiTFuKsS6Q8txK3rJ26I0J/view?usp=drivesdk
Checklist
Delete any items that are not applicable to this PR.
For maintainers