[Uptime][Synthetics] fleet managed monitor telemetry#97502
Merged
dominiqueclarke merged 10 commits intoelastic:masterfrom May 4, 2021
Merged
[Uptime][Synthetics] fleet managed monitor telemetry#97502dominiqueclarke merged 10 commits intoelastic:masterfrom
dominiqueclarke merged 10 commits intoelastic:masterfrom
Conversation
dominiqueclarke
added
enhancement
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
pgayvallet
approved these changes
Apr 19, 2021
afharo
requested changes
Apr 19, 2021
Member
afharo
left a comment
afharo
left a comment
There was a problem hiding this comment.
@dominiqueclarke would you mind documenting the new fields. We are trying to enforce that, at least, new fields are documented. Thank you!
Comment on lines
+69
to
+75
| fleet_monitor_name_stats: { | ||
| avg_length: { type: 'float' }, | ||
| max_length: { type: 'long' }, | ||
| min_length: { type: 'long' }, | ||
| }, | ||
| fleet_monitor_frequency: { type: 'array', items: { type: 'long' } }, | ||
| fleet_no_of_unique_monitors: { type: 'long' }, |
Member
There was a problem hiding this comment.
@dominiqueclarke do you mind documenting the fields by adding the _meta.description like:
{ type: 'float', _meta: { description: 'This field represents...' } }
34ba07c to
aa01c58
Compare
dominiqueclarke
force-pushed
the
feature/91062-fleet-monitor-telemetry
branch
from
aa01c58 to
b3808ec
Compare
afharo
approved these changes
Apr 21, 2021
Member
afharo
left a comment
afharo
left a comment
There was a problem hiding this comment.
Thank you @dominiqueclarke! Telemetry changes LGTM!
shahzad31
reviewed
Apr 22, 2021
| "type": "float" | ||
| "type": "float", | ||
| "_meta": { | ||
| "description": "This field represents the average length of monitor names" |
Contributor
There was a problem hiding this comment.
Thank you so much for adding theses additional descriptions
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
shahzad31
approved these changes
Apr 27, 2021
Contributor
shahzad31
left a comment
shahzad31
left a comment
There was a problem hiding this comment.
LGTM, telemetry works !!
WFG !!
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Contributor
💔 Backport failed
To backport manually run: |
dominiqueclarke
added a commit
to dominiqueclarke/kibana
that referenced
this pull request
May 5, 2021
* add fleet monitor telemetry * add changes to telemetry json file * add functional tests * document telemetry fields Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/test/api_integration/apis/uptime/rest/helper/make_ping.ts
dominiqueclarke
added a commit
to dominiqueclarke/kibana
that referenced
this pull request
May 5, 2021
* add fleet monitor telemetry * add changes to telemetry json file * add functional tests * document telemetry fields Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/test/api_integration/apis/uptime/rest/helper/make_ping.ts
dominiqueclarke
added a commit
that referenced
this pull request
May 5, 2021
* add fleet monitor telemetry * add changes to telemetry json file * add functional tests * document telemetry fields Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/test/api_integration/apis/uptime/rest/helper/make_ping.ts
dominiqueclarke
added a commit
that referenced
this pull request
May 5, 2021
* add fleet monitor telemetry * add changes to telemetry json file * add functional tests * document telemetry fields Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/test/api_integration/apis/uptime/rest/helper/make_ping.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #97301
Summary
Adds fleet managed monitor logic to the Uptime's telemetry adapter to count unique number of fleet managed monitors. This is accomplished by filtering for the
monitor.fleet_enabled: trueterm.Step 1: Run Kibana Locally
kibana.dev.yamlto include the following fields:yarn es snapshot -E xpack.security.authc.api_key.enabled=true --license trialyarn kbn bootstrap && yarn start --no-base-pathlocalhost:8220Step 2: Create integration
SyntheticsStep 3: Check telemetry