Add a method for plugins to add injected vars to every app #9071

spalger · 2016-11-15T00:49:11Z

Several times while developing x-pack we have needed to little bits of data from the server at UI Bootstrap time. This can currently be solved by either putting a static set of variables in your injectDefaultVars() ui-export, or make a request at bootstrap and delay everything for the request to complete.

The later has become increasingly necessary, and has lead to several race-conditions as we try to expose a synchronous API for data that is loaded asynchronously (unless it's cached).

This change adds a replaceInjectedVars(originalInjectedVars, request, server) uiExport type that receives the injectedVars created by the app that is being rendered, the current request, and the hapi server object. The function should return new injectedVars (or a promise for one) to be sent to the view in this render.

@w33ble and @lukasolson worked with me on the design, so we could make sure that it made sense from a plugin authors perspective

w33ble

I think jsdom is a little heavy for the use here, but otherwise LGTM

w33ble · 2016-11-16T22:58:49Z

src/ui/__tests__/ui_exports_replace_injected_vars.js

+import KbnServer from '../../server/kbn_server';
+
+const getInjectedVarsFromResponse = (resp) => {
+  const document = jsdom.jsdom(resp.payload);


Can't you just use jquery to do the css selection and read the data from the DOM here? And if not, wouldn't something like cheerio be a lighter solution for it?

These tests are run in node, so jQuery isn't an option. cheerio looks perfect

…end-injected-vars

lukasolson · 2016-11-18T17:33:45Z

LGTM!

Backports PR #9071 **Commit 1:** [uiExports] add replaceInjectedVars() export type * Original sha: 7ad237c * Authored by spalger <[email protected]> on 2016-11-14T22:11:47Z **Commit 2:** [ui] do not assume es plugin is always there * Original sha: 5ac383d * Authored by spalger <[email protected]> on 2016-11-15T00:28:45Z **Commit 3:** [server/status] fix typo * Original sha: 3a97f69 * Authored by spalger <[email protected]> on 2016-11-15T00:29:19Z **Commit 4:** [ui] add errror handling to /app/{id} endpoint * Original sha: 33aa9de * Authored by spalger <[email protected]> on 2016-11-15T00:29:43Z **Commit 5:** [ui] add tests for replaceInjectedVars() * Original sha: 4471453 * Authored by spalger <[email protected]> on 2016-11-15T00:30:14Z **Commit 6:** Merge branch 'master' of github.com:elastic/kibana into implement/extend-injected-vars * Original sha: d316ff5 * Authored by spalger <[email protected]> on 2016-11-17T01:54:58Z **Commit 7:** [npm] swap out jsdom with cheerio * Original sha: c0e6a62 * Authored by spalger <[email protected]> on 2016-11-17T01:58:01Z **Commit 8:** [server/ui] continue extender => replacer rename * Original sha: 3d833e8 * Authored by spalger <[email protected]> on 2016-11-17T20:55:11Z

) Backports PR elastic#9071 **Commit 1:** [uiExports] add replaceInjectedVars() export type * Original sha: 7ad237c * Authored by spalger <[email protected]> on 2016-11-14T22:11:47Z **Commit 2:** [ui] do not assume es plugin is always there * Original sha: 5ac383d * Authored by spalger <[email protected]> on 2016-11-15T00:28:45Z **Commit 3:** [server/status] fix typo * Original sha: 3a97f69 * Authored by spalger <[email protected]> on 2016-11-15T00:29:19Z **Commit 4:** [ui] add errror handling to /app/{id} endpoint * Original sha: 33aa9de * Authored by spalger <[email protected]> on 2016-11-15T00:29:43Z **Commit 5:** [ui] add tests for replaceInjectedVars() * Original sha: 4471453 * Authored by spalger <[email protected]> on 2016-11-15T00:30:14Z **Commit 6:** Merge branch 'master' of github.com:elastic/kibana into implement/extend-injected-vars * Original sha: d316ff5 * Authored by spalger <[email protected]> on 2016-11-17T01:54:58Z **Commit 7:** [npm] swap out jsdom with cheerio * Original sha: c0e6a62 * Authored by spalger <[email protected]> on 2016-11-17T01:58:01Z **Commit 8:** [server/ui] continue extender => replacer rename * Original sha: 3d833e8 * Authored by spalger <[email protected]> on 2016-11-17T20:55:11Z Former-commit-id: 2b04dde

- `@elastic/eui`: `v106.6.0` ⏩ `v106.7.0` - `@elastic/eui-theme-borealis`: `v3.4.0` ⏩ `v3.5.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- ## Changes - replaced usages of `EuiButtonEmpty` in Discover `change_dataview` and `EuiFilterButton` in Dashboard `options_list_control `with the newly added `EuiFormControlButton` component to ensure cohesive form layout styling (EUI [#9006](elastic/eui#9006)) **Discover** | before | after | |---|---| | <img width="434" height="369" alt="Screenshot 2025-10-07 at 22 13 23" src="https://github.com/user-attachments/assets/488984a0-a6a1-488e-8db5-588c84be6765" /> | <img width="418" height="365" alt="Screenshot 2025-10-07 at 22 20 16" src="https://github.com/user-attachments/assets/16164d3f-0b8d-4ceb-a971-a10a6d1f5aee" /> | | <img width="432" height="371" alt="Screenshot 2025-10-07 at 22 12 39" src="https://github.com/user-attachments/assets/37fd32f5-6d15-459d-9e14-776a671b7fd6" /> | <img width="423" height="372" alt="Screenshot 2025-10-07 at 22 21 16" src="https://github.com/user-attachments/assets/846eb3f6-7d39-4c6e-9e22-42b694f9a276" /> | **Dashboard** | before | after | |---|---| | <img width="475" height="288" alt="Screenshot 2025-10-07 at 22 13 13" src="https://github.com/user-attachments/assets/4ff88734-18d7-456a-991d-ba491550a4dd" /> | <img width="432" height="292" alt="Screenshot 2025-10-07 at 17 44 25" src="https://github.com/user-attachments/assets/6e97337f-11e6-4213-a80b-5424dcb3ee38" /> | | <img width="475" height="289" alt="Screenshot 2025-10-07 at 22 12 51" src="https://github.com/user-attachments/assets/dcbd1470-8bdd-453a-8fc0-20da26bc3e27" /> | <img width="471" height="288" alt="Screenshot 2025-10-07 at 21 44 36" src="https://github.com/user-attachments/assets/7f2c5b10-44cf-4efc-a902-dd72889b3043" /> | ## Package updates ## [`v106.7.0`](https://github.com/elastic/eui/releases/v106.7.0) - Updated `EuiComboBox` to properly break long strings without spaces when `rowHeight="auto"` ([#9063](elastic/eui#9063)) - Added `data-test-subj` support to `EuiDatePicker` and `EuiDatePickerRange` for improved testability. Propagates to main component wrappers, inputs, clear buttons, calendar navigation, and popover panels. ([#9042](elastic/eui#9042)) - Added `streamsClassic` and `streamsWired` icons ([#9017](elastic/eui#9017)) - Updated icons based on feedback: `boxesVertical`, `documentation`, `error`, `export`, `filter`, `filterExclude`, `filterIgnore`, `filterInclude`, `grab`, `grabOmnidirectional`, `grabHorizontal`, `importAction`, `indexTemporary`, `link`, `list`, `magnifyWithExclamation`, `magnifyWithMinus`, `magnifyWithPlus`, `minus`, `minusInCircle`, `pencil`, `pin`, `pinFilled`, `plus`, `plusInCircle`, `question`, `search`, `sortLeft`, `sortRight`, `sortDown`, `sortUp`, `sortable`, `unlink`. ([#9026](elastic/eui#9026)) - Added new icon: `backgroundTask`. ([#9026](elastic/eui#9026)) - Marked icons for deprecation: `boxesHorizontal`, `checkInCircleFilled`, `copyClipboard`, `documentEdit`, `errorFilled`, `expandMini`, `filterInCircle`, `lettering`, `listAdd`, `minusInCircleFilled`, `newChat`, `playFilled`, `plusInCircleFilled`, `submodule`, `tableDensityNormal`, `warningFilled`. ([#9026](elastic/eui#9026)) - Added `workflowsApp` icon ([#9011](elastic/eui#9011)) - Added `EuiFormControlButton` component for usage as input-styled button within `EuiFormControlLayout` ([#9006](elastic/eui#9006)) - Updated `EuiSuperDatePicker` to use `EuiFormControlButton` when a prettified duration button is rendered ([#9006](elastic/eui#9006)) **Bug fixes** - Fixed `EuiInMemoryTable` not firing the `search.onChange` callback when `searchFormat` equals `text`. ([#9059](elastic/eui#9059)) - Fixed `columns` in `EuiDataGrid` not being rendered in the correct order as defined by `columnVisibility.visibleColumns` which resulted in unexpected updates when reordering columns ([#9030](elastic/eui#9030)) **Accessibility** - Improved color contrast of non-interactive `EuiBreadcrumbs` items in dark mode ([#9071](elastic/eui#9071)) - Make `EuiProgress` respect user's reduced motion setting by not animating when in indeterminite state. ([#9054](elastic/eui#9054)) ### `@elastic/eui-theme-borealis` ## [`v3.5.0`](https://github.com/elastic/eui/blob/main/packages/eui-theme-borealis/changelogs/CHANGELOG_2025.md#v350) - Updated color value of `textSubdued` and legacy `subduedText` in dark mode from `#8E9FBC` to `#98A8C3` ([#9071](elastic/eui#9071)) **Bug fixes** - Fixed values of `$euiFormBackground` and `$euiFormBackgroundReadOnlyColor` to match JS tokens ([#9067](elastic/eui#9067)) --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Lene Gadewoll <[email protected]>

- `@elastic/eui`: `v106.6.0` ⏩ `v106.7.0` - `@elastic/eui-theme-borealis`: `v3.4.0` ⏩ `v3.5.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- ## Changes - replaced usages of `EuiButtonEmpty` in Discover `change_dataview` and `EuiFilterButton` in Dashboard `options_list_control `with the newly added `EuiFormControlButton` component to ensure cohesive form layout styling (EUI [elastic#9006](elastic/eui#9006)) **Discover** | before | after | |---|---| | <img width="434" height="369" alt="Screenshot 2025-10-07 at 22 13 23" src="https://github.com/user-attachments/assets/488984a0-a6a1-488e-8db5-588c84be6765" /> | <img width="418" height="365" alt="Screenshot 2025-10-07 at 22 20 16" src="https://github.com/user-attachments/assets/16164d3f-0b8d-4ceb-a971-a10a6d1f5aee" /> | | <img width="432" height="371" alt="Screenshot 2025-10-07 at 22 12 39" src="https://github.com/user-attachments/assets/37fd32f5-6d15-459d-9e14-776a671b7fd6" /> | <img width="423" height="372" alt="Screenshot 2025-10-07 at 22 21 16" src="https://github.com/user-attachments/assets/846eb3f6-7d39-4c6e-9e22-42b694f9a276" /> | **Dashboard** | before | after | |---|---| | <img width="475" height="288" alt="Screenshot 2025-10-07 at 22 13 13" src="https://github.com/user-attachments/assets/4ff88734-18d7-456a-991d-ba491550a4dd" /> | <img width="432" height="292" alt="Screenshot 2025-10-07 at 17 44 25" src="https://github.com/user-attachments/assets/6e97337f-11e6-4213-a80b-5424dcb3ee38" /> | | <img width="475" height="289" alt="Screenshot 2025-10-07 at 22 12 51" src="https://github.com/user-attachments/assets/dcbd1470-8bdd-453a-8fc0-20da26bc3e27" /> | <img width="471" height="288" alt="Screenshot 2025-10-07 at 21 44 36" src="https://github.com/user-attachments/assets/7f2c5b10-44cf-4efc-a902-dd72889b3043" /> | ## Package updates ## [`v106.7.0`](https://github.com/elastic/eui/releases/v106.7.0) - Updated `EuiComboBox` to properly break long strings without spaces when `rowHeight="auto"` ([elastic#9063](elastic/eui#9063)) - Added `data-test-subj` support to `EuiDatePicker` and `EuiDatePickerRange` for improved testability. Propagates to main component wrappers, inputs, clear buttons, calendar navigation, and popover panels. ([elastic#9042](elastic/eui#9042)) - Added `streamsClassic` and `streamsWired` icons ([elastic#9017](elastic/eui#9017)) - Updated icons based on feedback: `boxesVertical`, `documentation`, `error`, `export`, `filter`, `filterExclude`, `filterIgnore`, `filterInclude`, `grab`, `grabOmnidirectional`, `grabHorizontal`, `importAction`, `indexTemporary`, `link`, `list`, `magnifyWithExclamation`, `magnifyWithMinus`, `magnifyWithPlus`, `minus`, `minusInCircle`, `pencil`, `pin`, `pinFilled`, `plus`, `plusInCircle`, `question`, `search`, `sortLeft`, `sortRight`, `sortDown`, `sortUp`, `sortable`, `unlink`. ([elastic#9026](elastic/eui#9026)) - Added new icon: `backgroundTask`. ([elastic#9026](elastic/eui#9026)) - Marked icons for deprecation: `boxesHorizontal`, `checkInCircleFilled`, `copyClipboard`, `documentEdit`, `errorFilled`, `expandMini`, `filterInCircle`, `lettering`, `listAdd`, `minusInCircleFilled`, `newChat`, `playFilled`, `plusInCircleFilled`, `submodule`, `tableDensityNormal`, `warningFilled`. ([elastic#9026](elastic/eui#9026)) - Added `workflowsApp` icon ([elastic#9011](elastic/eui#9011)) - Added `EuiFormControlButton` component for usage as input-styled button within `EuiFormControlLayout` ([elastic#9006](elastic/eui#9006)) - Updated `EuiSuperDatePicker` to use `EuiFormControlButton` when a prettified duration button is rendered ([elastic#9006](elastic/eui#9006)) **Bug fixes** - Fixed `EuiInMemoryTable` not firing the `search.onChange` callback when `searchFormat` equals `text`. ([elastic#9059](elastic/eui#9059)) - Fixed `columns` in `EuiDataGrid` not being rendered in the correct order as defined by `columnVisibility.visibleColumns` which resulted in unexpected updates when reordering columns ([elastic#9030](elastic/eui#9030)) **Accessibility** - Improved color contrast of non-interactive `EuiBreadcrumbs` items in dark mode ([elastic#9071](elastic/eui#9071)) - Make `EuiProgress` respect user's reduced motion setting by not animating when in indeterminite state. ([elastic#9054](elastic/eui#9054)) ### `@elastic/eui-theme-borealis` ## [`v3.5.0`](https://github.com/elastic/eui/blob/main/packages/eui-theme-borealis/changelogs/CHANGELOG_2025.md#v350) - Updated color value of `textSubdued` and legacy `subduedText` in dark mode from `#8E9FBC` to `#98A8C3` ([elastic#9071](elastic/eui#9071)) **Bug fixes** - Fixed values of `$euiFormBackground` and `$euiFormBackgroundReadOnlyColor` to match JS tokens ([elastic#9067](elastic/eui#9067)) --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Lene Gadewoll <[email protected]>

spalger added 5 commits November 14, 2016 16:00

[uiExports] add replaceInjectedVars() export type

7ad237c

[ui] do not assume es plugin is always there

5ac383d

[server/status] fix typo

3a97f69

[ui] add errror handling to /app/{id} endpoint

33aa9de

[ui] add tests for replaceInjectedVars()

4471453

spalger added Feature:Plugins review v5.1.0 v6.0.0 labels Nov 15, 2016

spalger assigned ycombinator, w33ble and lukasolson Nov 15, 2016

w33ble reviewed Nov 16, 2016

View reviewed changes

spalger added 3 commits November 16, 2016 18:54

Merge branch 'master' of github.com:elastic/kibana into implement/ext…

d316ff5

…end-injected-vars

[npm] swap out jsdom with cheerio

c0e6a62

[server/ui] continue extender => replacer rename

3d833e8

spalger merged commit dd46f75 into elastic:master Nov 18, 2016

elastic-jasper mentioned this pull request Nov 18, 2016

[5.x] Add a method for plugins to add injected vars to every app #9138

Merged

ppisljar added the backported label Dec 2, 2016

epixa added v5.1.1 and removed v5.1.0 labels Dec 8, 2016

spalger deleted the implement/extend-injected-vars branch August 18, 2020 17:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add a method for plugins to add injected vars to every app #9071

Add a method for plugins to add injected vars to every app #9071

Uh oh!

spalger commented Nov 15, 2016

Uh oh!

w33ble left a comment

Uh oh!

w33ble Nov 16, 2016

Uh oh!

spalger Nov 17, 2016 •

edited

Loading

Uh oh!

lukasolson commented Nov 18, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Add a method for plugins to add injected vars to every app #9071

Add a method for plugins to add injected vars to every app #9071

Uh oh!

Conversation

spalger commented Nov 15, 2016

Uh oh!

w33ble left a comment

Choose a reason for hiding this comment

Uh oh!

w33ble Nov 16, 2016

Choose a reason for hiding this comment

Uh oh!

spalger Nov 17, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lukasolson commented Nov 18, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

spalger Nov 17, 2016 •

edited

Loading