[Security Solution][Case] ServiceNow ITSM: Add category & subcategory fields by cnasikas · Pull Request #90547 · elastic/kibana

cnasikas · 2021-02-06T10:26:14Z

Summary

The PR adds two new fields for the ServiceNow ITSM connector. Specifically, category and subcategory. It also fixes a bug when changing categories and subcategories in ServiceNow SIR connector.

Create Case

ITSM.-.Create.Case.mov

Alerts & Detections

Meta: https://github.com/elastic/security-team/issues/477
Depends on: #88655

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2021-02-06T10:26:17Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

elasticmachine · 2021-02-06T10:26:17Z

Pinging @elastic/security-solution (Team: SecuritySolution)

YulNaumenko

Alerting related changes LGTM

elasticmachine · 2021-02-09T11:10:39Z

Pinging @elastic/uptime (Team:uptime)

justinkambic

LGTM

justinkambic · 2021-02-09T14:41:24Z

x-pack/plugins/uptime/public/state/api/alert_actions.ts

We'll want to update our UI to allow users to actually set these without using the API directly. I'm creating a follow-up issue.

elastic/uptime#300

@justinkambic FWIW, there is an API call (subaction) where you can get dynamically all available choices (impact, priority, severity, category, subcategory) for a specific instance. If you are interested to this please ping me on Slack!

Example: https://github.com/cnasikas/kibana/blob/itms_category/x-pack/plugins/security_solution/public/cases/components/connectors/servicenow/servicenow_itsm_case_fields.tsx

cnasikas · 2021-02-09T17:55:08Z

@elasticmachine merge upstream

x-pack/plugins/case/common/api/connectors/servicenow_itsm.ts

stephmilovic · 2021-02-10T16:44:02Z

...y_solution/public/cases/components/connectors/servicenow/servicenow_sir_case_fields.test.tsx

nit: I know the other tests here dont follow this and it passes as is without, but the correct way would be:

Suggested change

test('it should set subcategory to null when changing category', async () => {

await waitFor(() => {

const select = wrapper.find(EuiSelect).filter(`[data-test-subj="categorySelect"]`)!;

select.prop('onChange')!({

target: {

value: 'network',

},

} as React.ChangeEvent<HTMLSelectElement>);

});

wrapper.update();

expect(onChange).toHaveBeenCalledWith({

...fields,

subcategory: null,

category: 'network',

});

});

test('it should set subcategory to null when changing category', async () => {

const select = wrapper.find(EuiSelect).filter(`[data-test-subj="categorySelect"]`)!;

select.prop('onChange')!({

target: {

value: 'network',

},

} as React.ChangeEvent<HTMLSelectElement>);

wrapper.update();

await waitFor(() => {

expect(onChange).toHaveBeenCalledWith({

...fields,

subcategory: null,

category: 'network',

});

});

});

the await waitFor should be surrounding the expect after the async change. it definitely does not always work this way, but alas we're using enzyme with react-testing-library

stephmilovic · 2021-02-10T17:01:21Z

..._ui/public/application/components/builtin_action_types/servicenow/servicenow_itsm_params.tsx

I'd do a useCallback here since you have the incident value

There is no difference if we use the incident or not. The callback function will always be a new reference for the prop no matter what we do inside the function.

stephmilovic

Manual testing went perfectly. Just a few nits on the code, other than that LGTM. very clean, nicely done! 🎸

kibanamachine · 2021-02-11T10:39:12Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 81cfa31

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2180	2181	+1
`triggersActionsUi`	337	338	+1
total			+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	7.5MB	7.5MB	+3.8KB
`triggersActionsUi`	1.4MB	1.4MB	+3.4KB
`uptime`	909.2KB	909.2KB	+31.0B
total			+7.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolution`	234.0KB	234.1KB	+105.0B

History

💚 Build #105562 succeeded 0a794b6dba0dbf37bbbf734fd826fed90cfa8941
💔 Build #105515 failed b745780e6abfef0885540254a787660ee5fa7656
💔 Build #105487 failed 8962df3b8e01cfb8e7843a114d2272c70d36675f
💔 Build #105382 failed ba6e698b13c892d17778c133f9d90ec75a237f42
💔 Build #105285 failed 8a9690dd0f9d56c18e64b8597ead8169f339b0dc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…tegory fields (#90547) (#91109)

cnasikas added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Feb 6, 2021

cnasikas requested review from a team as code owners February 6, 2021 10:26

cnasikas self-assigned this Feb 6, 2021

cnasikas force-pushed the itms_category branch from 487df89 to d6bfcef Compare February 6, 2021 10:30

YulNaumenko approved these changes Feb 8, 2021

View reviewed changes

cnasikas force-pushed the itms_category branch from d6bfcef to ce779a1 Compare February 9, 2021 10:34

cnasikas requested review from a team as code owners February 9, 2021 10:34

cnasikas force-pushed the itms_category branch from ce779a1 to d709227 Compare February 9, 2021 11:10

cnasikas requested a review from a team as a code owner February 9, 2021 11:10

botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Feb 9, 2021

cnasikas force-pushed the itms_category branch 2 times, most recently from 1cea661 to 663aa0f Compare February 9, 2021 12:25

justinkambic mentioned this pull request Feb 9, 2021

Handle additional ServiceNow fields in UI elastic/uptime#300

Open

justinkambic approved these changes Feb 9, 2021

View reviewed changes

cnasikas force-pushed the itms_category branch from 663aa0f to 0b8436e Compare February 9, 2021 16:02

cnasikas force-pushed the itms_category branch 4 times, most recently from c8fe36a to b745780 Compare February 10, 2021 09:48

cnasikas force-pushed the itms_category branch from b745780 to 0a794b6 Compare February 10, 2021 13:12

stephmilovic reviewed Feb 10, 2021

View reviewed changes

x-pack/plugins/case/common/api/connectors/servicenow_itsm.ts Outdated Show resolved Hide resolved

stephmilovic reviewed Feb 10, 2021

View reviewed changes

stephmilovic approved these changes Feb 10, 2021

View reviewed changes

ITSM: Add category & subcategory fields

81cfa31

cnasikas force-pushed the itms_category branch from 0a794b6 to 81cfa31 Compare February 11, 2021 08:29

cnasikas merged commit a9f2c91 into elastic:master Feb 11, 2021

cnasikas deleted the itms_category branch February 11, 2021 11:08

cnasikas mentioned this pull request Feb 11, 2021

[7.x] [Security Solution][Case] ServiceNow ITSM: Add category & subcategory fields (#90547) #91109

Merged

cnasikas added a commit that referenced this pull request Feb 11, 2021

[7.x] [Security Solution][Case] ServiceNow ITSM: Add category & subca…

4487ed6

…tegory fields (#90547) (#91109)

This was referenced Mar 1, 2021

[Security Solution][Case] Migrate category & subcategory fields of ServiceNow ITSM connector #93092

Merged

[Security Solution] [Threat Hunting] [Cases] Allow User to Specify ServiceNow Incident Category/Sub Category #75622

Closed

XavierM mentioned this pull request Mar 17, 2021

[SECURITY SOLUTIONS][Alerts Actions] Fix migration from 7.11.0/7.11.1 to 7.12 #94722

Merged

1 task

-    test('it should set subcategory to null when changing category', async () => {
-      await waitFor(() => {
-        const select = wrapper.find(EuiSelect).filter(`[data-test-subj="categorySelect"]`)!;
-        select.prop('onChange')!({
-          target: {
-            value: 'network',
-          },
-        } as React.ChangeEvent<HTMLSelectElement>);
-      });
-      wrapper.update();
-      expect(onChange).toHaveBeenCalledWith({
-        ...fields,
-        subcategory: null,
-        category: 'network',
-      });
-    });
+    test('it should set subcategory to null when changing category', async () => {
+      const select = wrapper.find(EuiSelect).filter(`[data-test-subj="categorySelect"]`)!;
+      select.prop('onChange')!({
+        target: {
+          value: 'network',
+        },
+      } as React.ChangeEvent<HTMLSelectElement>);
+      wrapper.update();
+      await waitFor(() => {
+        expect(onChange).toHaveBeenCalledWith({
+          ...fields,
+          subcategory: null,
+          category: 'network',
+        });
+      });
+    });

Conversation

cnasikas commented Feb 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Feb 6, 2021

Uh oh!

elasticmachine commented Feb 6, 2021

Uh oh!

YulNaumenko left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Feb 9, 2021

Uh oh!

justinkambic left a comment

Choose a reason for hiding this comment

Uh oh!

justinkambic Feb 9, 2021

Choose a reason for hiding this comment

Uh oh!

cnasikas Feb 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cnasikas commented Feb 9, 2021

Uh oh!

Uh oh!

stephmilovic Feb 10, 2021

Choose a reason for hiding this comment

Uh oh!

stephmilovic Feb 10, 2021

Choose a reason for hiding this comment

Uh oh!

stephmilovic Feb 10, 2021

Choose a reason for hiding this comment

Uh oh!

cnasikas Feb 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stephmilovic left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Feb 11, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

cnasikas commented Feb 6, 2021 •

edited

Loading

cnasikas Feb 9, 2021 •

edited

Loading

cnasikas Feb 11, 2021 •

edited

Loading