[Vega] Use mapbox instead of leaflet #88605

VladLasitsa · 2021-01-18T15:11:02Z

Summary

The task was to get rid of the use of mapLegacy (since it will be removed soon) and migrate to the MapBox.
As part of this task the following was done:

Added MapBox and used it as a map for Vega. Created a new view (https://github.com/elastic/kibana/pull/88605/files#diff-007ffb62742258bc950468291bcbab7055d8b598fba324cc285c3f3b5925ef50) for this instead previous one vega_map_view.js
Created a custom Vega layer for MapBox by analogy as in Leaflet and tested it.(https://github.com/elastic/kibana/pull/88605/files#diff-91c9c1f0c2762706554bd15bb6457d7912e98b1240b3147884ffe14a9bdb3904).
Added MapServiceSettings for getting needed tms service instead of using mapLegacy services. (https://github.com/elastic/kibana/pull/88605/files#diff-597f7f1d850fb0e98ce3fab72bf3fcbdf3dc3a8ec8d258b23d177eb7c21ee60b)
Moved validation of zoom values from view in validataion_helper (https://github.com/elastic/kibana/pull/88605/files#diff-f82ce0679453cb41a4f663254cf02b78ad2986ce066a1b360e88fc92b9b11384)
Added unit and visual regression tests.

Release notes

Leaflet (https://leafletjs.com/) map layer in Vega visualization was replaced to MapBox (https://www.mapbox.com/)

Testing notes

To enable map layer, you should specify type=map in the spec configuration.
If you would like also see Vega layer on the map you can open any vega-map visualization from sample data. For example [Flights] Airport Connections (Hover Over Airport) which you can find if add Sample flight data.

Screens

Before:

After:

For maintainers

This was checked for breaking API changes and was labeled appropriately

alexwizp · 2021-01-20T12:24:12Z

@elasticmachine merge upstream

add MapServiceSettings class some work add tms_raster_layer add LayerParameters type clenup view.ts some cleeanup fix grammar some refactoring and add attribution control Some refactoring Add some validation for zoom settings and destroy handler Some refactoring some work fix bundle size Move getZoomSettings to the separate file update licence some work move logger to createViewConfig add throttling for updating vega layer

alexwizp · 2021-01-21T16:48:48Z

@elasticmachine merge upstream

…ser open map layer

alexwizp · 2021-01-22T13:43:18Z

@elasticmachine merge upstream

thomasneirynck

nothing really jumping out for me. Works as expected.

Some minor comments for cleanup.

src/plugins/vis_type_vega/public/vega_view/vega_map_view/view.ts

elasticmachine · 2021-01-27T20:17:08Z

Pinging @elastic/kibana-app (Team:KibanaApp)

ryankeairns

Approving the SCSS change.
I will defer to @miukimiu for the UX review, if needed.

thomasneirynck

lgtm!

thanks a lot @VladLasitsa

This was an important PR for the Maps-team. It will enable us to:

continue to work on the removal of region/coordinate maps
- to remove leaflet from the Kibana codebase
- to remove dependency on the raster-image service of EMS
support on-prem deployments of EMS for Vega-maps users

💯

alexwizp · 2021-01-28T21:31:19Z

@elasticmachine merge upstream

src/plugins/vis_type_vega/public/vega_view/vega_map_view/utils/validataion_helper.ts

stratoula · 2021-01-29T10:28:35Z

@elasticmachine merge upstream

stratoula · 2021-01-29T10:38:32Z

Also @VladLasitsa we merged the ts references for vega and it seems that it fails. Can you fix it? cc @alexwizp

stratoula

LGTM, tested locally in chrome, everything seems fine 🙂

kibanamachine · 2021-01-29T13:36:06Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 3c97d8a

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`visTypeVega`	93	173	+80

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`visTypeVega`	1.5MB	2.5MB	⚠️ +989.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`visTypeVega`	53.6KB	57.4KB	+3.8KB

Unknown metric groups

async chunk count

id	before	after	diff
`visTypeVega`	7	8	+1

History

💔 Build #102084 failed 6dad8b7
💚 Build #101964 succeeded daca709
💚 Build #101714 succeeded 9f6e8e2
💔 Build #101703 failed 5b8e62f
💚 Build #101205 succeeded 9e1e3d5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* [WIP][Vega] Use mapbox instead of leaflet elastic#78395 add MapServiceSettings class some work add tms_raster_layer add LayerParameters type clenup view.ts some cleeanup fix grammar some refactoring and add attribution control Some refactoring Add some validation for zoom settings and destroy handler Some refactoring some work fix bundle size Move getZoomSettings to the separate file update licence some work move logger to createViewConfig add throttling for updating vega layer * move EMSClient to a separate bundle * [unit testing] add tests for validation_helper.ts * [Bundle optimization] lazy loading of '@elastic/ems-client' only if user open map layer * [Map] fix cursor: crosshair -> auto * [unit testing] add tests for tms_raster_layer.test * [unit testing] add tests for vega_layer.ts * VSI related code was moved into a separate file / unit tests were added * Add functional test for vega map * [unit testing] add tests for map_service_setting.ts * Add unload in function test and delete some unneeded code from test * road_map -> road_map_desaturated * [unit testing] add more tests for map_service_settings.test.ts * Add unit tests for view.ts * Fix some remarks * Fix unit tests * remove tms_tile_layers enum * [unit testing] fix map_service_settings.test.ts * Fix unit test for view.ts * Fix some comments * Fix type check * Fix CI Co-authored-by: Alexey Antonov <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

* [WIP][Vega] Use mapbox instead of leaflet #78395 add MapServiceSettings class some work add tms_raster_layer add LayerParameters type clenup view.ts some cleeanup fix grammar some refactoring and add attribution control Some refactoring Add some validation for zoom settings and destroy handler Some refactoring some work fix bundle size Move getZoomSettings to the separate file update licence some work move logger to createViewConfig add throttling for updating vega layer * move EMSClient to a separate bundle * [unit testing] add tests for validation_helper.ts * [Bundle optimization] lazy loading of '@elastic/ems-client' only if user open map layer * [Map] fix cursor: crosshair -> auto * [unit testing] add tests for tms_raster_layer.test * [unit testing] add tests for vega_layer.ts * VSI related code was moved into a separate file / unit tests were added * Add functional test for vega map * [unit testing] add tests for map_service_setting.ts * Add unload in function test and delete some unneeded code from test * road_map -> road_map_desaturated * [unit testing] add more tests for map_service_settings.test.ts * Add unit tests for view.ts * Fix some remarks * Fix unit tests * remove tms_tile_layers enum * [unit testing] fix map_service_settings.test.ts * Fix unit test for view.ts * Fix some comments * Fix type check * Fix CI Co-authored-by: Alexey Antonov <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Alexey Antonov <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

VladLasitsa requested a review from alexwizp January 18, 2021 15:11

thomasneirynck self-requested a review January 19, 2021 20:21

alexwizp mentioned this pull request Jan 20, 2021

[Vega] user should be able to set a specific tilemap service using the mapStyle property #88440

Merged

alexwizp force-pushed the mapbox_vega branch from 0739d2f to 387cc6e Compare January 20, 2021 12:49

elastic deleted a comment from kibanamachine Jan 20, 2021

alexwizp assigned VladLasitsa and alexwizp Jan 20, 2021

alexwizp force-pushed the mapbox_vega branch 2 times, most recently from 2f8f04b to f1e02e0 Compare January 21, 2021 10:57

elastic deleted a comment from kibanamachine Jan 21, 2021

alexwizp added 2 commits January 21, 2021 18:01

move EMSClient to a separate bundle

c693d60

alexwizp force-pushed the mapbox_vega branch from 54fc7b3 to c693d60 Compare January 21, 2021 15:01

Merge branch 'master' into mapbox_vega

64aafd5

alexwizp changed the title ~~Mapbox vega~~ [Vega] Use mapbox instead of leaflet Jan 22, 2021

alexwizp added 6 commits January 22, 2021 13:16

[unit testing] add tests for validation_helper.ts

4bcdcc9

[Bundle optimization] lazy loading of '@elastic/ems-client' only if u…

0e64d1c

…ser open map layer

[Map] fix cursor: crosshair -> auto

1e67cb4

[unit testing] add tests for tms_raster_layer.test

240728f

[unit testing] add tests for vega_layer.ts

216f130

VSI related code was moved into a separate file / unit tests were added

df82eb1

alexwizp force-pushed the mapbox_vega branch from 9438c9d to df82eb1 Compare January 22, 2021 13:41

kibanamachine and others added 4 commits January 22, 2021 08:43

Merge branch 'master' into mapbox_vega

fe38c90

Add functional test for vega map

665c207

[unit testing] add tests for map_service_setting.ts

aa3b241

Add unload in function test and delete some unneeded code from test

4fe48d8

alexwizp requested a review from nreese January 25, 2021 10:28

VladLasitsa added Feature:Vega Vega visualizations release_note:enhancement labels Jan 27, 2021

thomasneirynck reviewed Jan 27, 2021

View reviewed changes

alexwizp approved these changes Jan 27, 2021

View reviewed changes

alexwizp marked this pull request as ready for review January 27, 2021 20:17

alexwizp requested a review from a team January 27, 2021 20:17

alexwizp requested a review from a team as a code owner January 27, 2021 20:17

VladLasitsa added 2 commits January 28, 2021 12:31

Fix some comments

5b8e62f

Fix type check

9f6e8e2

ryankeairns approved these changes Jan 28, 2021

View reviewed changes

thomasneirynck approved these changes Jan 28, 2021

View reviewed changes

Merge branch 'master' into mapbox_vega

daca709

stratoula reviewed Jan 29, 2021

View reviewed changes

src/plugins/vis_type_vega/public/vega_view/vega_map_view/utils/validataion_helper.ts Show resolved Hide resolved

Merge branch 'master' into mapbox_vega

6dad8b7

Fix CI

3c97d8a

stratoula approved these changes Jan 29, 2021

View reviewed changes

VladLasitsa merged commit e8e8f78 into elastic:master Jan 29, 2021

VladLasitsa mentioned this pull request Jan 29, 2021

[7.x] [Vega] Use mapbox instead of leaflet (#88605) #89718

Merged

kindsun mentioned this pull request Feb 8, 2021

[Maps] Add vega layer to Maps app #82285

Closed

kindsun mentioned this pull request Mar 9, 2021

[Maps] Integrate "vega maps" functionality as a layer in the Maps app #94234

Closed

alexwizp mentioned this pull request Apr 15, 2021

Vega Time Scrolling #95933

Closed

nickpeihl mentioned this pull request Sep 21, 2021

[Vega] Maps limited to max zoom 10 in all distributions/licenses #112764

Closed

nreese mentioned this pull request Apr 18, 2022

[maps][vega] Unable to use topojson EMS boundary layers #130461

Closed

[Vega] Use mapbox instead of leaflet #88605

[Vega] Use mapbox instead of leaflet #88605

Uh oh!

Conversation

VladLasitsa commented Jan 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Release notes

Testing notes

Screens

For maintainers

Uh oh!

alexwizp commented Jan 20, 2021

Uh oh!

alexwizp commented Jan 21, 2021

Uh oh!

alexwizp commented Jan 22, 2021

Uh oh!

thomasneirynck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Jan 27, 2021

Uh oh!

ryankeairns left a comment

Choose a reason for hiding this comment

Uh oh!

thomasneirynck left a comment

Choose a reason for hiding this comment

Uh oh!

alexwizp commented Jan 28, 2021

Uh oh!

Uh oh!

stratoula commented Jan 29, 2021

Uh oh!

stratoula commented Jan 29, 2021

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jan 29, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

async chunk count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

VladLasitsa commented Jan 18, 2021 •

edited

Loading