Skip to content

[Time to Visualize] Align Save to Library Copy#88481

Merged
ThomThomson merged 1 commit intoelastic:masterfrom
ThomThomson:fix/saveToLibraryCopy
Jan 15, 2021
Merged

[Time to Visualize] Align Save to Library Copy#88481
ThomThomson merged 1 commit intoelastic:masterfrom
ThomThomson:fix/saveToLibraryCopy

Conversation

@ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Jan 15, 2021

Summary

Fixes #81366
Closes #81342

Fixes a tiny misalignment in copy...

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ThomThomson ThomThomson added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// release_note:skip Skip the PR/issue when compiling release notes Project:TimeToVisualize v7.12.0 8.0.0 labels Jan 15, 2021
@ThomThomson ThomThomson requested a review from a team as a code owner January 15, 2021 15:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson added the Feature:Dashboard Dashboard related features label Jan 15, 2021
Copy link
Contributor

@cqliu1 cqliu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, LGTM 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 333.8KB 333.8KB +1.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit 7845e61 into elastic:master Jan 15, 2021
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Jan 15, 2021
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 18, 2021
* master: (33 commits)
  [Security Solution][Case] Fix patch cases integration test with alerts (elastic#88311)
  [Security Solutions][Detection Engine] Removes duplicate API calls (elastic#88420)
  Fix log msg (elastic#88370)
  [Test] Add tag cloud visualization to dashboard in functional test for reporting (elastic#87600)
  removing kibana-core-ui from codeowners (elastic#88111)
  [Alerting] Migrate Event Log plugin to TS project references (elastic#81557)
  [Maps] fix zooming while drawing shape filter logs errors in console (elastic#88413)
  Porting fixes 1 (elastic#88477)
  [APM] Explicitly set environment for cross-service links (elastic#87481)
  chore(NA): remove mocha junit ci integrations (elastic#88129)
  [APM] Only display relevant sections for rum agent in service overview (elastic#88410)
  [Enterprise Search] Automatically mock shared logic files (elastic#88494)
  [APM] Disable Create custom link button on Transaction details page for read-only users
  [Docs] clean-up vega map reference documenation (elastic#88487)
  [Security Solution] Fix Timeline event details layout (elastic#88377)
  Change DELETE to POST for _bulk_delete to avoid incompatibility issues (elastic#87914)
  [Monitoring] Change cloud messaging on no data page (elastic#88375)
  [Uptime] clear ping state when PingList component in unmounted (elastic#88321)
  [APM] Consistent terminology for latency and throughput (elastic#88452)
  fix copy (elastic#88481)
  ...
ThomThomson added a commit that referenced this pull request Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Dashboard Dashboard related features Project:TimeToVisualize release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v7.12.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Time to Visualize] Standardize Unlink / Add Microcopy [Time to Visualize] [Meta] Rough Edges

4 participants