Skip to content

[Alerting] Migrate Event Log plugin to TS project references#81557

Merged
YulNaumenko merged 11 commits intoelastic:masterfrom
YulNaumenko:event-log-migrate-to-ts-config
Jan 16, 2021
Merged

[Alerting] Migrate Event Log plugin to TS project references#81557
YulNaumenko merged 11 commits intoelastic:masterfrom
YulNaumenko:event-log-migrate-to-ts-config

Conversation

@YulNaumenko
Copy link
Contributor

Resolve one required from Plugins to migrate:

  • event_log

Added tsconfig.json file to event_log plugin folder with the proper configuration optimization options, which described in the documentation. This changes should improve build times and enforce logical separation between components.

Blocker:

  • migrate to TS project home plugin

@YulNaumenko YulNaumenko added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.11.0 Feature:EventLog labels Oct 23, 2020
@YulNaumenko YulNaumenko requested a review from a team as a code owner October 23, 2020 04:31
@YulNaumenko YulNaumenko self-assigned this Oct 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@mikecote mikecote added v7.12.0 and removed v7.11.0 labels Dec 16, 2020
Copy link
Contributor

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the build results seem to indicate we need to do a bit more tweaking, like including the mapping.json file in the include property (I think). The package.json error reference is to get access to the current stack version - there is probably a better way to do this now (wasn't at the time this was written), so that will probably need a code change. That reference is here:

import xPackage from '../../../../package.json';

@YulNaumenko
Copy link
Contributor Author

LGTM, but the build results seem to indicate we need to do a bit more tweaking, like including the mapping.json file in the include property (I think). The package.json error reference is to get access to the current stack version - there is probably a better way to do this now (wasn't at the time this was written), so that will probably need a code change. That reference is here:

import xPackage from '../../../../package.json';

Thanks @pmuellr , yeah we need to change the approach for get access to the current stack version to make it works.

@YulNaumenko YulNaumenko requested a review from pmuellr January 15, 2021 21:29
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@YulNaumenko YulNaumenko merged commit 5c112b8 into elastic:master Jan 16, 2021
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Jan 16, 2021
…#81557)

* [Alerting] Migrate Event Log plugin to TS project references

* fixed faling typechecks

* fixed path to spaces plugin ts file

* fixed missing include

* added fix for mapping.json

* replaced package.json get version with kibanaVersion from plugin initial context

* fixed build

* fixed typechecks

* fixed tests
YulNaumenko added a commit that referenced this pull request Jan 16, 2021
…#88555)

* [Alerting] Migrate Event Log plugin to TS project references

* fixed faling typechecks

* fixed path to spaces plugin ts file

* fixed missing include

* added fix for mapping.json

* replaced package.json get version with kibanaVersion from plugin initial context

* fixed build

* fixed typechecks

* fixed tests
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 18, 2021
* master: (33 commits)
  [Security Solution][Case] Fix patch cases integration test with alerts (elastic#88311)
  [Security Solutions][Detection Engine] Removes duplicate API calls (elastic#88420)
  Fix log msg (elastic#88370)
  [Test] Add tag cloud visualization to dashboard in functional test for reporting (elastic#87600)
  removing kibana-core-ui from codeowners (elastic#88111)
  [Alerting] Migrate Event Log plugin to TS project references (elastic#81557)
  [Maps] fix zooming while drawing shape filter logs errors in console (elastic#88413)
  Porting fixes 1 (elastic#88477)
  [APM] Explicitly set environment for cross-service links (elastic#87481)
  chore(NA): remove mocha junit ci integrations (elastic#88129)
  [APM] Only display relevant sections for rum agent in service overview (elastic#88410)
  [Enterprise Search] Automatically mock shared logic files (elastic#88494)
  [APM] Disable Create custom link button on Transaction details page for read-only users
  [Docs] clean-up vega map reference documenation (elastic#88487)
  [Security Solution] Fix Timeline event details layout (elastic#88377)
  Change DELETE to POST for _bulk_delete to avoid incompatibility issues (elastic#87914)
  [Monitoring] Change cloud messaging on no data page (elastic#88375)
  [Uptime] clear ping state when PingList component in unmounted (elastic#88321)
  [APM] Consistent terminology for latency and throughput (elastic#88452)
  fix copy (elastic#88481)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:EventLog release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.12.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate Alerting plugins (including Task Manager and Event Log) to TS project references

5 participants