[Alerting] Migrate Event Log plugin to TS project references#81557
[Alerting] Migrate Event Log plugin to TS project references#81557YulNaumenko merged 11 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
pmuellr
left a comment
There was a problem hiding this comment.
LGTM, but the build results seem to indicate we need to do a bit more tweaking, like including the mapping.json file in the include property (I think). The package.json error reference is to get access to the current stack version - there is probably a better way to do this now (wasn't at the time this was written), so that will probably need a code change. That reference is here:
Thanks @pmuellr , yeah we need to change the approach for get access to the current stack version to make it works. |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
…#81557) * [Alerting] Migrate Event Log plugin to TS project references * fixed faling typechecks * fixed path to spaces plugin ts file * fixed missing include * added fix for mapping.json * replaced package.json get version with kibanaVersion from plugin initial context * fixed build * fixed typechecks * fixed tests
…#88555) * [Alerting] Migrate Event Log plugin to TS project references * fixed faling typechecks * fixed path to spaces plugin ts file * fixed missing include * added fix for mapping.json * replaced package.json get version with kibanaVersion from plugin initial context * fixed build * fixed typechecks * fixed tests
* master: (33 commits) [Security Solution][Case] Fix patch cases integration test with alerts (elastic#88311) [Security Solutions][Detection Engine] Removes duplicate API calls (elastic#88420) Fix log msg (elastic#88370) [Test] Add tag cloud visualization to dashboard in functional test for reporting (elastic#87600) removing kibana-core-ui from codeowners (elastic#88111) [Alerting] Migrate Event Log plugin to TS project references (elastic#81557) [Maps] fix zooming while drawing shape filter logs errors in console (elastic#88413) Porting fixes 1 (elastic#88477) [APM] Explicitly set environment for cross-service links (elastic#87481) chore(NA): remove mocha junit ci integrations (elastic#88129) [APM] Only display relevant sections for rum agent in service overview (elastic#88410) [Enterprise Search] Automatically mock shared logic files (elastic#88494) [APM] Disable Create custom link button on Transaction details page for read-only users [Docs] clean-up vega map reference documenation (elastic#88487) [Security Solution] Fix Timeline event details layout (elastic#88377) Change DELETE to POST for _bulk_delete to avoid incompatibility issues (elastic#87914) [Monitoring] Change cloud messaging on no data page (elastic#88375) [Uptime] clear ping state when PingList component in unmounted (elastic#88321) [APM] Consistent terminology for latency and throughput (elastic#88452) fix copy (elastic#88481) ...
Resolve one required from Plugins to migrate:
Added
tsconfig.jsonfile to event_log plugin folder with the proper configuration optimization options, which described in the documentation. This changes should improve build times and enforce logical separation between components.Blocker: