[Fleet] Fix broken maps icon key#88093
Merged
jfsiii merged 1 commit intoelastic:masterfrom Jan 14, 2021
jfsiii:use-correct-ems-icon
Merged
[Fleet] Fix broken maps icon key#88093jfsiii merged 1 commit intoelastic:masterfrom jfsiii:use-correct-ems-icon
jfsiii merged 1 commit intoelastic:masterfrom
jfsiii:use-correct-ems-icon
Conversation
botelastic
bot
added
the
Team:Fleet
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
nchaulet
added
the
release_note:skip
jen-huang
approved these changes
Jan 12, 2021
Contributor
jen-huang
left a comment
jen-huang
left a comment
There was a problem hiding this comment.
Is this an issue in 7.11 too? If so, I'd consider this safe to backport to 7.11 too. Thanks for fixing!
Contributor
Author
|
@jen-huang I believe so, but I haven't confirmed. That's what I was thinking pinging @mostlyjason (and now @ph ) |
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
Contributor
|
I'd trust the eng team's judgement on the safety of this change |
jfsiii
added
the
bug
Contributor
Author
|
@mostlyjason Seems quite safe to me. The icon this PR references has been in EUI for a few years, so it should work for everyone I'll backport since it's a low-risk to add and rolling it back is also low effort/complexity. |
This was referenced Jan 14, 2021
jfsiii
pushed a commit
that referenced
this pull request
Jan 14, 2021
## PR Summary Show [`emsApp` icon from EUI](https://eui.elastic.co/#/display/icons#apps) if integration includes map assets. <img width="229" alt="Screen Shot 2021-01-12 at 3 14 14 PM" src="https://user-images.githubusercontent.com/57655/104367878-65628280-54e9-11eb-8d9c-fa838e2c15ae.png"> Looking at #62059 (comment), I believe it landed with the incorrect key at a time when that part of the page wasn't visible. When we enabled that section, we likely didn't notice the missing key since most integrations don't have Maps assets ## Bug: `master` doesn't have an icon for Map assets 1. Visit an integration with map assets, like AWS http://localhost:5601/app/fleet#/integrations/detail/aws-0.3.16 2. Observe missing icon for Map in right column summary & HTTP request for `/app/mapApp` <img width="1013" alt="Screen Shot 2021-01-12 at 3 10 44 PM" src="https://user-images.githubusercontent.com/57655/104367875-64c9ec00-54e9-11eb-81d8-982bec862f5f.png"> ## This PR adds one 1. Visit an integration with map assets, like AWS http://localhost:5601/app/fleet#/integrations/detail/aws-0.3.16 2. Observe EMS icon is present in right column summary <img width="1087" alt="Screen Shot 2021-01-12 at 3 11 39 PM" src="https://user-images.githubusercontent.com/57655/104367877-65628280-54e9-11eb-91da-578fec6ff769.png">
jfsiii
pushed a commit
that referenced
this pull request
Jan 14, 2021
## PR Summary Show [`emsApp` icon from EUI](https://eui.elastic.co/#/display/icons#apps) if integration includes map assets. <img width="229" alt="Screen Shot 2021-01-12 at 3 14 14 PM" src="https://user-images.githubusercontent.com/57655/104367878-65628280-54e9-11eb-8d9c-fa838e2c15ae.png"> Looking at #62059 (comment), I believe it landed with the incorrect key at a time when that part of the page wasn't visible. When we enabled that section, we likely didn't notice the missing key since most integrations don't have Maps assets ## Bug: `master` doesn't have an icon for Map assets 1. Visit an integration with map assets, like AWS http://localhost:5601/app/fleet#/integrations/detail/aws-0.3.16 2. Observe missing icon for Map in right column summary & HTTP request for `/app/mapApp` <img width="1013" alt="Screen Shot 2021-01-12 at 3 10 44 PM" src="https://user-images.githubusercontent.com/57655/104367875-64c9ec00-54e9-11eb-81d8-982bec862f5f.png"> ## This PR adds one 1. Visit an integration with map assets, like AWS http://localhost:5601/app/fleet#/integrations/detail/aws-0.3.16 2. Observe EMS icon is present in right column summary <img width="1087" alt="Screen Shot 2021-01-12 at 3 11 39 PM" src="https://user-images.githubusercontent.com/57655/104367877-65628280-54e9-11eb-91da-578fec6ff769.png">
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Show
emsAppicon from EUI if integration includes map assets.Looking at #62059 (comment), I believe it landed with the incorrect key at a time when that part of the page wasn't visible. When we enabled that section, we likely didn't notice the missing key since most integrations don't have Maps assets
Bug:
masterdoesn't have an icon for Map assets/app/mapAppThis PR adds one