Skip to content

[ML] Persisted URL state for Anomalies table#84314

Merged
darnautov merged 2 commits intoelastic:masterfrom
darnautov:ML-83033-anomalies-table-url-state
Nov 25, 2020
Merged

[ML] Persisted URL state for Anomalies table#84314
darnautov merged 2 commits intoelastic:masterfrom
darnautov:ML-83033-anomalies-table-url-state

Conversation

@darnautov
Copy link
Copy Markdown
Contributor

@darnautov darnautov commented Nov 25, 2020 •
edited
Loading

Summary

Part of #83033

  • Adds persisted URL state for Anomalies table on Anomaly Explorer and Single Metric Viewer.
  • Adjust cell selection according to the time boundaries
  • Fixes the issue when switching the job with presented cell selection caused an incorrect state for fetching anomalies data

@darnautov darnautov self-assigned this Nov 25, 2020
@darnautov darnautov requested a review from a team as a code owner November 25, 2020 10:58
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 25, 2020

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov mentioned this pull request Nov 25, 2020
Closed
7 tasks
@peteharverson
Copy link
Copy Markdown
Contributor

peteharverson commented Nov 25, 2020 •
edited
Loading

Not related to these changes, but noticed that if you select a cell in the overall swim lane, we should clear the selectedTimes part of the URL if the user then switches to a job whose time range does not include the time of the previous selection. Currently the selectedTimes part of the URL causes incorrect filtering of the anomalies table and top influencers list:

image

@darnautov
Copy link
Copy Markdown
Contributor Author

darnautov commented Nov 25, 2020

Not related to these changes, but noticed that if you select a cell in the overall swim lane, we should clear the selectedTimes part of the URL if the user then switches to a job whose time range does not include the time of the previous selection. Currently the selectedTimes part of the URL causes incorrect filtering of the anomalies table and top influencers list:

image

@peteharverson Fixed in 218188e

peteharverson
peteharverson approved these changes Nov 25, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest edits and LGTM.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 25, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.2MB 5.2MB +5.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

walterra
walterra approved these changes Nov 25, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darnautov darnautov merged commit 280ce7e into elastic:master Nov 25, 2020
@darnautov darnautov deleted the ML-83033-anomalies-table-url-state branch November 25, 2020 15:49
@darnautov darnautov mentioned this pull request Nov 25, 2020
Merged
darnautov added a commit that referenced this pull request Nov 26, 2020
@darnautov
[ML] Persisted URL state for Anomalies table (#84314) (#84339)
b02858b 
* [ML] Persisted URL state for Anomalies table

* [ML] adjust cell selection according to the time range
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 26, 2020
@gmmorris
Merge branch 'master' into alerts/fix-buggy-default-message
2c5348f 
* master: (70 commits)
  [Uptime] Fix headers io-ts type (elastic#84089)
  [fleet] Add config options to accepted docker env vars (elastic#84338)
  [Fleet] Support URL query state in agent logs UI (elastic#84298)
  [basePathProxy] include query in redirect (elastic#84356)
  [Security Solution] Add Endpoint policy feature checks (elastic#83972)
  Fix issues with show_license_expiration (elastic#84361)
  [Security Solution][Resolver] Add support for predefined schemas for endpoint and winlogbeat (elastic#84103)
  [cli/dev] log a warning when --no-base-path is used with --dev (elastic#84354)
  [Fleet] Support input-level vars & templates (elastic#83878)
  [APM] Elastic chart issues (elastic#84238)
  [Time to Visualize] Fix Unlink Action via Rollback of ReplacePanel (elastic#83873)
  redirect to visualize listing page when by value visualization editor doesn't have a value input (elastic#84287)
  add live region for field search (elastic#84310)
  [ML] Persisted URL state for Anomalies table (elastic#84314)
  [dev/cli] detect worker type using env, not cluster module (elastic#83977)
  [Workplace Search] Migrate DisplaySettings tree (elastic#84283)
  Deprecate `xpack.task_manager.index` setting (elastic#84155)
  [Search] Search batching using bfetch (again) (elastic#84043)
  Use .kibana instead of .kibana_current to mark migration completion (elastic#83373)
  [Monitoring] Only look at ES for the missing data alert for now (elastic#83839)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 26, 2020
@gmmorris
Merge branch 'master' into alerts/rename-resolved-to-recovered
f2bd0e0 
* master: (119 commits)
  [Uptime] Fix headers io-ts type (elastic#84089)
  [fleet] Add config options to accepted docker env vars (elastic#84338)
  [Fleet] Support URL query state in agent logs UI (elastic#84298)
  [basePathProxy] include query in redirect (elastic#84356)
  [Security Solution] Add Endpoint policy feature checks (elastic#83972)
  Fix issues with show_license_expiration (elastic#84361)
  [Security Solution][Resolver] Add support for predefined schemas for endpoint and winlogbeat (elastic#84103)
  [cli/dev] log a warning when --no-base-path is used with --dev (elastic#84354)
  [Fleet] Support input-level vars & templates (elastic#83878)
  [APM] Elastic chart issues (elastic#84238)
  [Time to Visualize] Fix Unlink Action via Rollback of ReplacePanel (elastic#83873)
  redirect to visualize listing page when by value visualization editor doesn't have a value input (elastic#84287)
  add live region for field search (elastic#84310)
  [ML] Persisted URL state for Anomalies table (elastic#84314)
  [dev/cli] detect worker type using env, not cluster module (elastic#83977)
  [Workplace Search] Migrate DisplaySettings tree (elastic#84283)
  Deprecate `xpack.task_manager.index` setting (elastic#84155)
  [Search] Search batching using bfetch (again) (elastic#84043)
  Use .kibana instead of .kibana_current to mark migration completion (elastic#83373)
  [Monitoring] Only look at ES for the missing data alert for now (elastic#83839)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 9, 2020
@gmmorris
Merge branch 'master' into alerts/rename-resolved-to-recovered
205e526 
* master: (119 commits)
  [Uptime] Fix headers io-ts type (elastic#84089)
  [fleet] Add config options to accepted docker env vars (elastic#84338)
  [Fleet] Support URL query state in agent logs UI (elastic#84298)
  [basePathProxy] include query in redirect (elastic#84356)
  [Security Solution] Add Endpoint policy feature checks (elastic#83972)
  Fix issues with show_license_expiration (elastic#84361)
  [Security Solution][Resolver] Add support for predefined schemas for endpoint and winlogbeat (elastic#84103)
  [cli/dev] log a warning when --no-base-path is used with --dev (elastic#84354)
  [Fleet] Support input-level vars & templates (elastic#83878)
  [APM] Elastic chart issues (elastic#84238)
  [Time to Visualize] Fix Unlink Action via Rollback of ReplacePanel (elastic#83873)
  redirect to visualize listing page when by value visualization editor doesn't have a value input (elastic#84287)
  add live region for field search (elastic#84310)
  [ML] Persisted URL state for Anomalies table (elastic#84314)
  [dev/cli] detect worker type using env, not cluster module (elastic#83977)
  [Workplace Search] Migrate DisplaySettings tree (elastic#84283)
  Deprecate `xpack.task_manager.index` setting (elastic#84155)
  [Search] Search batching using bfetch (again) (elastic#84043)
  Use .kibana instead of .kibana_current to mark migration completion (elastic#83373)
  [Monitoring] Only look at ES for the missing data alert for now (elastic#83839)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@walterra walterra walterra approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@darnautov darnautov

Labels

:ml release_note:enhancement v7.11.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@darnautov @elasticmachine @peteharverson @kibanamachine @walterra