Skip to content

[Security Solution] Add Endpoint policy feature checks#83972

Merged
pzl merged 10 commits intoelastic:masterfrom
pzl:ep-license-checks
Nov 25, 2020
Merged

[Security Solution] Add Endpoint policy feature checks#83972
pzl merged 10 commits intoelastic:masterfrom
pzl:ep-license-checks

Conversation

@pzl
Copy link
Member

@pzl pzl commented Nov 20, 2020 •
edited
Loading

Summary

Add common utility functions for upcoming endpoint policy licensed checks. Adds two functions

  • isEndpointPolicyValidForLicense
  • unsetPolicyFeaturesAboveLicenseLevel

to verify Policy features against policy levels, and set those fields to defaults if required.

unit tests added for both

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@pzl pzl mentioned this pull request Nov 20, 2020
Merged
2 tasks
@pzl pzl force-pushed the ep-license-checks branch from 36e9e8f to 4330f5e Compare November 23, 2020 15:52
@pzl pzl marked this pull request as ready for review November 25, 2020 01:42
@pzl pzl requested review from a team as code owners November 25, 2020 01:42
@pzl pzl added Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.11.0 v8.0.0 labels Nov 25, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 25, 2020

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

@pzl pzl force-pushed the ep-license-checks branch from cbc0b02 to 9fd6951 Compare November 25, 2020 15:19
paul-tavares
paul-tavares approved these changes Nov 25, 2020
View reviewed changes
x-pack/plugins/security_solution/common/license/policy_config.test.ts
import { Subject } from 'rxjs';
import { ILicense } from '../../../licensing/common/types';

describe('policy_config and licenses', () => {
Copy link
Contributor

@paul-tavares paul-tavares Nov 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this entire file is 🔥

pzl added 3 commits November 25, 2020 11:15
@pzl
clean up license type return
f64665c
@pzl
refactor levels, allow level check outside the service
45c8a2d
@pzl
util functions use license directly
563e7f8 
since they may be called from a license subscription
before the license service itself finished updating.
no reason to make these dependent on a stateful object.

as much as I LOVED the emitter subject in the test file.
Simpler is better.

Can still call these from the license service with:
licenseService.getLicenseInformation() as the arg
@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 25, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.0MB 8.0MB +1.2KB

Distributable file count

id before after diff
default 43012 43013 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 167.5KB 166.4KB -1.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

parkiino
parkiino reviewed Nov 25, 2020
View reviewed changes
x-pack/plugins/security_solution/common/license/license.ts
}
}

export const isAtLeast = (license: ILicense | null, level: LicenseType): boolean => {
Copy link
Contributor

@parkiino parkiino Nov 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait this is nice and less repetitive :D

@pzl pzl merged commit 71f7786 into elastic:master Nov 25, 2020
pzl added a commit to pzl/kibana that referenced this pull request Nov 25, 2020
@pzl
[Security Solution] Add Endpoint policy feature checks (elastic#83972)
1dfd978
@pzl pzl mentioned this pull request Nov 25, 2020
Merged
pzl added a commit that referenced this pull request Nov 25, 2020
@pzl
[Security Solution] Add Endpoint policy feature checks (#83972) (#84372)
723e730
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 26, 2020
@gmmorris
Merge branch 'master' into alerts/fix-buggy-default-message
2c5348f 
* master: (70 commits)
  [Uptime] Fix headers io-ts type (elastic#84089)
  [fleet] Add config options to accepted docker env vars (elastic#84338)
  [Fleet] Support URL query state in agent logs UI (elastic#84298)
  [basePathProxy] include query in redirect (elastic#84356)
  [Security Solution] Add Endpoint policy feature checks (elastic#83972)
  Fix issues with show_license_expiration (elastic#84361)
  [Security Solution][Resolver] Add support for predefined schemas for endpoint and winlogbeat (elastic#84103)
  [cli/dev] log a warning when --no-base-path is used with --dev (elastic#84354)
  [Fleet] Support input-level vars & templates (elastic#83878)
  [APM] Elastic chart issues (elastic#84238)
  [Time to Visualize] Fix Unlink Action via Rollback of ReplacePanel (elastic#83873)
  redirect to visualize listing page when by value visualization editor doesn't have a value input (elastic#84287)
  add live region for field search (elastic#84310)
  [ML] Persisted URL state for Anomalies table (elastic#84314)
  [dev/cli] detect worker type using env, not cluster module (elastic#83977)
  [Workplace Search] Migrate DisplaySettings tree (elastic#84283)
  Deprecate `xpack.task_manager.index` setting (elastic#84155)
  [Search] Search batching using bfetch (again) (elastic#84043)
  Use .kibana instead of .kibana_current to mark migration completion (elastic#83373)
  [Monitoring] Only look at ES for the missing data alert for now (elastic#83839)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 26, 2020
@gmmorris
Merge branch 'master' into alerts/rename-resolved-to-recovered
f2bd0e0 
* master: (119 commits)
  [Uptime] Fix headers io-ts type (elastic#84089)
  [fleet] Add config options to accepted docker env vars (elastic#84338)
  [Fleet] Support URL query state in agent logs UI (elastic#84298)
  [basePathProxy] include query in redirect (elastic#84356)
  [Security Solution] Add Endpoint policy feature checks (elastic#83972)
  Fix issues with show_license_expiration (elastic#84361)
  [Security Solution][Resolver] Add support for predefined schemas for endpoint and winlogbeat (elastic#84103)
  [cli/dev] log a warning when --no-base-path is used with --dev (elastic#84354)
  [Fleet] Support input-level vars & templates (elastic#83878)
  [APM] Elastic chart issues (elastic#84238)
  [Time to Visualize] Fix Unlink Action via Rollback of ReplacePanel (elastic#83873)
  redirect to visualize listing page when by value visualization editor doesn't have a value input (elastic#84287)
  add live region for field search (elastic#84310)
  [ML] Persisted URL state for Anomalies table (elastic#84314)
  [dev/cli] detect worker type using env, not cluster module (elastic#83977)
  [Workplace Search] Migrate DisplaySettings tree (elastic#84283)
  Deprecate `xpack.task_manager.index` setting (elastic#84155)
  [Search] Search batching using bfetch (again) (elastic#84043)
  Use .kibana instead of .kibana_current to mark migration completion (elastic#83373)
  [Monitoring] Only look at ES for the missing data alert for now (elastic#83839)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 9, 2020
@gmmorris
Merge branch 'master' into alerts/rename-resolved-to-recovered
205e526 
* master: (119 commits)
  [Uptime] Fix headers io-ts type (elastic#84089)
  [fleet] Add config options to accepted docker env vars (elastic#84338)
  [Fleet] Support URL query state in agent logs UI (elastic#84298)
  [basePathProxy] include query in redirect (elastic#84356)
  [Security Solution] Add Endpoint policy feature checks (elastic#83972)
  Fix issues with show_license_expiration (elastic#84361)
  [Security Solution][Resolver] Add support for predefined schemas for endpoint and winlogbeat (elastic#84103)
  [cli/dev] log a warning when --no-base-path is used with --dev (elastic#84354)
  [Fleet] Support input-level vars & templates (elastic#83878)
  [APM] Elastic chart issues (elastic#84238)
  [Time to Visualize] Fix Unlink Action via Rollback of ReplacePanel (elastic#83873)
  redirect to visualize listing page when by value visualization editor doesn't have a value input (elastic#84287)
  add live region for field search (elastic#84310)
  [ML] Persisted URL state for Anomalies table (elastic#84314)
  [dev/cli] detect worker type using env, not cluster module (elastic#83977)
  [Workplace Search] Migrate DisplaySettings tree (elastic#84283)
  Deprecate `xpack.task_manager.index` setting (elastic#84155)
  [Search] Search batching using bfetch (again) (elastic#84043)
  Use .kibana instead of .kibana_current to mark migration completion (elastic#83373)
  [Monitoring] Only look at ES for the missing data alert for now (elastic#83839)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parkiino parkiino parkiino approved these changes

@paul-tavares paul-tavares paul-tavares approved these changes

Assignees

No one assigned

Labels

Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.11.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pzl @elasticmachine @kibanamachine @parkiino @paul-tavares