-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Removed leading spaces in yaml file #8324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,98 +1,98 @@ | ||
| # Kibana is served by a back end server. This setting specifies the port to use. | ||
| # server.port: 5601 | ||
| #server.port: 5601 | ||
|
|
||
| # Specifies the address to which the Kibana server will bind. IP addresses and host names are both valid values. | ||
| # The default is 'localhost', which usually means remote machines will not be able to connect. | ||
| # To allow connections from remote users, set this parameter to a non-loopback address. | ||
| # server.host: "localhost" | ||
| #server.host: "localhost" | ||
|
|
||
| # Enables you to specify a path to mount Kibana at if you are running behind a proxy. This setting | ||
| # cannot end in a slash. | ||
| # server.basePath: "" | ||
| #server.basePath: "" | ||
|
|
||
| # The maximum payload size in bytes for incoming server requests. | ||
| # server.maxPayloadBytes: 1048576 | ||
| #server.maxPayloadBytes: 1048576 | ||
|
|
||
| # The Kibana server's name. This is used for display purposes. | ||
| # server.name: "your-hostname" | ||
| #server.name: "your-hostname" | ||
|
|
||
| # The URL of the Elasticsearch instance to use for all your queries. | ||
| # elasticsearch.url: "http://localhost:9200" | ||
| #elasticsearch.url: "http://localhost:9200" | ||
|
|
||
| # When this setting’s value is true Kibana uses the hostname specified in the server.host | ||
| # setting. When the value of this setting is false, Kibana uses the hostname of the host | ||
| # that connects to this Kibana instance. | ||
| # elasticsearch.preserveHost: true | ||
| #elasticsearch.preserveHost: true | ||
|
|
||
| # Kibana uses an index in Elasticsearch to store saved searches, visualizations and | ||
| # dashboards. Kibana creates a new index if the index doesn’t already exist. | ||
| # kibana.index: ".kibana" | ||
| #kibana.index: ".kibana" | ||
|
|
||
| # The default application to load. | ||
| # kibana.defaultAppId: "discover" | ||
| #kibana.defaultAppId: "discover" | ||
|
|
||
| # If your Elasticsearch is protected with basic authentication, these settings provide | ||
| # the username and password that the Kibana server uses to perform maintenance on the Kibana | ||
| # index at startup. Your Kibana users still need to authenticate with Elasticsearch, which | ||
| # is proxied through the Kibana server. | ||
| # elasticsearch.username: "user" | ||
| # elasticsearch.password: "pass" | ||
| #elasticsearch.username: "user" | ||
| #elasticsearch.password: "pass" | ||
|
|
||
| # Paths to the PEM-format SSL certificate and SSL key files, respectively. These | ||
| # files enable SSL for outgoing requests from the Kibana server to the browser. | ||
| # server.ssl.cert: /path/to/your/server.crt | ||
| # server.ssl.key: /path/to/your/server.key | ||
| #server.ssl.cert: /path/to/your/server.crt | ||
| #server.ssl.key: /path/to/your/server.key | ||
|
|
||
| # Optional settings that provide the paths to the PEM-format SSL certificate and key files. | ||
| # These files validate that your Elasticsearch backend uses the same key files. | ||
| # elasticsearch.ssl.cert: /path/to/your/client.crt | ||
| # elasticsearch.ssl.key: /path/to/your/client.key | ||
| #elasticsearch.ssl.cert: /path/to/your/client.crt | ||
| #elasticsearch.ssl.key: /path/to/your/client.key | ||
|
|
||
| # Optional setting that enables you to specify a path to the PEM file for the certificate | ||
| # authority for your Elasticsearch instance. | ||
| # elasticsearch.ssl.ca: /path/to/your/CA.pem | ||
| #elasticsearch.ssl.ca: /path/to/your/CA.pem | ||
|
|
||
| # To disregard the validity of SSL certificates, change this setting’s value to false. | ||
| # elasticsearch.ssl.verify: true | ||
| #elasticsearch.ssl.verify: true | ||
|
|
||
| # Time in milliseconds to wait for Elasticsearch to respond to pings. Defaults to the value of | ||
| # the elasticsearch.requestTimeout setting. | ||
| # elasticsearch.pingTimeout: 1500 | ||
| #elasticsearch.pingTimeout: 1500 | ||
|
|
||
| # Time in milliseconds to wait for responses from the back end or Elasticsearch. This value | ||
| # must be a positive integer. | ||
| # elasticsearch.requestTimeout: 30000 | ||
| #elasticsearch.requestTimeout: 30000 | ||
|
|
||
| # List of Kibana client-side headers to send to Elasticsearch. To send *no* client-side | ||
| # headers, set this value to [] (an empty list). | ||
| # elasticsearch.requestHeadersWhitelist: [ authorization ] | ||
| #elasticsearch.requestHeadersWhitelist: [ authorization ] | ||
|
|
||
| # Header names and values that are sent to Elasticsearch. Any custom headers cannot be overwritten | ||
| # by client-side headers, regardless of the elasticsearch.requestHeadersWhitelist configuration. | ||
| # elasticsearch.customHeaders: {} | ||
| #elasticsearch.customHeaders: {} | ||
|
|
||
| # Time in milliseconds for Elasticsearch to wait for responses from shards. Set to 0 to disable. | ||
| # elasticsearch.shardTimeout: 0 | ||
| #elasticsearch.shardTimeout: 0 | ||
|
|
||
| # Time in milliseconds to wait for Elasticsearch at Kibana startup before retrying. | ||
| # elasticsearch.startupTimeout: 5000 | ||
| #elasticsearch.startupTimeout: 5000 | ||
|
|
||
| # Specifies the path where Kibana creates the process ID file. | ||
| # pid.file: /var/run/kibana.pid | ||
| #pid.file: /var/run/kibana.pid | ||
|
|
||
| # Enables you specify a file where Kibana stores log output. | ||
| # logging.dest: stdout | ||
| #logging.dest: stdout | ||
|
|
||
| # Set the value of this setting to true to suppress all logging output. | ||
| # logging.silent: false | ||
| #logging.silent: false | ||
|
|
||
| # Set the value of this setting to true to suppress all logging output other than error messages. | ||
| # logging.quiet: false | ||
| #logging.quiet: false | ||
|
|
||
| # Set the value of this setting to true to log all events, including system usage information | ||
| # and all requests. | ||
| # logging.verbose: false | ||
| #logging.verbose: false | ||
|
|
||
| # Set the interval in milliseconds to sample system and process performance | ||
| # metrics. Minimum is 100ms. Defaults to 5000. | ||
| # ops.interval: 5000 | ||
| #ops.interval: 5000 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for submitting this one! Can I suggest you maintain the spaces before the non-config sections, ie the actual descriptive comments, and just remove them for the config options. Like so;
Take a look at https://github.com/elastic/elasticsearch/pull/20094/files, which is the Elasticsearch version of the same thing :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Will check in with that update shortly. Thanks!