Removed leading spaces in yaml file#8324
Conversation
|
Can one of the admins verify this patch? |
|
|
||
| # Set the interval in milliseconds to sample system and process performance | ||
| # metrics. Minimum is 100ms. Defaults to 5000. | ||
| # ops.interval: 5000 |
There was a problem hiding this comment.
Awesome, thanks for submitting this one! Can I suggest you maintain the spaces before the non-config sections, ie the actual descriptive comments, and just remove them for the config options. Like so;
# Kibana is served by a back end server. This setting specifies the port to use.
#server.port: 5601
Take a look at https://github.com/elastic/elasticsearch/pull/20094/files, which is the Elasticsearch version of the same thing :)
There was a problem hiding this comment.
Makes sense. Will check in with that update shortly. Thanks!
|
LGTM! Looks like there's a conflict though, could you merge in or rebase on master? |
|
Sorry @pslawless, I missed this PR, and created a new one for this (#8438). My apologies for this... fwiw, I saw you did it in ES, and really liked that change.. |
6 participants
Resolves #8268