Skip to content

Conversation

@bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Oct 30, 2020

Summary

Updates the anomaly detection integration callout.

Screenshot

Screen Shot 2020-10-30 at 1 41 06 PM

Related issues

Closes #81437.

@bmorelli25 bmorelli25 added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Oct 30, 2020
@bmorelli25 bmorelli25 requested a review from formgeist October 30, 2020 19:23
@bmorelli25 bmorelli25 requested a review from a team as a code owner October 30, 2020 19:23
@bmorelli25 bmorelli25 self-assigned this Oct 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@bmorelli25 bmorelli25 changed the title Ml callout [APM] docs: Update anomaly detection callout Oct 30, 2020
@bmorelli25 bmorelli25 added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Oct 30, 2020
@bmorelli25
Copy link
Member Author

bmorelli25 commented Oct 30, 2020

Aw, this eslint always gets me. Can someone please remind me how to fix that?

Edit: Running node scripts/eslint --fix. . . we'll see if that works

Copy link
Contributor

@formgeist formgeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment on lines 79 to 80
defaultMessage:
'The Machine Learning anomaly detection integration enables application health status indicators for each configured environment in the Service map by identifying transaction duration anomalies.',
`Machine Learning's anomaly detection integration enables application health status indicators for services in each configured environment by identifying transaction duration anomalies.`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing due to a formatting issue here.

/dev/shm/workspace/parallel/10/kibana/x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/index.tsx
  79:26  error  Delete `⏎···········`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

Can you run prettier locally?

yarn prettier  "./x-pack/plugins/apm/**/*.{tsx,ts,js}" --write

@bmorelli25
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
apm 3.2MB 3.2MB +68.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bmorelli25 bmorelli25 merged commit 3709b77 into elastic:master Nov 2, 2020
@bmorelli25 bmorelli25 deleted the ml-callout branch November 2, 2020 19:15
bmorelli25 added a commit to bmorelli25/kibana that referenced this pull request Nov 2, 2020
# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.10.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[APM] Improve service inventory ML anomaly detection callout message copy

5 participants