-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[KP] Fix Headers timeout issue #81140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
e1a2ea6
e04b7ba
e260737
2e0e5a2
f77136d
dde9fd0
4f1bba0
5a8c993
47d07a3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| /* | ||
| * Licensed to Elasticsearch B.V. under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch B.V. licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import Http from 'http'; | ||
| import Url from 'url'; | ||
| import { FtrProviderContext } from '../../services/types'; | ||
|
|
||
| // @ts-ignore | ||
| import getUrl from '../../../../src/test_utils/get_url'; | ||
|
|
||
| const delay = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms)); | ||
| const oneSec = 1_000; | ||
|
|
||
| // eslint-disable-next-line import/no-default-export | ||
| export default function ({ getService }: FtrProviderContext) { | ||
| const config = getService('config'); | ||
|
|
||
| describe('headers timeout ', () => { | ||
| it('issue-73849', async () => { | ||
| const agent = new Http.Agent({ | ||
| keepAlive: true, | ||
| }); | ||
| const { protocol, hostname, port } = Url.parse(getUrl.baseUrl(config.get('servers.kibana'))); | ||
|
|
||
| function performRequest() { | ||
| return new Promise((resolve, reject) => { | ||
| const req = Http.request( | ||
| { | ||
| protocol, | ||
| hostname, | ||
| port, | ||
| path: '/', | ||
| method: 'GET', | ||
| agent, | ||
| }, | ||
| function (res) { | ||
| let data = ''; | ||
| res.on('data', (chunk) => { | ||
| data += chunk; | ||
| }); | ||
| res.on('end', () => resolve(data)); | ||
| } | ||
| ); | ||
|
|
||
| req.on('socket', (socket) => { | ||
| socket.write('GET / HTTP/1.1\r\n'); | ||
| setTimeout(() => { | ||
| socket.write('Host: localhost\r\n'); | ||
| }, oneSec); | ||
| setTimeout(() => { | ||
| // headersTimeout doesn't seem to fire if request headers are sent in one packet. | ||
| socket.write('\r\n'); | ||
| req.end(); | ||
| }, 2 * oneSec); | ||
| }); | ||
|
|
||
| req.on('error', reject); | ||
| }); | ||
| } | ||
|
|
||
| await performRequest(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Your test code makes my original recreation look like 💩. |
||
| const defaultHeadersTimeout = 40_000; | ||
| await delay(defaultHeadersTimeout + oneSec); | ||
| await performRequest(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are no assertions in the test, the test is ensuring that the calls to
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes |
||
| }); | ||
| }); | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| /* | ||
| * Licensed to Elasticsearch B.V. under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch B.V. licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| import { GenericFtrProviderContext } from '@kbn/test/types/ftr'; | ||
| import { services as kibanaCommonServices } from '../../common/services'; | ||
| import { services as kibanaApiIntegrationServices } from '../../api_integration/services'; | ||
|
|
||
| export type FtrProviderContext = GenericFtrProviderContext< | ||
| typeof kibanaCommonServices & { supertest: typeof kibanaApiIntegrationServices.supertest }, | ||
| {} | ||
| >; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about https://v8.dev/features/numeric-separators. Very nice!