-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[KP] Fix Headers timeout issue #81140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mshustov
merged 9 commits into
elastic:master
from
mshustov:issue-73849-headers-timeout
Oct 22, 2020
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e1a2ea6
temp fix request headers bug. issue 73849
mshustov e04b7ba
Merge branch 'master' into issue-73849-headers-timeout
mshustov e260737
Merge branch 'master' into issue-73849-headers-timeout
mshustov 2e0e5a2
add a focused test
mshustov f77136d
move test to FTR
mshustov dde9fd0
adjust types
mshustov 4f1bba0
some minors
mshustov 5a8c993
small adjustments
mshustov 47d07a3
Merge branch 'master' into issue-73849-headers-timeout
mshustov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| /* | ||
| * Licensed to Elasticsearch B.V. under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch B.V. licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import Http from 'http'; | ||
| import Url from 'url'; | ||
| import { FtrProviderContext } from '../../services/types'; | ||
|
|
||
| // @ts-ignore | ||
| import getUrl from '../../../../src/test_utils/get_url'; | ||
|
|
||
| const delay = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms)); | ||
| const oneSec = 1_000; | ||
|
|
||
| // eslint-disable-next-line import/no-default-export | ||
| export default function ({ getService }: FtrProviderContext) { | ||
| const config = getService('config'); | ||
|
|
||
| describe('headers timeout ', () => { | ||
| it('issue-73849', async () => { | ||
| const agent = new Http.Agent({ | ||
| keepAlive: true, | ||
| }); | ||
| const { protocol, hostname, port } = Url.parse(getUrl.baseUrl(config.get('servers.kibana'))); | ||
|
|
||
| function performRequest() { | ||
| return new Promise((resolve, reject) => { | ||
| const req = Http.request( | ||
| { | ||
| protocol, | ||
| hostname, | ||
| port, | ||
| path: '/', | ||
| method: 'GET', | ||
| agent, | ||
| }, | ||
| function (res) { | ||
| let data = ''; | ||
| res.on('data', (chunk) => { | ||
| data += chunk; | ||
| }); | ||
| res.on('end', () => resolve(data)); | ||
| } | ||
| ); | ||
|
|
||
| req.on('socket', (socket) => { | ||
| socket.write('GET / HTTP/1.1\r\n'); | ||
| setTimeout(() => { | ||
| socket.write('Host: localhost\r\n'); | ||
| }, oneSec); | ||
| setTimeout(() => { | ||
| // headersTimeout doesn't seem to fire if request headers are sent in one packet. | ||
| socket.write('\r\n'); | ||
| req.end(); | ||
| }, 2 * oneSec); | ||
| }); | ||
|
|
||
| req.on('error', reject); | ||
| }); | ||
| } | ||
|
|
||
| await performRequest(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Your test code makes my original recreation look like 💩. |
||
| const defaultHeadersTimeout = 40 * oneSec; | ||
| await delay(defaultHeadersTimeout + oneSec); | ||
| await performRequest(); | ||
| }); | ||
| }); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| /* | ||
| * Licensed to Elasticsearch B.V. under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch B.V. licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| import { GenericFtrProviderContext } from '@kbn/test/types/ftr'; | ||
| import { services as kibanaCommonServices } from '../../common/services'; | ||
| import { services as kibanaApiIntegrationServices } from '../../api_integration/services'; | ||
|
|
||
| export type FtrProviderContext = GenericFtrProviderContext< | ||
| typeof kibanaCommonServices & { supertest: typeof kibanaApiIntegrationServices.supertest }, | ||
| {} | ||
| >; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about https://v8.dev/features/numeric-separators. Very nice!