[CSV Upload] Throw warning when a column name contains spaces#7995
Closed
timroes wants to merge 4 commits intoelastic:masterfrom
Closed
[CSV Upload] Throw warning when a column name contains spaces#7995timroes wants to merge 4 commits intoelastic:masterfrom
timroes wants to merge 4 commits intoelastic:masterfrom
Conversation
Contributor
|
Can one of the admins verify this patch? |
timroes
force-pushed
the
csvImporterCamelCase
branch
from
f67232e to
22344eb
Compare
| } | ||
|
|
||
| if (results.meta.fields.some(name => /\s/.test(name))) { | ||
| this.formattedWarnings.push('Field names with spaces are dificult to search for in Kibana'); |
Contributor
Author
There was a problem hiding this comment.
How the hell could that happen, I copied your sentence from IRC :D
Anyway... fixed it.
Contributor
|
LGTM. @BigFunger could you take a second quick look at this? |
Bargs
changed the title
Contributor
|
@timroes could you update the PR description to reflect the new design, just so no one's confused in the future? |
Contributor
Contributor
Author
Contributor
|
@timroes fantastic, thanks |
Contributor
Contributor
Author
|
@Bargs Looking at the validateHeaders function I wouldn't add it to this, since this is really made for errors and not warnings. So I would still "just" add it to the Other option would be to modify the validateHeaders function to be more about "issues" and not "errors", i.e. renaming all of the vars/tests/etc. in there. Your opinion on this? |
Contributor
|
I think it'd be fine to update |
jbudz
pushed a commit
that referenced
this pull request
Sep 10, 2024
`v95.9.0`⏩`v95.10.1` > [!note] > **EuiDataGrid**'s header cells have received a major UX change in order to support interactive children within header content. Column header actions now must be hovered and then clicked directly, or opened with the Enter key, as opposed to being able to click the entire header cell to see the actions popover. _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v95.10.0`](https://github.com/elastic/eui/releases/v95.10.0) - Updated `EuiDataGrid` to support interactive header cell content ([#7898](elastic/eui#7898)) - Updated `EuiSearchBar`'s `field_value_selection` filter type with a new `autoSortOptions` config, allowing consumers to configure whether or not selected options are automatically sorted to the top of the filter list ([#7958](elastic/eui#7958)) - Updated `getDefaultEuiMarkdownPlugins` to support the following new default plugin configurations: ([#7985](elastic/eui#7985)) - `parsingConfig.linkValidator`, which allows configuring `allowRelative` and `allowProtocols` - `parsingConfig.emoji`, which allows configuring emoticon parsing - `processingConfig.linkProps`, which allows configuring rendered links with any props that `EuiLink` accepts - See our **Markdown plugins** documentation for example `EuiMarkdownFormat` and `EuiMarkdownEditor` usage - Updated `EuiDatePicker` to support `append` and `prepend` nodes in its form control layout ([#7987](elastic/eui#7987)) **Bug fixes** - Fixed border rendering bug with inline `EuiDatePicker`s with `shadow={false}` ([#7987](elastic/eui#7987)) - Fixed `EuiSuperSelect`'s placeholder text color to match other form controls ([#7995](elastic/eui#7995)) **Accessibility** - Improved the keyboard navigation and screen reader output for `EuiDataGrid` header cells ([#7898](elastic/eui#7898)) ## [`v95.10.1`](https://github.com/elastic/eui/releases/v95.10.1) **Bug fixes** - Fixed a visual bug in compact density `EuiDataGrid`s, where the header cell height would increase when the actions button became visible ([#7999](elastic/eui#7999)) --------- Co-authored-by: Lene Gadewoll <lene.gadewoll@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When importing a CSV via the new CSV importer column names have been used as printed in CSV.
Since field names with space are problematic to use in Kibana, the importer now shows a warning when the CSV contains any fields with spaces in their names.