Conversation
cee-chen
added
release_note:skip
- not all of them, just the oens related to header column actions in this PR. someone on the owning Kibana team should likely look into resolving all of them - errors were `Warning: An update to DataTable inside a test was not wrapped in act(...).` and `Warning: Can't perform a React state update on an unmounted component`
…ons button changes + fix misc failing test to use said service
…counts for header changes + add new util for default "Hide columns" copy
…king any action at an index + add new util for default "Hide columns" copy
…e mouse is inside header column
ensures test order instead, as opened flyout contains a standalone datagrid the column header test assertion should happen on a state with only the first datagrid
cee-chen
commented
Sep 4, 2024
Contributor
|
Pinging @elastic/eui-team (EUI) |
jbudz
approved these changes
Sep 4, 2024
botelastic
bot
added
the
ci:project-deploy-observability
kdelemme
approved these changes
Sep 5, 2024
Contributor
kdelemme
left a comment
kdelemme
left a comment
There was a problem hiding this comment.
obs-ux-management code change looks good to me!
markov00
approved these changes
Sep 6, 2024
davismcphee
approved these changes
Sep 9, 2024
Contributor
davismcphee
left a comment
davismcphee
left a comment
There was a problem hiding this comment.
Data Discovery changes look good, and everything seems to be working as expected in Discover 👍 Thanks for making the data grid header change, this unblocks some planned changes for us!
Contributor
Author
|
@elastic/kibana-core @elastic/security-threat-hunting-investigations Ping for codeowning review - we will be requesting an admin merge by today or tomorrow. |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v95.9.0⏩v95.10.1Note
EuiDataGrid's header cells have received a major UX change in order to support interactive children within header content. Column header actions now must be hovered and then clicked directly, or opened with the Enter key, as opposed to being able to click the entire header cell to see the actions popover.
Questions? Please see our Kibana upgrade FAQ.
v95.10.0EuiDataGridto support interactive header cell content (#7898)EuiSearchBar'sfield_value_selectionfilter type with a newautoSortOptionsconfig, allowing consumers to configure whether or not selected options are automatically sorted to the top of the filter list (#7958)getDefaultEuiMarkdownPluginsto support the following new default plugin configurations: (#7985)parsingConfig.linkValidator, which allows configuringallowRelativeandallowProtocolsparsingConfig.emoji, which allows configuring emoticon parsingprocessingConfig.linkProps, which allows configuring rendered links with any props thatEuiLinkacceptsEuiMarkdownFormatandEuiMarkdownEditorusageEuiDatePickerto supportappendandprependnodes in its form control layout (#7987)Bug fixes
EuiDatePickers withshadow={false}(#7987)EuiSuperSelect's placeholder text color to match other form controls (#7995)Accessibility
EuiDataGridheader cells (#7898)v95.10.1Bug fixes
EuiDataGrids, where the header cell height would increase when the actions button became visible (#7999)