Skip to content

fix lodash imports #78456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 29, 2020
Merged

fix lodash imports #78456

merged 3 commits into from
Sep 29, 2020

Conversation

@mshustov
Copy link
Contributor

@mshustov mshustov commented Sep 24, 2020

Summary

follow-up on #78156

@mshustov mshustov added chore Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 24, 2020
@mshustov mshustov requested a review from a team as a code owner September 24, 2020 16:59
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 24, 2020

Pinging @elastic/kibana-platform (Team:Platform)

@mshustov
Copy link
Contributor Author

mshustov commented Sep 25, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 29, 2020

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id value diff baseline
core 430 -4 434
data 566 -4 570
graph 169 -11 180
ingestManager 540 -11 551
licensing 12 -13 25
uiActionsEnhanced 134 -11 145
total -54

async chunks size

id value diff baseline
graph 1.3MB -12.8KB 1.3MB

page load bundle size

id value diff baseline
core 789.7KB -10.9KB 800.6KB
data 1.3MB -10.9KB 1.3MB
ingestManager 508.8KB -12.7KB 521.5KB
licensing 23.1KB -3.6KB 26.8KB
uiActionsEnhanced 320.7KB -12.8KB 333.5KB
total -51.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit a3b3a4d into elastic:master Sep 29, 2020
@mshustov mshustov deleted the fix-lodash-imports branch September 29, 2020 11:23
@mshustov
Copy link
Contributor Author

mshustov commented Sep 29, 2020

backport is waiting for #78667

phillipb added a commit to phillipb/kibana that referenced this pull request Sep 29, 2020
@phillipb
Merge branch 'master' of github.com:elastic/kibana into add-anomalies…
f7e5f99 
…-to-timeline

* 'master' of github.com:elastic/kibana: (22 commits)
  update apm index pattern (elastic#78732)
  78024: move transform out of dataset (elastic#78216)
  [QA][Code Coverage] Upload the coverage static site before ingestion (elastic#78695)
  [Discover] Make _source field not clickable (elastic#78698)
  [Fleet] Rename Ingest Manager => Fleet, Fleet => Agents in the UI (elastic#78685)
  [APM] Review feedback from distribution + transaction metrics (elastic#78752)
  [Ingest pipelines] Add ability to stop pipeline simulation  (elastic#78183)
  [CSM] Fix core vital legend background (elastic#78273)
  [Usage Collection] [schema] Support spreads + `canvas` definition (elastic#78481)
  fix lodash imports (elastic#78456)
  [Maps] Add layer type preview icons (elastic#78650)
  [APM] Use transaction metrics for distribution charts (elastic#78484)
  [Uptime] Ml anomaly alert edit (elastic#76909)
  [ML] Limit exposing shared static code through ml/public/index.ts. (elastic#77745)
  making expression debug info serializable (elastic#78727)
  fix lodahs imports in app-arch code (elastic#78582)
  Make Field a React.lazy export (elastic#78483)
  [Security Solution] Improves detections tests (elastic#77295)
  [TSVB] Different field format on different series is ignored (elastic#78138)
  RFC: Improve saved object migrations (elastic#66056)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 1, 2020
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 1, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78456 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 2, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78456 or prevent reminders by adding the backport:skip label.

@mshustov mshustov mentioned this pull request Oct 4, 2020
Merged
mshustov added a commit to mshustov/kibana that referenced this pull request Oct 4, 2020
@mshustov
fix lodash imports (elastic#78456)
ecaeeeb
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 4, 2020
mshustov added a commit that referenced this pull request Oct 4, 2020
@mshustov
fix lodash imports (#78456) (#79394)
b963d2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees

No one assigned

Labels

chore release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mshustov @elasticmachine @kibanamachine @pgayvallet