Skip to content

[QA][Code Coverage] Upload the coverage static site before ingestion #78695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2020
Merged

[QA][Code Coverage] Upload the coverage static site before ingestion #78695

merged 1 commit into from
Sep 29, 2020

Conversation

@wayneseymour
Copy link
Contributor

@wayneseymour wayneseymour commented Sep 28, 2020

Ingest the data as the very last operation.

@wayneseymour wayneseymour added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes test-coverage issues & PRs for improving code test coverage labels Sep 28, 2020
@wayneseymour wayneseymour self-assigned this Sep 28, 2020
@wayneseymour
Copy link
Contributor Author

wayneseymour commented Sep 28, 2020

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1181/

@wayneseymour wayneseymour marked this pull request as ready for review September 29, 2020 02:05
dmlemeshko
dmlemeshko approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wayneseymour wayneseymour merged commit f73bc48 into master Sep 29, 2020
@wayneseymour wayneseymour deleted the ingest-last branch September 29, 2020 14:29
phillipb added a commit to phillipb/kibana that referenced this pull request Sep 29, 2020
@phillipb
Merge branch 'master' of github.com:elastic/kibana into add-anomalies…
f7e5f99 
…-to-timeline

* 'master' of github.com:elastic/kibana: (22 commits)
  update apm index pattern (elastic#78732)
  78024: move transform out of dataset (elastic#78216)
  [QA][Code Coverage] Upload the coverage static site before ingestion (elastic#78695)
  [Discover] Make _source field not clickable (elastic#78698)
  [Fleet] Rename Ingest Manager => Fleet, Fleet => Agents in the UI (elastic#78685)
  [APM] Review feedback from distribution + transaction metrics (elastic#78752)
  [Ingest pipelines] Add ability to stop pipeline simulation  (elastic#78183)
  [CSM] Fix core vital legend background (elastic#78273)
  [Usage Collection] [schema] Support spreads + `canvas` definition (elastic#78481)
  fix lodash imports (elastic#78456)
  [Maps] Add layer type preview icons (elastic#78650)
  [APM] Use transaction metrics for distribution charts (elastic#78484)
  [Uptime] Ml anomaly alert edit (elastic#76909)
  [ML] Limit exposing shared static code through ml/public/index.ts. (elastic#77745)
  making expression debug info serializable (elastic#78727)
  fix lodahs imports in app-arch code (elastic#78582)
  Make Field a React.lazy export (elastic#78483)
  [Security Solution] Improves detections tests (elastic#77295)
  [TSVB] Different field format on different series is ignored (elastic#78138)
  RFC: Improve saved object migrations (elastic#66056)
  ...
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 1, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78695 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 1, 2020
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 2, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78695 or prevent reminders by adding the backport:skip label.

3 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 5, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78695 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 6, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78695 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 7, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78695 or prevent reminders by adding the backport:skip label.

@wayneseymour wayneseymour added the backport:skip This PR does not require backporting label Oct 7, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmlemeshko dmlemeshko dmlemeshko approved these changes

@LeeDr LeeDr Awaiting requested review from LeeDr

@marius-dr marius-dr Awaiting requested review from marius-dr

Assignees

@wayneseymour wayneseymour

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes test-coverage issues & PRs for improving code test coverage v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wayneseymour @kibanamachine @dmlemeshko