Remove legacy plugins support #77599
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,9 +17,6 @@ | |
| * under the License. | ||
| */ | ||
|
|
||
| const APACHE_2_0_LICENSE_HEADER = ` | ||
| /* | ||
| * Licensed to Elasticsearch B.V. under one or more contributor | ||
|
|
@@ -288,7 +285,7 @@ module.exports = { | |
| }, | ||
| { | ||
| target: [ | ||
| 'src/legacy/**/*', | ||
| '(src|x-pack)/plugins/**/(public|server)/**/*', | ||
| 'examples/**/*', | ||
| ], | ||
|
|
@@ -319,14 +316,11 @@ module.exports = { | |
| }, | ||
| { | ||
| target: [ | ||
| 'src/legacy/**/*', | ||
| '(src|x-pack)/plugins/**/(public|server)/**/*', | ||
| 'examples/**/*', | ||
| '!(src|x-pack)/**/*.test.*', | ||
| '!(x-pack/)?test/**/*', | ||
| ], | ||
| from: [ | ||
| '(src|x-pack)/plugins/**/(public|server)/**/*', | ||
|
|
@@ -341,14 +335,6 @@ module.exports = { | |
| '(src|x-pack)/plugins/**/*', | ||
| '!(src|x-pack)/plugins/**/server/**/*', | ||
|
|
||
| 'examples/**/*', | ||
| '!examples/**/server/**/*', | ||
| ], | ||
|
|
@@ -370,12 +356,7 @@ module.exports = { | |
| }, | ||
| { | ||
| target: ['src/core/**/*'], | ||
| from: ['plugins/**/*', 'src/plugins/**/*', 'src/legacy/ui/**/*'], | ||
| errorMessage: 'The core cannot depend on any plugins.', | ||
| }, | ||
| { | ||
|
|
@@ -388,12 +369,6 @@ module.exports = { | |
| target: [ | ||
| 'test/plugin_functional/plugins/**/public/np_ready/**/*', | ||
| 'test/plugin_functional/plugins/**/server/np_ready/**/*', | ||
| ], | ||
| allowSameFolder: true, | ||
| errorMessage: | ||
|
|
@@ -443,22 +418,14 @@ module.exports = { | |
| settings: { | ||
| // instructs import/no-extraneous-dependencies to treat certain modules | ||
| // as core modules, even if they aren't listed in package.json | ||
| 'import/core-modules': ['plugins'], | ||
|
|
||
| 'import/resolver': { | ||
| '@kbn/eslint-import-resolver-kibana': { | ||
| forceNode: false, | ||
| rootPackageName: 'kibana', | ||
| kibanaPath: '.', | ||
| pluginMap: {}, | ||
|
Comment on lines
-453
to
+428
There was a problem hiding this comment. I'm not sure this rule makes any sense without any legacy plugin. I changed There was a problem hiding this comment. I think that the custom eslint-import-resolver-kibana settings for x-pack are only required for the legacy import syntax support for things like There was a problem hiding this comment. Doesn't it mean that we can remove the There was a problem hiding this comment. Actually still necessary. See https://github.com/elastic/kibana/pull/77599/checks?check_run_id=1147976384 |
||
| }, | ||
| }, | ||
| }, | ||
|
|
@@ -764,16 +731,6 @@ module.exports = { | |
| }, | ||
| }, | ||
|
|
||
| /** | ||
| * ML overrides | ||
| */ | ||
|
|
@@ -812,7 +769,7 @@ module.exports = { | |
| }, | ||
| { | ||
| // typescript only for front and back end | ||
| files: ['x-pack/plugins/security_solution/**/*.{ts,tsx}'], | ||
| rules: { | ||
| // This will be turned on after bug fixes are complete | ||
| // '@typescript-eslint/explicit-member-accessibility': 'warn', | ||
|
|
@@ -858,7 +815,7 @@ module.exports = { | |
| // }, | ||
| { | ||
| // typescript and javascript for front and back end | ||
| files: ['x-pack/plugins/security_solution/**/*.{js,mjs,ts,tsx}'], | ||
| plugins: ['eslint-plugin-node', 'react'], | ||
| env: { | ||
| mocha: true, | ||
|
|
@@ -1089,7 +1046,7 @@ module.exports = { | |
| { | ||
| // typescript only for front and back end | ||
| files: [ | ||
| 'x-pack/plugins/{alerts,alerting_builtins,actions,task_manager,event_log}/**/*.{ts,tsx}', | ||
| ], | ||
| rules: { | ||
| '@typescript-eslint/no-explicit-any': 'error', | ||
|
|
@@ -1238,10 +1195,7 @@ module.exports = { | |
| * TSVB overrides | ||
| */ | ||
| { | ||
| files: ['src/plugins/vis_type_timeseries/**/*.{js,mjs,ts,tsx}'], | ||
| rules: { | ||
| 'import/no-default-export': 'error', | ||
| }, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,7 +28,6 @@ export { Public, Server }; | |
| /** | ||
| * All exports from TS ambient definitions (where types are added for JS source in a .d.ts file). | ||
| */ | ||
| import * as LegacyKibanaServer from './src/legacy/server/kbn_server'; | ||
|
|
||
| /** | ||
|
|
@@ -39,8 +38,4 @@ export namespace Legacy { | |
| export type Request = LegacyKibanaServer.Request; | ||
| export type ResponseToolkit = LegacyKibanaServer.ResponseToolkit; | ||
| export type Server = LegacyKibanaServer.Server; | ||
|
There was a problem hiding this comment. There shouldn't be any plugin code relying on the Hapi types. Created #77997 |
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.