Remove legacy plugins support #77599

pgayvallet · 2020-09-16T11:20:37Z

Summary

Fix #71927

Remove legacy plugin discovery and support from the legacy platform.

remove the legacy plugin system
unwire the legacy plugin discovery from core
remove the legacy xpackMain plugin
adapt usages and references to the legacy types

Checklist

Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

Release Note

The legacy plugin system and the legacy plugin API have been removed. It is no longer possible to use third parties legacy Kibana plugins. Legacy plugin owners should migrate their plugins to the Kibana Platform plugin API

…legacy-plugins-support

joshdover · 2020-09-16T15:10:18Z

@pgayvallet I think we can also delete x-pack/legacy/plugins in this PR? Maybe even all of x-pack/legacy?

pgayvallet · 2020-09-16T15:13:26Z

we can also delete x-pack/legacy/plugins in this PR? Maybe even all of x-pack/legacy?

I was going wait until #75648 and #74532 are done to do the remaining cleanup of x-pack/legacy. But yes, x-pack/index.js and all associated files will be deleted here.

pgayvallet · 2020-09-17T14:19:04Z

Only waiting for #77703, #75648 and #74532 now

…legacy-plugins-support

…in is deleted

…legacy-plugins-support

walterra

Code & local test LGTM

walterra · 2020-09-21T11:51:36Z

x-pack/plugins/transform/server/routes/api/error_utils.ts

+export function wrapEsError(err: any, statusCodeToMessageMap: Record<string, any> = {}) {
+  const { statusCode, response } = err;
+
+  const {
+    error: {
+      root_cause = [], // eslint-disable-line @typescript-eslint/naming-convention
+      caused_by = {}, // eslint-disable-line @typescript-eslint/naming-convention
+    } = {},
+  } = JSON.parse(response);


Thanks for the heads up!

mshustov

Looks good overall. There are still a few things to remove, I'm going to add them to #56205 to do in the follow-ups.

mshustov · 2020-09-21T11:38:31Z

.eslintrc.js

-            pluginMap: readdirSync(resolve(__dirname, 'x-pack/legacy/plugins')).reduce(
-              (acc, name) => {
-                if (!name.startsWith('_')) {
-                  acc[name] = `x-pack/legacy/plugins/${name}`;
-                }
-                return acc;
-              },
-              {}
-            ),
+            pluginMap: {},


Doesn't it mean that we can remove the eslint-import-resolver-kibana plugin at all?

.eslintrc.js

mshustov · 2020-09-21T11:45:07Z

kibana.d.ts

  export type KibanaConfig = LegacyKibanaServer.KibanaConfig;
  export type Request = LegacyKibanaServer.Request;
  export type ResponseToolkit = LegacyKibanaServer.ResponseToolkit;
  export type Server = LegacyKibanaServer.Server;


There shouldn't be any plugin code relying on the Hapi types. Created #77997

mshustov · 2020-09-21T12:17:31Z

src/core/server/legacy/legacy_internals.test.ts

-      legacyInternals = new LegacyInternals(uiExports, config, server);
+      legacyInternals = new LegacyInternals();


Hm...IIRC it's used to read injectedVars only.

kibana/src/core/server/rendering/rendering_service.tsx

Line 89 in 0ac0df2

vars: vars ?? (await this.legacyInternals!.getVars('core', request)),

As we don't have any plugins to inject vars, we can delete this API. Did I miss anything?
Can be done in a follow-up. Could you create an issue, please?

src/core/server/legacy/legacy_service.ts

mshustov · 2020-09-21T12:33:32Z

src/core/server/rendering/types.ts

      plugin: DiscoveredPlugin;
      config?: Record<string, unknown>;
    }>;
    legacyMetadata: {


It seems we use legacyMetadata to read uiSettings solely. Can we remove the other fields?

src/legacy/server/config/schema.js

src/legacy/server/kbn_server.d.ts

src/legacy/plugin_discovery/plugin_pack/__tests__/fixtures/plugins/exports_string/index.js

x-pack/dev-tools/jest/create_jest_config.js

jen-huang

Ingest Manager changes LGTM

patrykkopycinski

SIEM changes LGTM, Thank you @pgayvallet 👍

smith

APM changes look good.

smith · 2020-09-21T21:03:17Z

x-pack/plugins/apm/common/service_health_status.ts

 import { ANOMALY_SEVERITY } from '../../ml/common';

-import { EuiTheme } from '../../../legacy/common/eui_styled_components';
+import { EuiTheme } from '../../xpack_legacy/common';


We can actually import this from the observability plugin but it's in public there so we'll have to move that around in a separate PR.

…legacy-plugins-support

jasonrhodes

Is xpack_legacy a folder you want to remove? Should we be planning to move off of that or is it fine to leave those paths like that forever?

spalger

LGTM

mistic

LGTM

…legacy-plugins-support

pgayvallet · 2020-09-23T05:59:17Z

@jasonrhodes

Is xpack_legacy a folder you want to remove? Should we be planning to move off of that or is it fine to leave those paths like that forever?

We are not planning to delete this plugin short term, even if at some point, we probably will (8.0 hopefully)

Regarding what I had to move there in this PR (the EuiThemeProvider related stuff), I created #78248 to discuss where it should actually be moved

* remove ALL the things. * adapt some types and tests * restore ensureValidConfiguration * fix legacy service tests * adapt uiRender mixin * remove legacy types * update generated doc * restore legacy plugin schema * update generated doc * remove remaining code of x-pack/legacy * adapt imports due to merge * cleanup CODEOWNERS * cleanup gitignore & i18nrc * cleanup tsconfig.json * remove unused i18n keys * add back `"legacy/plugins/**/*",` to tsconfig until legacy space plugin is deleted * fix create_jest_config * remove references from eslintrc * more eslint cleanup * remove `x-pack/index.js` * fix xpack gulp scripts * fix bug with default + named imports from boom * remove rules from eslintrc * remove LegacyInternals * review comments * update generated doc * cleanup legacy metadatas * revert changes to eslintrc * update generated doc # Conflicts: # .github/CODEOWNERS # x-pack/.i18nrc.json # x-pack/dev-tools/jest/create_jest_config.js # x-pack/legacy/plugins/xpack_main/index.js # x-pack/legacy/server/lib/constants/index.ts # x-pack/legacy/server/lib/key_case_converter.js # x-pack/legacy/server/lib/watch_status_and_license_to_initialize.js

kibanamachine · 2020-09-23T09:39:18Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 7c54be0

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
transform	500	-3	503
watcher	224	-3	227
total		-6

async chunks size

id	value	diff	baseline
infra	3.9MB	-72.0B	3.9MB
ingestManager	1.1MB	-36.0B	1.1MB
observability	296.5KB	-36.0B	296.5KB
transform	660.4KB	-520.0B	660.9KB
total		-664.0B

page load bundle size

id	value	diff	baseline
watcher	28.3KB	-520.0B	28.8KB

distributable file count

id	value	diff	baseline
default	45850	-91	45941
oss	26592	-59	26651
total		-150

History

💚 Build #76424 succeeded 7c54be0
💚 Build #76092 succeeded ca6412c
💔 Build #76085 failed a570f53
💔 Build #76084 failed 7e4a35b
💛 Build #75697 was flaky beed1f9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* remove ALL the things. * adapt some types and tests * restore ensureValidConfiguration * fix legacy service tests * adapt uiRender mixin * remove legacy types * update generated doc * restore legacy plugin schema * update generated doc * remove remaining code of x-pack/legacy * adapt imports due to merge * cleanup CODEOWNERS * cleanup gitignore & i18nrc * cleanup tsconfig.json * remove unused i18n keys * add back `"legacy/plugins/**/*",` to tsconfig until legacy space plugin is deleted * fix create_jest_config * remove references from eslintrc * more eslint cleanup * remove `x-pack/index.js` * fix xpack gulp scripts * fix bug with default + named imports from boom * remove rules from eslintrc * remove LegacyInternals * review comments * update generated doc * cleanup legacy metadatas * revert changes to eslintrc * update generated doc # Conflicts: # .github/CODEOWNERS # x-pack/.i18nrc.json # x-pack/dev-tools/jest/create_jest_config.js # x-pack/legacy/plugins/xpack_main/index.js # x-pack/legacy/server/lib/constants/index.ts # x-pack/legacy/server/lib/key_case_converter.js # x-pack/legacy/server/lib/watch_status_and_license_to_initialize.js

* master: (31 commits) skip tests for old pacakge (elastic#78194) [Ingest Pipelines] Add url generator for ingest pipelines app (elastic#77872) [Lens] Rename "telemetry" to "stats" (elastic#78125) [CSM] Url search (elastic#77516) [Drilldowns] Config to disable URL Drilldown (elastic#77887) [Lens] Combined histogram/range aggregation for numbers (elastic#76121) Remove legacy plugins support (elastic#77599) 'Auto' interval must be correctly calculated for natural numbers (elastic#77995) [CSM] fix ingest data retry order messed up (elastic#78163) Add response status helpers (elastic#78006) Bump react-beautiful-dnd (elastic#78028) [Security Solution][Detection Engine] Bubbles up more error messages from ES queries to the UI (elastic#78004) Index pattern - refactor constructor (elastic#77791) Add `xpack.security.sameSiteCookies` to docker allow list (elastic#78192) Remove [key: string]: any; from IIndexPattern (elastic#77968) Remove requirement for manage_index_templates privilege for Index Management (elastic#77377) [Ingest Manager] Agent bulk actions UI (elastic#77690) [Metrics UI] Add inventory view timeline (elastic#77804) Reporting/Docs: Updates for setting to enable CSV Download (elastic#78101) Update to latest rum-react (elastic#78193) ...

pgayvallet added 8 commits September 16, 2020 11:16

remove ALL the things.

0ac0df2

Merge remote-tracking branch 'upstream/master' into kbn-71927-remove-…

67b4d8a

…legacy-plugins-support

adapt some types and tests

1f8249b

restore ensureValidConfiguration

4a8c362

fix legacy service tests

28db307

adapt uiRender mixin

5e76aeb

remove legacy types

aa4de2b

update generated doc

f721040

pgayvallet added Feature:Legacy Removal Issues related to removing legacy Kibana release_note:breaking Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.10.0 v8.0.0 labels Sep 16, 2020

pgayvallet added 2 commits September 16, 2020 14:19

Merge remote-tracking branch 'upstream/master' into kbn-71927-remove-…

2361249

…legacy-plugins-support

restore legacy plugin schema

e6fb281

pgayvallet added 12 commits September 18, 2020 11:21

Merge remote-tracking branch 'upstream/master' into kbn-71927-remove-…

8467833

…legacy-plugins-support

update generated doc

982494e

remove remaining code of x-pack/legacy

7363722

Merge remote-tracking branch 'upstream/master' into kbn-71927-remove-…

75a1a47

…legacy-plugins-support

adapt imports due to merge

1498f79

cleanup CODEOWNERS

719280a

cleanup gitignore & i18nrc

5e5b448

cleanup tsconfig.json

1a10e3b

remove unused i18n keys

c5d7612

add back "legacy/plugins/**/*", to tsconfig until legacy space plug…

462388a

…in is deleted

fix create_jest_config

a20cc66

Merge remote-tracking branch 'upstream/master' into kbn-71927-remove-…

6be4612

…legacy-plugins-support

sorenlouv approved these changes Sep 19, 2020

View reviewed changes

walterra approved these changes Sep 21, 2020

View reviewed changes

mshustov approved these changes Sep 21, 2020

View reviewed changes

jen-huang approved these changes Sep 21, 2020

View reviewed changes

patrykkopycinski approved these changes Sep 21, 2020

View reviewed changes

smith approved these changes Sep 21, 2020

View reviewed changes

oatkiller approved these changes Sep 21, 2020

View reviewed changes

pgayvallet added 8 commits September 22, 2020 07:45

Merge remote-tracking branch 'upstream/master' into kbn-71927-remove-…

59572bc

…legacy-plugins-support

remove rules from eslintrc

6ba8682

remove LegacyInternals

7e4a35b

review comments

91d2a6b

update generated doc

a570f53

cleanup legacy metadatas

ccf62c7

revert changes to eslintrc

18bb41c

update generated doc

ca6412c

jasonrhodes approved these changes Sep 22, 2020

View reviewed changes

spalger approved these changes Sep 22, 2020

View reviewed changes

mistic approved these changes Sep 22, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into kbn-71927-remove-…

7c54be0

…legacy-plugins-support

pgayvallet mentioned this pull request Sep 23, 2020

Move EuiThemeProvider from xpack_legacy to the kibana_react plugin #78248

Closed

pgayvallet merged commit 0d09cea into elastic:master Sep 23, 2020

pgayvallet mentioned this pull request Sep 23, 2020

[7.x] Remove legacy plugins support (#77599) #78252

Merged

pgayvallet mentioned this pull request Oct 27, 2020

Migrate i18n server part #50647

Closed

maneeshsethi mentioned this pull request Jul 21, 2021

No longer working after the legacy Plugins update OctagonMobile/Octagon-Analytics-Plugin#15

Open

RookieSA mentioned this pull request Dec 6, 2021

Add support for Kibana 7.2+ bitsensor/elastalert-kibana-plugin#116

Merged

		legacyInternals = new LegacyInternals(uiExports, config, server);
		legacyInternals = new LegacyInternals();

Remove legacy plugins support #77599

Remove legacy plugins support #77599

Uh oh!

Conversation

pgayvallet commented Sep 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Release Note

Uh oh!

joshdover commented Sep 16, 2020

Uh oh!

pgayvallet commented Sep 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pgayvallet commented Sep 17, 2020

Uh oh!

walterra left a comment

Choose a reason for hiding this comment

Uh oh!

walterra Sep 21, 2020

Choose a reason for hiding this comment

Uh oh!

mshustov left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mshustov Sep 21, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mshustov Sep 21, 2020

Choose a reason for hiding this comment

Uh oh!

mshustov Sep 21, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mshustov Sep 21, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jen-huang left a comment

Choose a reason for hiding this comment

Uh oh!

patrykkopycinski left a comment

Choose a reason for hiding this comment

Uh oh!

smith left a comment

Choose a reason for hiding this comment

Uh oh!

smith Sep 21, 2020

Choose a reason for hiding this comment

Uh oh!

jasonrhodes left a comment

Choose a reason for hiding this comment

Uh oh!

spalger left a comment

Choose a reason for hiding this comment

Uh oh!

mistic left a comment

Choose a reason for hiding this comment

Uh oh!

pgayvallet commented Sep 23, 2020

Uh oh!

kibanamachine commented Sep 23, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

async chunks size

page load bundle size

distributable file count

History

Uh oh!

Reviewers

Assignees

pgayvallet commented Sep 16, 2020 •

edited

Loading

pgayvallet commented Sep 16, 2020 •

edited

Loading

mshustov left a comment •

edited

Loading