Skip to content

[Security Solution] Refactor NetworkDns to use Search Strategy #76250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 7, 2020
Merged

[Security Solution] Refactor NetworkDns to use Search Strategy #76250

merged 10 commits into from
Sep 7, 2020

Conversation

@patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Aug 30, 2020 •
edited
Loading

Summary

image

Checklist

@patrykkopycinski patrykkopycinski self-assigned this Aug 30, 2020
@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into feat/network-…
404ba23 
…dns-search-strategy

# Conflicts:
#	x-pack/plugins/security_solution/common/search_strategy/security_solution/index.ts
#	x-pack/plugins/security_solution/common/search_strategy/security_solution/network/index.ts
#	x-pack/plugins/security_solution/public/network/components/network_top_countries_table/index.tsx
#	x-pack/plugins/security_solution/public/network/containers/network_http/index.tsx
#	x-pack/plugins/security_solution/public/network/containers/network_top_countries/index.tsx
#	x-pack/plugins/security_solution/public/network/containers/network_top_n_flow/index.tsx
#	x-pack/plugins/security_solution/public/network/containers/tls/index.tsx
#	x-pack/plugins/security_solution/public/network/pages/navigation/tls_query_tab_body.tsx
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/helpers.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/http/helpers.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/http/index.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/http/query.http_network.dsl.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/index.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/tls/query.tls_network.dsl.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/top_countries/helpers.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/top_countries/query.top_countries_network.dsl.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/top_n_flow/helpers.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/top_n_flow/index.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/network/top_n_flow/query.top_n_flow_network.dsl.ts
@patrykkopycinski
cleanup
4023e0a
@patrykkopycinski patrykkopycinski marked this pull request as ready for review September 6, 2020 09:08
@patrykkopycinski patrykkopycinski requested review from a team as code owners September 6, 2020 09:08
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 6, 2020

Pinging @elastic/siem (Team:SIEM)

@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 7, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
securitySolution 1960 +2 1958

async chunks size

id value diff baseline
securitySolution 9.9MB -193.0B 9.9MB

distributable file count

id value diff baseline
default 45435 +4 45431

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit 68a9838 into elastic:master Sep 7, 2020
@patrykkopycinski patrykkopycinski deleted the feat/network-dns-search-strategy branch September 7, 2020 12:17
@patrykkopycinski patrykkopycinski mentioned this pull request Sep 7, 2020
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Sep 7, 2020
@patrykkopycinski
[Security Solution] Refactor NetworkDns to use Search Strategy (elast…
cb4bffd 
…ic#76250)
patrykkopycinski added a commit that referenced this pull request Sep 7, 2020
@patrykkopycinski
[Security Solution] Refactor NetworkDns to use Search Strategy (#76250)…
ccf48e9 
… (#76870)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 8, 2020
@jloleysens
Merge branch 'ilm/fix/pre-existing-policy-with-no-existing-repository…
1a85d85 
…' of github.com:jloleysens/kibana into ilm/fix/pre-existing-policy-with-no-existing-repository

* 'ilm/fix/pre-existing-policy-with-no-existing-repository' of github.com:jloleysens/kibana:
  fix empty string in selected indices (elastic#76855)
  [Security Solution] Refactor OverviewHost and OverviewNetwork to use Search Strategy (elastic#76409)
  Use Search API in Timelion (sync) (elastic#75115)
  [telemetry] expose getIsOptedIn function in plugin start contract (elastic#75143)
  [ILM] Clean up remaining js files and any typings (elastic#76803)
  [Logs UI] Shared `<LogStream />` component (elastic#76262)
  [Security Solution] Add unit test for all hosts (elastic#76752)
  [Security Solution] Add unit test for authentications search strategy (elastic#76665)
  Do not apply search source data for tsvb (elastic#75137)
  [Security Solution] Refactor NetworkDns to use Search Strategy (elastic#76250)
  [SECURITY SOLUTION] Adds 'cypress:open-as-ci' command (elastic#76125)
  [Logs UI] Update alert executor tests (elastic#75764)
  [Functional] Unskip vega tests and fix flakiness (elastic#76600)
  [Data] Query String Input accepts classname prop (elastic#76848)
  [ML] Swim lane pagination for viewing by job id (elastic#76847)
  [Security Solution] Refactor MatrixHistogram to use Search Strategy (elastic#76603)
  [APM] Use the outcome field to calculate the transaction error rate chart (elastic#75528)
  [APM] Use observer.hostname instead of observer.name (elastic#76074)
  Legacy logging: fix remoteAddress being duplicated in userAgent field (elastic#76751)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 8, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/data-tier…
8b1f1dd 
…s-for-710

* 'master' of github.com:elastic/kibana:
  [Search] Use async es client endpoints (elastic#76872)
  fix empty string in selected indices (elastic#76855)
  [Security Solution] Refactor OverviewHost and OverviewNetwork to use Search Strategy (elastic#76409)
  Use Search API in Timelion (sync) (elastic#75115)
  [telemetry] expose getIsOptedIn function in plugin start contract (elastic#75143)
  [ILM] Clean up remaining js files and any typings (elastic#76803)
  [Logs UI] Shared `<LogStream />` component (elastic#76262)
  [Security Solution] Add unit test for all hosts (elastic#76752)
  [Security Solution] Add unit test for authentications search strategy (elastic#76665)
  Do not apply search source data for tsvb (elastic#75137)
  [Security Solution] Refactor NetworkDns to use Search Strategy (elastic#76250)
  [SECURITY SOLUTION] Adds 'cypress:open-as-ci' command (elastic#76125)
  [Logs UI] Update alert executor tests (elastic#75764)
  [Functional] Unskip vega tests and fix flakiness (elastic#76600)
  [Data] Query String Input accepts classname prop (elastic#76848)
  [ML] Swim lane pagination for viewing by job id (elastic#76847)
  [Security Solution] Refactor MatrixHistogram to use Search Strategy (elastic#76603)
  [APM] Use the outcome field to calculate the transaction error rate chart (elastic#75528)
  [APM] Use observer.hostname instead of observer.name (elastic#76074)
  Legacy logging: fix remoteAddress being duplicated in userAgent field (elastic#76751)

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/__jest__/components/edit_policy.test.tsx
#	x-pack/plugins/index_lifecycle_management/common/types/index.ts
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/node_allocation.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/phases/warm_phase.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/services/api.ts
@patrykkopycinski patrykkopycinski mentioned this pull request Sep 24, 2020
Merged
1 task
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 23, 2021

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angorayc angorayc angorayc approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels

release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@patrykkopycinski @elasticmachine @kibanamachine @angorayc @MindyRS