Use Search API in Timelion (sync) #75115

VladLasitsa · 2020-08-15T14:01:44Z

Closes #67585

Summary

Used Search API in Timelion

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

VladLasitsa · 2020-08-17T12:10:05Z

@elasticmachine merge upstream

VladLasitsa · 2020-08-27T15:02:56Z

@elasticmachine merge upstream

elasticmachine · 2020-08-28T08:01:36Z

Pinging @elastic/kibana-app (Team:KibanaApp)

VladLasitsa · 2020-08-31T07:32:15Z

@elasticmachine merge upstream

src/plugins/vis_type_timelion/server/plugin.ts

src/plugins/vis_type_timelion/server/series_functions/es/es.test.js

src/plugins/vis_type_timelion/server/series_functions/es/index.js

VladLasitsa · 2020-09-01T09:36:20Z

@elasticmachine merge upstream

src/plugins/vis_type_timelion/server/plugin.ts

VladLasitsa · 2020-09-02T08:00:03Z

@elasticmachine merge upstream

src/plugins/vis_type_timelion/server/series_functions/fixtures/tl_config.js

src/plugins/vis_type_timelion/server/routes/validate_es.ts

lizozom

Didn't checkout to test yet, but added a couple of comments.

src/plugins/data/server/search/types.ts

src/plugins/vis_type_timelion/server/routes/validate_es.ts

lizozom

LGTM.
Would love to get an approval from @lukasolson as well

alexwizp

LGTM! Thank you

VladLasitsa · 2020-09-04T13:05:43Z

@elasticmachine merge upstream

elasticmachine · 2020-09-04T13:05:45Z

merge conflict between base and head

sulemanof

LGTM, Tested locally in Chrome

stratoula · 2020-09-07T05:54:30Z

@elasticmachine merge upstream

stratoula

LGTM! Tested it also on Safari. @lizozom are you ok to merge it?

kibanamachine · 2020-09-07T07:46:48Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 1f5acaf

Build metrics

✅ unchanged

History

💚 Build #72640 succeeded 238a611
💚 Build #71880 succeeded a2cfc07
💚 Build #71820 succeeded 16929e0
💔 Build #71796 failed ba926c8
💔 Build #71787 failed 5488300

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

lizozom · 2020-09-07T15:04:54Z

Lets merge it

* New Search API for timelion * Using timeout from config * Use only es strategy) * Fixed remarks * Fixed tests * Fixed fixtures * Fixed ci * Fixed typecheck * Fixed eslint * Fixed remarks * Fix changes Co-authored-by: Elastic Machine <[email protected]>

* New Search API for timelion * Using timeout from config * Use only es strategy) * Fixed remarks * Fixed tests * Fixed fixtures * Fixed ci * Fixed typecheck * Fixed eslint * Fixed remarks * Fix changes Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Uladzislau Lasitsa <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

…' of github.com:jloleysens/kibana into ilm/fix/pre-existing-policy-with-no-existing-repository * 'ilm/fix/pre-existing-policy-with-no-existing-repository' of github.com:jloleysens/kibana: fix empty string in selected indices (elastic#76855) [Security Solution] Refactor OverviewHost and OverviewNetwork to use Search Strategy (elastic#76409) Use Search API in Timelion (sync) (elastic#75115) [telemetry] expose getIsOptedIn function in plugin start contract (elastic#75143) [ILM] Clean up remaining js files and any typings (elastic#76803) [Logs UI] Shared `<LogStream />` component (elastic#76262) [Security Solution] Add unit test for all hosts (elastic#76752) [Security Solution] Add unit test for authentications search strategy (elastic#76665) Do not apply search source data for tsvb (elastic#75137) [Security Solution] Refactor NetworkDns to use Search Strategy (elastic#76250) [SECURITY SOLUTION] Adds 'cypress:open-as-ci' command (elastic#76125) [Logs UI] Update alert executor tests (elastic#75764) [Functional] Unskip vega tests and fix flakiness (elastic#76600) [Data] Query String Input accepts classname prop (elastic#76848) [ML] Swim lane pagination for viewing by job id (elastic#76847) [Security Solution] Refactor MatrixHistogram to use Search Strategy (elastic#76603) [APM] Use the outcome field to calculate the transaction error rate chart (elastic#75528) [APM] Use observer.hostname instead of observer.name (elastic#76074) Legacy logging: fix remoteAddress being duplicated in userAgent field (elastic#76751)

…s-for-710 * 'master' of github.com:elastic/kibana: [Search] Use async es client endpoints (elastic#76872) fix empty string in selected indices (elastic#76855) [Security Solution] Refactor OverviewHost and OverviewNetwork to use Search Strategy (elastic#76409) Use Search API in Timelion (sync) (elastic#75115) [telemetry] expose getIsOptedIn function in plugin start contract (elastic#75143) [ILM] Clean up remaining js files and any typings (elastic#76803) [Logs UI] Shared `<LogStream />` component (elastic#76262) [Security Solution] Add unit test for all hosts (elastic#76752) [Security Solution] Add unit test for authentications search strategy (elastic#76665) Do not apply search source data for tsvb (elastic#75137) [Security Solution] Refactor NetworkDns to use Search Strategy (elastic#76250) [SECURITY SOLUTION] Adds 'cypress:open-as-ci' command (elastic#76125) [Logs UI] Update alert executor tests (elastic#75764) [Functional] Unskip vega tests and fix flakiness (elastic#76600) [Data] Query String Input accepts classname prop (elastic#76848) [ML] Swim lane pagination for viewing by job id (elastic#76847) [Security Solution] Refactor MatrixHistogram to use Search Strategy (elastic#76603) [APM] Use the outcome field to calculate the transaction error rate chart (elastic#75528) [APM] Use observer.hostname instead of observer.name (elastic#76074) Legacy logging: fix remoteAddress being duplicated in userAgent field (elastic#76751) # Conflicts: # x-pack/plugins/index_lifecycle_management/__jest__/components/edit_policy.test.tsx # x-pack/plugins/index_lifecycle_management/common/types/index.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/node_allocation.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/phases/warm_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/services/api.ts

lizozom mentioned this pull request Aug 20, 2020

Don't overwrite sync strategy in xpack #75556

Merged

7 tasks

VladLasitsa added 4 commits August 20, 2020 16:36

New Search API for timelion

2d1921f

Using timeout from config

5a11e4b

Merge remote-tracking branch 'upstream/master' into #67585_sync_search

7ae65ab

Use only es strategy)

3f7c3c4

VladLasitsa force-pushed the #67585_sync_search branch from 89c1eb6 to 3f7c3c4 Compare August 27, 2020 13:33

Merge branch 'master' into #67585_sync_search

cd97c3a

VladLasitsa marked this pull request as ready for review August 28, 2020 08:00

VladLasitsa requested a review from a team August 28, 2020 08:00

VladLasitsa self-assigned this Aug 28, 2020

VladLasitsa added release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.10.0 v8.0.0 labels Aug 28, 2020

Merge branch 'master' into #67585_sync_search

0598efb

alexwizp reviewed Aug 31, 2020

View reviewed changes

src/plugins/vis_type_timelion/server/plugin.ts Outdated Show resolved Hide resolved

alexwizp reviewed Aug 31, 2020

View reviewed changes

src/plugins/vis_type_timelion/server/series_functions/es/es.test.js Show resolved Hide resolved

alexwizp reviewed Aug 31, 2020

View reviewed changes

src/plugins/vis_type_timelion/server/series_functions/es/index.js Outdated Show resolved Hide resolved

alexwizp reviewed Aug 31, 2020

View reviewed changes

src/plugins/vis_type_timelion/server/series_functions/es/index.js Outdated Show resolved Hide resolved

VladLasitsa added 2 commits August 31, 2020 16:41

Fixed remarks

c3f0f1f

Fixed tests

3566300

elasticmachine and others added 2 commits September 1, 2020 03:36

Merge branch 'master' into #67585_sync_search

298b15b

Fixed fixtures

5a202b8

sulemanof reviewed Sep 1, 2020

View reviewed changes

src/plugins/vis_type_timelion/server/plugin.ts Show resolved Hide resolved

Fixed ci

3d2e38c

VladLasitsa requested a review from a team as a code owner September 1, 2020 14:44

VladLasitsa closed this Sep 1, 2020

VladLasitsa reopened this Sep 1, 2020

VladLasitsa added 2 commits September 1, 2020 18:32

Fixed typecheck

8f106c7

Fixed eslint

5488300

Merge branch 'master' into #67585_sync_search

ba926c8

sulemanof reviewed Sep 2, 2020

View reviewed changes

src/plugins/vis_type_timelion/server/series_functions/fixtures/tl_config.js Outdated Show resolved Hide resolved

sulemanof reviewed Sep 2, 2020

View reviewed changes

src/plugins/vis_type_timelion/server/routes/validate_es.ts Show resolved Hide resolved

Fixed remarks

16929e0

lizozom reviewed Sep 2, 2020

View reviewed changes

src/plugins/data/server/search/types.ts Show resolved Hide resolved

src/plugins/vis_type_timelion/server/routes/validate_es.ts Show resolved Hide resolved

Fix changes

a2cfc07

lizozom approved these changes Sep 3, 2020

View reviewed changes

alexwizp approved these changes Sep 3, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into #67585_sync_search

238a611

sulemanof approved these changes Sep 4, 2020

View reviewed changes

stratoula requested a review from lukasolson September 4, 2020 15:29

Merge branch 'master' into #67585_sync_search

1f5acaf

stratoula approved these changes Sep 7, 2020

View reviewed changes

stratoula merged commit 4788005 into elastic:master Sep 7, 2020

stratoula mentioned this pull request Sep 7, 2020

[7.x] Use Search API in Timelion (sync) (#75115) #76884

Merged

Use Search API in Timelion (sync) #75115

Use Search API in Timelion (sync) #75115

Uh oh!

Conversation

VladLasitsa commented Aug 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

VladLasitsa commented Aug 17, 2020

Uh oh!

VladLasitsa commented Aug 27, 2020

Uh oh!

elasticmachine commented Aug 28, 2020

Uh oh!

VladLasitsa commented Aug 31, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

VladLasitsa commented Sep 1, 2020

Uh oh!

Uh oh!

VladLasitsa commented Sep 2, 2020

Uh oh!

Uh oh!

Uh oh!

lizozom left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lizozom left a comment

Choose a reason for hiding this comment

Uh oh!

alexwizp left a comment

Choose a reason for hiding this comment

Uh oh!

VladLasitsa commented Sep 4, 2020

Uh oh!

elasticmachine commented Sep 4, 2020

Uh oh!

sulemanof left a comment

Choose a reason for hiding this comment

Uh oh!

stratoula commented Sep 7, 2020

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Sep 7, 2020

💚 Build Succeeded

Build metrics

History

Uh oh!

lizozom commented Sep 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

VladLasitsa commented Aug 15, 2020 •

edited

Loading