[Ingest Manager] Remove useless saved object update in agent checkin

[nchaulet]

Description

When the agent checkin we update the agent saved object, if some property changed like status, errors, and metadata.
We should not update the agent if none of these properties change.

Perfomance Impact

Running a local load test where I enrolled 200 agents, and do two successive checkin (during the first one the config change action is created, during the second one we just retrieve that action)

Before

checkin_first_time_duration....: avg=3.2s    min=3.06s    med=3.09s max=4.78s  p(90)=3.44s p(95)=4.15s
checkin_second_time_duration...: avg=1.08s   min=1.04s    med=1.07s max=1.46s  p(90)=1.1s  p(95)=1.11s

After

checkin_first_time_duration....: avg=2.11s   min=2.04s   med=2.08s   max=3.14s   p(90)=2.11s   p(95)=2.12s  
checkin_second_time_duration...: avg=36.02ms min=16.73ms med=36.79ms max=57.19ms p(90)=44.67ms p(95)=49.77ms

[elasticmachine]

Pinging @elastic/ingest-management (Team:Ingest Management)

[jfsiii]

LGTM 👍 Code changes make sense and the before/after show it's worth doing the check.

[nchaulet]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: add7f3f

Build metrics

✅ unchanged

History

• 💔 Build #70509 failed 0dc45d4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream