Minimal changes to support Shield Login.#7046
Merged
LeeDr merged 4 commits intoelastic:masterfrom Apr 27, 2016
Merged
Conversation
Author
|
jenkins, test it |
1 similar comment
Author
|
jenkins, test it |
Author
|
This change passed twice in a row without the change from navUrl to appUrl. |
test/support/pages/shield_page.js
Outdated
| constructor: ShieldPage, | ||
|
|
||
| login: function login(user, pwd) { | ||
| var self = this.remote; |
Contributor
There was a problem hiding this comment.
self is a misnomer here, it should probably just be remote
Contributor
|
Other than the mis-use of |
elastic-jasper
added a commit
that referenced
this pull request
Apr 27, 2016
--------- **Commit 1:** Minimal changes to support Shield Login. * Original sha: ae6aaa3 * Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-25T16:44:10Z **Commit 2:** Change to doNavigation(appUrl). * Original sha: 14be369 * Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-25T17:00:16Z **Commit 3:** Revert back to doNavigation(navUrl). * Original sha: fbb3e20 * Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-25T17:40:35Z **Commit 4:** Change 'self' to 'remote'. * Original sha: 935fee7 * Authored by LeeDr <lee.drengenberg@elastic.co> on 2016-04-27T20:21:39Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.