Support local testing with Shield Kibana plugin#6800
Closed
LeeDr wants to merge 17 commits intoelastic:masterfrom
Closed
Support local testing with Shield Kibana plugin#6800LeeDr wants to merge 17 commits intoelastic:masterfrom
LeeDr wants to merge 17 commits intoelastic:masterfrom
Conversation
added 4 commits
April 6, 2016 09:53
…IndicesTab to get back after the Advanced test.
rashidkpc
changed the title
Author
|
jenkins, test it |
1 similar comment
Author
|
jenkins, test it |
LeeDr
changed the title
Author
|
I tested this locally with and without Shield, and on both Firefox and Chrome. |
Contributor
|
@LeeDr I'm going to assign this back to you since this doesn't seem to be passing on jenkins. Assign it back when they're passing more consistently |
Author
|
jenkins, test it |
added 5 commits
April 22, 2016 10:12
…the page load failures.
Author
|
I finally figured out where the problem was with this. The modifyQueryString method was still including the 'auth' part but shouldn't have. Although I don't understand why it always passed locally but not on Jenkins. Should I squash this down or something? |
Contributor
|
You don't have to, no. Your call though. |
| return settingsPage.setAdvancedSettings('dateFormat:tz', 'UTC'); | ||
| }) | ||
| .then(function (advancedSetting) { | ||
| ;return settingsPage.clickIndicesTab(); |
| return settingsPage.navigateTo(); | ||
| return settingsPage.navigateTo() | ||
| .then(function () { | ||
| return settingsPage.clickIndicesTab(); |
Contributor
There was a problem hiding this comment.
Rather than nest this, can you just chain it?
scenarioManager.reload('emptyKibana')
.then(() => settingsPage.navigateTo())
.then(() => settingsPage.clickIndicesTab())just seems nicer than
scenarioManager.reload('emptyKibana')
.then(() => settingsPage.navigateTo().then(() => settingsPage.clickIndicesTab()))
Author
|
jenkins, test it |
Author
|
jenkins, test it |
Author
|
Replaced by #7046 Not merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not ready for review/merge yet. Just testing WIP.