Prep State Transfer for Embeddables By Value#69991
Merged
majagrubic merged 2 commits intoelastic:masterfrom Jun 26, 2020
Merged
Prep State Transfer for Embeddables By Value#69991majagrubic merged 2 commits intoelastic:masterfrom
majagrubic merged 2 commits intoelastic:masterfrom
Conversation
ThomThomson
added
Feature:Dashboard
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
ThomThomson
force-pushed
the
arch/stateTransferPrep
branch
from
9719758 to
87e8ebd
Compare
majagrubic
reviewed
Jun 26, 2020
| export interface EmbeddableOriginatingAppState { | ||
| export interface EmbeddableEditorState { | ||
| originatingApp: string; | ||
| byValueMode?: boolean; |
Contributor
There was a problem hiding this comment.
as discussed, I'd rather if we didn't have an explicit "byValue" parameter, but totally fine with leaving it for now.
majagrubic
approved these changes
Jun 26, 2020
Contributor
|
@elasticmachine merge upstream |
streamich
approved these changes
Jun 26, 2020
Contributor
streamich
left a comment
streamich
left a comment
There was a problem hiding this comment.
AppArch code changes LGTM.
Dosant
approved these changes
Jun 26, 2020
| container.addNewEmbeddable<SavedObjectEmbeddableInput>(incomingState.type, { | ||
| savedObjectId: incomingState.id, | ||
| }); | ||
| if ('id' in incomingState) { |
Contributor
There was a problem hiding this comment.
nit: I'd put these type guards near EmbeddablePackageState
Contributor
There was a problem hiding this comment.
Could you elaborate a bit on this? Typescript complains once we do addNewEmbeddable as it doesn't know if there's id field in that object (similarly for input). I don't know of another way of doing this.
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 26, 2020
* master: (34 commits) Upgrade `elliptic` dependency (`6.5.2` → `6.5.3`). (elastic#70054) [License Management] Do not break when `telemetry.enabled:false` (elastic#69711) [SECURITY] Redirect app/security to app/security/overview (elastic#70005) "Explore underlying data" in-chart action (elastic#69494) Api reference docs for state_containers and state_sync (elastic#67354) prep state transfer for passing embeddables by value to editor and back (elastic#69991) move Metrics API to start (elastic#69787) refactor: 💡 fix typo in embeddable (elastic#69417) [alerting] migrates the old `alerting` consumer to be `alerts` (elastic#69982) [APM]Create API to return data to be used on the Overview page (elastic#69137) [Lens] Fix delete button position in dimension panel for long labels (elastic#69495) [Lens] Add toolbar api (elastic#69263) Fixes bug on color picker defaults on TSVB (elastic#69889) [DOCS] Fixes wording in Upload a CSV section (elastic#69969) [Discover] Validate timerange before submitting query to ES (elastic#69363) [Maps] avoid using MAP_SAVED_OBJECT_TYPE constant when defining URL paths (elastic#69723) [Maps] Fix icon palettes are not working (elastic#69937) [Ingest Manager] Fix typo in constant name (elastic#69919) [test] skip status.allowAnonymous tests on cloud (elastic#69017) Fix backport (elastic#70003) ...
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Jun 26, 2020
…ck (elastic#69991) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes some prep work to allow the state transfer service to pass embeddables by value when moving to the editor, and back to the container.
Checklist
Delete any items that are not applicable to this PR.
For maintainers