[License Management] Do not break when telemetry.enabled:false#69711
Merged
afharo merged 4 commits intoelastic:masterfrom Jun 26, 2020
Merged
[License Management] Do not break when telemetry.enabled:false#69711afharo merged 4 commits intoelastic:masterfrom
telemetry.enabled:false#69711afharo merged 4 commits intoelastic:masterfrom
Conversation
afharo
added
release_note:skip
Member
Author
|
@elasticmachine merge upstream |
cjcenizal
added
Feature:License
Team:Kibana Management
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
Member
Author
|
@elasticmachine merge upstream |
TinaHeiligers
approved these changes
Jun 25, 2020
Contributor
TinaHeiligers
left a comment
TinaHeiligers
left a comment
There was a problem hiding this comment.
Interesting solution! I search the code base and couldn't find another direct implementation of React.lazy(). I wonder if the design team is implementing this somewhere?
LGTM.
cjcenizal
approved these changes
Jun 25, 2020
Contributor
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
Tested locally, code LGTM. Thanks for fixing this!
With telemetry enabled
With telemetry disabled
| onClose={() => this.setState({ showExample: false })} | ||
| fetchExample={telemetry.telemetryService.fetchExample} | ||
| /> | ||
| <React.Suspense fallback={<EuiLoadingSpinner />}> |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
page load asset sizebeta
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 26, 2020
* master: (34 commits) Upgrade `elliptic` dependency (`6.5.2` → `6.5.3`). (elastic#70054) [License Management] Do not break when `telemetry.enabled:false` (elastic#69711) [SECURITY] Redirect app/security to app/security/overview (elastic#70005) "Explore underlying data" in-chart action (elastic#69494) Api reference docs for state_containers and state_sync (elastic#67354) prep state transfer for passing embeddables by value to editor and back (elastic#69991) move Metrics API to start (elastic#69787) refactor: 💡 fix typo in embeddable (elastic#69417) [alerting] migrates the old `alerting` consumer to be `alerts` (elastic#69982) [APM]Create API to return data to be used on the Overview page (elastic#69137) [Lens] Fix delete button position in dimension panel for long labels (elastic#69495) [Lens] Add toolbar api (elastic#69263) Fixes bug on color picker defaults on TSVB (elastic#69889) [DOCS] Fixes wording in Upload a CSV section (elastic#69969) [Discover] Validate timerange before submitting query to ES (elastic#69363) [Maps] avoid using MAP_SAVED_OBJECT_TYPE constant when defining URL paths (elastic#69723) [Maps] Fix icon palettes are not working (elastic#69937) [Ingest Manager] Fix typo in constant name (elastic#69919) [test] skip status.allowAnonymous tests on cloud (elastic#69017) Fix backport (elastic#70003) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #69543
After the improvements done in the optimizer, if a plugin is disabled, other plugins are not able to reuse its exported components (even though, code-wise, it may be possible).
This PR fixes 2 issues in the License Management plugin:
OptInExampleFlyoutfrom the plugintelemetry_management_section(it requirestelemetryas a dependency so, as a side effect, it's also disabled): When lazily imported, React won't fail to render the component. But also, since we are using the component in a piece of code that is only called if telemetry is enabled, it results in Kibana never trying to import the plugin at all.For maintainers