Skip to content

Use ts-expect-error in platform code#69883

Merged
mshustov merged 13 commits intoelastic:masterfrom
mshustov:core-ts-expect-error
Jun 30, 2020
Merged

Use ts-expect-error in platform code#69883
mshustov merged 13 commits intoelastic:masterfrom
mshustov:core-ts-expect-error

Conversation

@mshustov
Copy link
Contributor

@mshustov mshustov commented Jun 25, 2020

Summary

  1. Migrates from @ts-ignore to @ts-expect-error, removes unnecessary comments
  2. Fixes errors in dependent code.

Most of the changes related to the fact that in the master immutable array has a mutable type.

@mshustov mshustov requested review from a team as code owners June 25, 2020 07:23
@mshustov mshustov added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// and removed Platform:Windows labels Jun 25, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 25, 2020

Pinging @elastic/kibana-platform (Team:Platform)

@mshustov mshustov added the release_note:skip Skip the PR/issue when compiling release notes label Jun 25, 2020
mshustov
mshustov commented Jun 25, 2020
View reviewed changes
x-pack/plugins/spaces/public/management/spaces_grid/spaces_grid_page.tsx Outdated
loading: false,
spaces,
features,
features: features.map((f) => f.toRaw()),
Copy link
Contributor Author

@mshustov mshustov Jun 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the code down the react tree expects FeatureConfig

@mshustov mshustov changed the title Use ts-expect-error in code Use ts-expect-error in platform code Jun 25, 2020
azasypkin
azasypkin approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces/Security changes LGTM on green CI.

@mshustov mshustov requested a review from a team June 26, 2020 09:47
@mshustov mshustov requested a review from a team as a code owner June 26, 2020 09:47
pgayvallet
pgayvallet approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshustov
Copy link
Contributor Author

mshustov commented Jun 29, 2020

@elasticmachine merge upstream

timroes
timroes approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review only, of Kibana App code, LGTM

streamich
streamich approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppArch changes LGTM.

@mshustov mshustov force-pushed the core-ts-expect-error branch from 843edb0 to 589847c Compare June 29, 2020 16:58
@mshustov
Copy link
Contributor Author

mshustov commented Jun 29, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 29, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit 159369b into elastic:master Jun 30, 2020
@mshustov mshustov deleted the core-ts-expect-error branch June 30, 2020 05:37
@mshustov mshustov mentioned this pull request Jun 30, 2020
Merged
mshustov added a commit to mshustov/kibana that referenced this pull request Jun 30, 2020
@mshustov @elasticmachine
Use ts-expect-error in platform code (elastic#69883)
86e3438 
* ts-ignore --> ts-expect-error

* fix error with mutable array

* fix errors in consumers code

* update SOM

* fix FeatureConfig & Feature compatibility

* do not re-export from code. it breaks built version

* update docs

* add eslint rule for platform team code

* remove test. this is covered by ts-expect-error in unit tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	src/core/utils/integration_tests/__fixtures__/frozen_object_mutation/tsconfig.json
mshustov added a commit that referenced this pull request Jun 30, 2020
@mshustov @elasticmachine
Use ts-expect-error in platform code (#69883) (#70287)
03e7216 
* ts-ignore --> ts-expect-error

* fix error with mutable array

* fix errors in consumers code

* update SOM

* fix FeatureConfig & Feature compatibility

* do not re-export from code. it breaks built version

* update docs

* add eslint rule for platform team code

* remove test. this is covered by ts-expect-error in unit tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	src/core/utils/integration_tests/__fixtures__/frozen_object_mutation/tsconfig.json
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 30, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into slm/support-d…
3f6f5ac 
…ata-streams

* 'master' of github.com:elastic/kibana: (50 commits)
  [Logs UI] [Alerting] "Group by" functionality (elastic#68250)
  [Discover] Deangularize Skip to bottom button (elastic#69811)
  Implement recursive plugin discovery (elastic#68811)
  Use ts-expect-error in platform code (elastic#69883)
  [SIEM][Detection Engine][Lists] Moves getQueryFilter to common folder for use by both front and backend
  [Ingest Manager][SECURITY SOLUTION] adjust config reassign link and add roundtrip to Reassignment flow (elastic#70208)
  [Security][Lists] Add API functions and react hooks for value list APIs (elastic#69603)
  [ILM] Fix bug when clearing priority field (elastic#70154)
  [Platform][Security] Updates cluster_manager ignorePaths to include security scripts (elastic#70139)
  [IngestManager] Allow to filter agent by packages (elastic#69731)
  [code coverage] exclude folders: test_helpers, tests_bundle (elastic#70199)
  [Metrics UI] UX improvements for saved views (elastic#69910)
  [APM] docs: unique transaction troubleshooting (elastic#69831)
  Cross cluster search functional test with minimun privileges assigned to the test_user (elastic#70007)
  [Maps] choropleth layer wizard (elastic#69699)
  Make custom errors by extending Error (elastic#69966)
  [Ingest Manager] Support updated package output structure (elastic#69864)
  Resolver test coverage (elastic#70246)
  Async Discover search test (elastic#64388)
  [ui-shared-deps] include styled-components (elastic#69322)
  ...

# Conflicts:
#	x-pack/plugins/snapshot_restore/server/types.ts
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 30, 2020
@gmmorris
Merge branch 'alerting/consumer-based-rbac' of github.com:gmmorris/ki…
f22c7aa 
…bana into alerting/consumer-based-rbac

* 'alerting/consumer-based-rbac' of github.com:gmmorris/kibana: (49 commits)
  [Discover] Deangularize Skip to bottom button (elastic#69811)
  Implement recursive plugin discovery (elastic#68811)
  Use ts-expect-error in platform code (elastic#69883)
  [SIEM][Detection Engine][Lists] Moves getQueryFilter to common folder for use by both front and backend
  [Ingest Manager][SECURITY SOLUTION] adjust config reassign link and add roundtrip to Reassignment flow (elastic#70208)
  [Security][Lists] Add API functions and react hooks for value list APIs (elastic#69603)
  [ILM] Fix bug when clearing priority field (elastic#70154)
  [Platform][Security] Updates cluster_manager ignorePaths to include security scripts (elastic#70139)
  [IngestManager] Allow to filter agent by packages (elastic#69731)
  [code coverage] exclude folders: test_helpers, tests_bundle (elastic#70199)
  [Metrics UI] UX improvements for saved views (elastic#69910)
  [APM] docs: unique transaction troubleshooting (elastic#69831)
  Cross cluster search functional test with minimun privileges assigned to the test_user (elastic#70007)
  [Maps] choropleth layer wizard (elastic#69699)
  Make custom errors by extending Error (elastic#69966)
  [Ingest Manager] Support updated package output structure (elastic#69864)
  Resolver test coverage (elastic#70246)
  Async Discover search test (elastic#64388)
  [ui-shared-deps] include styled-components (elastic#69322)
  SECURITY-ENDPOINT: add host properties (elastic#70238)
  ...
Bamieh pushed a commit to Bamieh/kibana that referenced this pull request Jul 1, 2020
@mshustov @elasticmachine @Bamieh
Use ts-expect-error in platform code (elastic#69883)
2a133d1 
* ts-ignore --> ts-expect-error

* fix error with mutable array

* fix errors in consumers code

* update SOM

* fix FeatureConfig & Feature compatibility

* do not re-export from code. it breaks built version

* update docs

* add eslint rule for platform team code

* remove test. this is covered by ts-expect-error in unit tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattkime mattkime mattkime approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@azasypkin azasypkin azasypkin approved these changes

+2 more reviewers

@timroes timroes timroes approved these changes

@streamich streamich streamich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mshustov @elasticmachine @kibanamachine @mattkime @timroes @pgayvallet @azasypkin @streamich