[ui-shared-deps] include styled-components by spalger · Pull Request #69322 · elastic/kibana

spalger · 2020-06-16T19:15:34Z

styled-components relies on a single instance so that the correct provider can be used to populate theme variables, which means that plugins need to be able to rely on a single instance of sytled-components on a page at a time in order to interoperate.

NOTE: This dependency is only used in x-pack and is the first of which we've added to @kbn/ui-shared-deps. I don't think this is something that should stop us from including the dependency, it only increases the ui-shared-deps bundle size a little, but it's something to keep in mind. We should probably come up with a good way for plugins to share an instance of a dependency that will prevent us from shipping extra deps in OSS that aren't necessary.

sorenlouv

🥇

…re-styled-components

elasticmachine · 2020-06-16T23:57:52Z

Pinging @elastic/kibana-operations (Team:Operations)

mistic

LGTM

…re-styled-components # Conflicts: # packages/kbn-ui-shared-deps/package.json

patrykkopycinski

Thank you @spalger 💪

sorenlouv · 2020-06-26T13:20:25Z

Can I get a review from @elastic/endpoint-app-team , please 🙏

spalger · 2020-06-27T10:35:58Z

@elasticmachine merge upstream

…re-styled-components

…r/kibana into implement/share-styled-components

...ty_solution/public/overview/components/overview_host_stats/__snapshots__/index.test.tsx.snap

kibanamachine · 2020-06-29T19:56:49Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 3c6cb8b

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
apm	652	-6	658
beats_management	174	-9	183
canvas	788	-8	796
crossClusterReplication	60	-2	62
graph	92	-2	94
indexLifecycleManagement	92	-2	94
indexManagement	142	-2	144
infra	597	-9	606
ingestManager	353	-7	360
licenseManagement	91	-2	93
maps	454	-2	456
observability	10	-10	20
remoteClusters	66	-2	68
rollup	131	-2	133
securitySolution	780	-8	788
uptime	251	-9	260
total	-	-82	-

History

💔 Build #56930 failed 6f1bfe2
💔 Build #55358 failed cd03627
💚 Build #54529 succeeded 315ae9f
💔 Build #54479 failed e398926

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* [ui-shared-deps] include styled-components * update snapshots caused by react-is upgrade * fix jest snapshots * declare react-is dep in x-pack too so it uses the right version Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* [ui-shared-deps] include styled-components * update snapshots caused by react-is upgrade * fix jest snapshots * declare react-is dep in x-pack too so it uses the right version Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…ata-streams * 'master' of github.com:elastic/kibana: (50 commits) [Logs UI] [Alerting] "Group by" functionality (elastic#68250) [Discover] Deangularize Skip to bottom button (elastic#69811) Implement recursive plugin discovery (elastic#68811) Use ts-expect-error in platform code (elastic#69883) [SIEM][Detection Engine][Lists] Moves getQueryFilter to common folder for use by both front and backend [Ingest Manager][SECURITY SOLUTION] adjust config reassign link and add roundtrip to Reassignment flow (elastic#70208) [Security][Lists] Add API functions and react hooks for value list APIs (elastic#69603) [ILM] Fix bug when clearing priority field (elastic#70154) [Platform][Security] Updates cluster_manager ignorePaths to include security scripts (elastic#70139) [IngestManager] Allow to filter agent by packages (elastic#69731) [code coverage] exclude folders: test_helpers, tests_bundle (elastic#70199) [Metrics UI] UX improvements for saved views (elastic#69910) [APM] docs: unique transaction troubleshooting (elastic#69831) Cross cluster search functional test with minimun privileges assigned to the test_user (elastic#70007) [Maps] choropleth layer wizard (elastic#69699) Make custom errors by extending Error (elastic#69966) [Ingest Manager] Support updated package output structure (elastic#69864) Resolver test coverage (elastic#70246) Async Discover search test (elastic#64388) [ui-shared-deps] include styled-components (elastic#69322) ... # Conflicts: # x-pack/plugins/snapshot_restore/server/types.ts

…bana into alerting/consumer-based-rbac * 'alerting/consumer-based-rbac' of github.com:gmmorris/kibana: (49 commits) [Discover] Deangularize Skip to bottom button (elastic#69811) Implement recursive plugin discovery (elastic#68811) Use ts-expect-error in platform code (elastic#69883) [SIEM][Detection Engine][Lists] Moves getQueryFilter to common folder for use by both front and backend [Ingest Manager][SECURITY SOLUTION] adjust config reassign link and add roundtrip to Reassignment flow (elastic#70208) [Security][Lists] Add API functions and react hooks for value list APIs (elastic#69603) [ILM] Fix bug when clearing priority field (elastic#70154) [Platform][Security] Updates cluster_manager ignorePaths to include security scripts (elastic#70139) [IngestManager] Allow to filter agent by packages (elastic#69731) [code coverage] exclude folders: test_helpers, tests_bundle (elastic#70199) [Metrics UI] UX improvements for saved views (elastic#69910) [APM] docs: unique transaction troubleshooting (elastic#69831) Cross cluster search functional test with minimun privileges assigned to the test_user (elastic#70007) [Maps] choropleth layer wizard (elastic#69699) Make custom errors by extending Error (elastic#69966) [Ingest Manager] Support updated package output structure (elastic#69864) Resolver test coverage (elastic#70246) Async Discover search test (elastic#64388) [ui-shared-deps] include styled-components (elastic#69322) SECURITY-ENDPOINT: add host properties (elastic#70238) ...

* [ui-shared-deps] include styled-components * update snapshots caused by react-is upgrade * fix jest snapshots * declare react-is dep in x-pack too so it uses the right version Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

[ui-shared-deps] include styled-components

e398926

sorenlouv approved these changes Jun 16, 2020

View reviewed changes

spalger added 2 commits June 16, 2020 15:18

update snapshots caused by react-is upgrade

df19ac8

Merge branch 'master' of github.com:elastic/kibana into implement/sha…

315ae9f

…re-styled-components

spalger added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.8.0 v7.9.0 v8.0.0 labels Jun 16, 2020

spalger marked this pull request as ready for review June 16, 2020 23:57

spalger requested review from a team as code owners June 16, 2020 23:57

mistic approved these changes Jun 17, 2020

View reviewed changes

spalger added v7.8.1 and removed v7.8.0 labels Jun 18, 2020

Merge branch 'master' of github.com:elastic/kibana into implement/sha…

cd03627

…re-styled-components # Conflicts: # packages/kbn-ui-shared-deps/package.json

patrykkopycinski approved these changes Jun 21, 2020

View reviewed changes

elasticmachine and others added 4 commits June 27, 2020 05:36

Merge branch 'master' into implement/share-styled-components

6f1bfe2

Merge branch 'master' of github.com:elastic/kibana into implement/sha…

68de1a1

…re-styled-components

fix jest snapshots

546469b

Merge branch 'implement/share-styled-components' of github.com:spalge…

77c2264

…r/kibana into implement/share-styled-components

oatkiller approved these changes Jun 29, 2020

View reviewed changes

...ty_solution/public/overview/components/overview_host_stats/__snapshots__/index.test.tsx.snap Outdated Show resolved Hide resolved

declare react-is dep in x-pack too so it uses the right version

3c6cb8b

spalger merged commit 9c965fe into elastic:master Jun 29, 2020

spalger deleted the implement/share-styled-components branch June 29, 2020 20:06

spalger mentioned this pull request Jun 29, 2020

[7.x] [ui-shared-deps] include styled-components (#69322) #70252

Merged

spalger added v7.8.1 and removed v7.8.1 labels Jun 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ui-shared-deps] include styled-components#69322

[ui-shared-deps] include styled-components#69322
spalger merged 9 commits intoelastic:masterfrom
spalger:implement/share-styled-components

spalger commented Jun 16, 2020 •

edited

Loading

Uh oh!

sorenlouv left a comment

Uh oh!

elasticmachine commented Jun 16, 2020

Uh oh!

mistic left a comment

Uh oh!

patrykkopycinski left a comment

Uh oh!

sorenlouv commented Jun 26, 2020

Uh oh!

spalger commented Jun 27, 2020

Uh oh!

Uh oh!

kibanamachine commented Jun 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

spalger commented Jun 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sorenlouv left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jun 16, 2020

Uh oh!

mistic left a comment

Choose a reason for hiding this comment

Uh oh!

patrykkopycinski left a comment

Choose a reason for hiding this comment

Uh oh!

sorenlouv commented Jun 26, 2020

Uh oh!

spalger commented Jun 27, 2020

Uh oh!

Uh oh!

kibanamachine commented Jun 29, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

spalger commented Jun 16, 2020 •

edited

Loading