[Metrics UI] Fix fatal error when no data is available for Metric Threshold Alerts#68678
Merged
simianhacker merged 4 commits intoelastic:masterfrom Jun 10, 2020
Merged
Conversation
simianhacker
added
release_note:fix
Feature:Metrics UI
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Jun 10, 2020
…eshold Alerts (elastic#68678) * [Metrics UI] Fix fatal error when no data is available for Metric Threshold Alerts * Adding i18n support for error message * Adding test
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Jun 10, 2020
…eshold Alerts (elastic#68678) * [Metrics UI] Fix fatal error when no data is available for Metric Threshold Alerts * Adding i18n support for error message * Adding test
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 10, 2020
* master: [Ingest Manager] Document fleet configuration flags (elastic#66736) [Metrics UI] Fix fatal error when no data is available for Metric Threshold Alerts (elastic#68678) [SIEM][Detections Engine] - Exceptions viewer cleanup (elastic#68651) [SIEM] Fixes flyout flaky test (elastic#68683) [SIEM] Cypress renaming (elastic#68659)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a fatal error with the Metric Threshold Alerts in the central management UI when there is no data available. This also adds i18n support for the error message.
Testing